[GitHub] [spark] LuciferYang commented on a change in pull request #33963: [SPARK-36636][CORE][TEST] LocalSparkCluster change to use tmp workdir in test to avoid directory name collision

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #33963:
URL: https://github.com/apache/spark/pull/33963#discussion_r706630710



##########
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##########
@@ -63,8 +63,11 @@ class LocalSparkCluster(
 
     /* Start the Workers */
     for (workerNum <- 1 to numWorkers) {
+      val workDir = if (Utils.isTesting) {

Review comment:
       This change is mainly to fix the potential UTs failures. Although it seems to be applicable in non-test scenarios, but it may affect users' usage habits. For example, some log file  that we don't care in UTs will change to use a temp dir




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org