[Bug 57084] New: Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

            Bug ID: 57084
           Summary: Minor code formatting but also closed sock in
                    BeanShellClient
           Product: JMeter
           Version: Nightly (Please specify date)
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: jmeter@ham1.co.uk

Created attachment 32107
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32107&action=edit
Code patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

--- Comment #5 from Sebb <se...@apache.org> ---
Bugzilla is not ideal for discussions.

Please use the developer list for discussions on formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

--- Comment #3 from Sebb <se...@apache.org> ---
The formatting changes mostly look OK, though not essential.

However we don't apply such changes in the same commit as a code change, as it
makes it more difficult to review the change, and makes reverts harder (should
they be needed)/

Generally each commit should fix a single issue.
Formatting changes should not be combined with other changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Closed socket in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
            Summary|Minor code formatting but   |Closed socket in
                   |also closed sock in         |BeanShellClient
                   |BeanShellClient             |

--- Comment #6 from Sebb <se...@apache.org> ---
Changed the title to agree with the action taken

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

--- Comment #4 from Graham <jm...@ham1.co.uk> ---
Fair points - I will keep them separate in future - I didn't this time as I had
already created the patch before I noticed the closing of the socket and I
thought it such a small change as to not warrant splitting it out.

On the topic of formatting, while I agree formatting is not essential - I do
think it is actually quite important when trying to further improve the
readability of code for people both new and old to the project. Consistent
formatting also, for me, gives a better impression of the code base and makes
it easier to read.

Do we have (or could I raise a ticket about) an eclipse Java code formatter
(and maybe one for other IDEs if people use them, or just format code using
eclipse
http://blogs.operationaldynamics.com/andrew/software/java-gnome/eclipse-code-format-from-command-line)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
I only committed the close operation on the socket.

I haven't committed the formatting changes, since I don't know the exact policy
for such cosmetic changes (and my eclipse formatting would have produced
slightly different changes).

Thanks for the contribution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57084] Minor code formatting but also closed sock in BeanShellClient

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57084

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Date: Tue Oct 14 09:09:29 2014
New Revision: 1631689

URL: http://svn.apache.org/r1631689
Log:
Bug 57084 - BeanShellClient: Close socket after usage.
Bugzilla Id: 57084

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellClient.java

-- 
You are receiving this mail because:
You are the assignee for the bug.