You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/01/23 21:06:33 UTC
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15083
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
IMPALA-4224: part 2: refactor filter routing table to support sinks
This is some refactoring that will enable us to correctly
construct a routing table where join build sinks produce filters:
* The previous code relied (non-obviously) on producers being
visited before consumers when walking the plan tree. This is no
longer true when build sinks produce filters. The code is
changed so it can construct the routing table entry when the
first producer or consumer is visited (using GetOrCreateFilterState())
* The source plan node ID is added to TRuntimeFilterDesc, so that
it's available when visiting consumer nodes.
* The logic for adding a filter source to the routing table is factored
out into a separate function AddFilterSource(), which can be used
(in a later patch) for join build sinks.
This change is not expected to change behaviour in any way.
Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
---
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
5 files changed, 78 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15083/4
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 7: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 18:28:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 04:33:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h
File be/src/runtime/coordinator-filter-state.h:
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167
PS6, Line 167: emplace
> Based on the text from https://en.cppreference.com/w/cpp/container/unordere
I switched to explicitly checking whether the entry exists before calling emplace().
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167
PS6, Line 167: std::piecewise_construct,
: std::forward_as_tuple(filter.filter_id),
: std::forward_as_tuple
> nit: I see it's moved from coordinator.cc but maybe we could just use std::
I wasn't able to avoid this incantation - I think the problem this incantation avoids is that FilterState is not movable because of the SpinLock.
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 18:28:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5481/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 04:33:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5508/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 21:51:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 09:24:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15083
to look at the new patch set (#5).
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
IMPALA-4224: part 2: refactor filter routing table to support sinks
This is some refactoring that will enable us to correctly
construct a routing table where join build sinks produce filters:
* The previous code relied (non-obviously) on producers being
visited before consumers when walking the plan tree. This is no
longer true when build sinks produce filters. The code is
changed so it can construct the routing table entry when the
first producer or consumer is visited (using GetOrCreateFilterState())
* The source plan node ID is added to TRuntimeFilterDesc, so that
it's available when visiting consumer nodes.
* The logic for adding a filter source to the routing table is factored
out into a separate function AddFilterSource(), which can be used
(in a later patch) for join build sinks.
This change is not expected to change behaviour in any way.
Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
---
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
5 files changed, 77 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15083/5
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h
File be/src/runtime/coordinator-filter-state.h:
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167
PS6, Line 167: emplace
Based on the text from https://en.cppreference.com/w/cpp/container/unordered_map/emplace this might cause an extra copying of filter when the key exists:
"The element may be constructed even if there already is an element with the key in the container, in which case the newly constructed element will be destroyed immediately."
http://gerrit.cloudera.org:8080/#/c/15083/6/be/src/runtime/coordinator-filter-state.h@167
PS6, Line 167: std::piecewise_construct,
: std::forward_as_tuple(filter.filter_id),
: std::forward_as_tuple
nit: I see it's moved from coordinator.cc but maybe we could just use std::make_pair() to keep it simple.
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 15:14:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5535/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 01:33:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15083
to look at the new patch set (#7).
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
IMPALA-4224: part 2: refactor filter routing table to support sinks
This is some refactoring that will enable us to correctly
construct a routing table where join build sinks produce filters:
* The previous code relied (non-obviously) on producers being
visited before consumers when walking the plan tree. This is no
longer true when build sinks produce filters. The code is
changed so it can construct the routing table entry when the
first producer or consumer is visited (using GetOrCreateFilterState())
* The source plan node ID is added to TRuntimeFilterDesc, so that
it's available when visiting consumer nodes.
* The logic for adding a filter source to the routing table is factored
out into a separate function AddFilterSource(), which can be used
(in a later patch) for join build sinks.
This change is not expected to change behaviour in any way.
Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
---
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
5 files changed, 80 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/15083/7
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
IMPALA-4224: part 2: refactor filter routing table to support sinks
This is some refactoring that will enable us to correctly
construct a routing table where join build sinks produce filters:
* The previous code relied (non-obviously) on producers being
visited before consumers when walking the plan tree. This is no
longer true when build sinks produce filters. The code is
changed so it can construct the routing table entry when the
first producer or consumer is visited (using GetOrCreateFilterState())
* The source plan node ID is added to TRuntimeFilterDesc, so that
it's available when visiting consumer nodes.
* The logic for adding a filter source to the routing table is factored
out into a separate function AddFilterSource(), which can be used
(in a later patch) for join build sinks.
This change is not expected to change behaviour in any way.
Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Reviewed-on: http://gerrit.cloudera.org:8080/15083
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
5 files changed, 80 insertions(+), 54 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5551/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 19:13:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4224: part 2: refactor filter routing table to support sinks
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15083 )
Change subject: IMPALA-4224: part 2: refactor filter routing table to support sinks
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc53ae0167af45e32093a024ff2d6e2c6466c876
Gerrit-Change-Number: 15083
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 02:02:06 +0000
Gerrit-HasComments: No