You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 18:36:24 UTC
[GitHub] [airflow] potiuk opened a new pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
potiuk opened a new pull request #10522:
URL: https://github.com/apache/airflow/pull/10522
…able hook and operator (#10475)"
This reverts commit b0598b5351d2d027286e2333231b6c0c0704dba2.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
olchas commented on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679300998
I think the reason for broken master is the combination of @derrickqin's https://github.com/apache/airflow/pull/10475 and my change https://github.com/apache/airflow/pull/10052. @derrickqin's PR added two tests of `BigtableCreateInstanceOperator` that I have not covered in my PR after rebasing. I apologize for that. Here is the fix: https://github.com/apache/airflow/pull/10521.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #10522:
URL: https://github.com/apache/airflow/pull/10522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679311128
Cool. Thanks @olchas ! Nothing to worry about -- this is the rare case where two overlapping changes tested in isolation do not work when they are both merged :). No-one's fault, just a consequence of us not doing the full cycle of rebase + wait for build after anything is merged (that would be very costly, so we accept that things break in such cases very rarely).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas edited a comment on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
olchas edited a comment on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679300998
Hi @potiuk, I think the reason for broken master is the combination of @derrickqin's https://github.com/apache/airflow/pull/10475 and my change https://github.com/apache/airflow/pull/10052. @derrickqin's PR added two tests of `BigtableCreateInstanceOperator` that I have not covered in my PR after rebasing. I apologize for that. Here is the fix: https://github.com/apache/airflow/pull/10521.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679311297
@derrickqin -> alarm called off :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas edited a comment on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
olchas edited a comment on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679300998
Hi @potiuk, I think the reason for broken master is the combination of @derrickqin's https://github.com/apache/airflow/pull/10475 and my change https://github.com/apache/airflow/pull/10052. @derrickqin's PR added two tests of `BigtableCreateInstanceOperator` that I have not included in my PR before it was merged. I apologize for that. Here is the fix: https://github.com/apache/airflow/pull/10521.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10522: Revert "Add support for creating multiple replicated clusters in Bigt…
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10522:
URL: https://github.com/apache/airflow/pull/10522#issuecomment-679298391
It think the #10475 broke the mater. It looks like the tests passed before they were merged, but the build was running before the fx #10472 was merged that was mixing local/image sources or it could be a manifestation of #10471. I will take a look where it came from and whether we need to implement the workaround I described in #10471. For now - let's revert it - and I will ask the author to resubmit it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org