You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Andrea Cosentino <an...@gmail.com> on 2021/03/02 14:25:27 UTC

Re: [camel] branch camel-3.8.x updated: [CAMEL-16063]don't start camel context if event is from the self management ApplicationContext

This is not needed, 3.8.x won't be released anymore, it's not an LTS. No
need to revert, but just to avoid confusion.

Il giorno mar 2 mar 2021 alle ore 15:19 <ff...@apache.org> ha scritto:

> This is an automated email from the ASF dual-hosted git repository.
>
> ffang pushed a commit to branch camel-3.8.x
> in repository https://gitbox.apache.org/repos/asf/camel.git
>
>
> The following commit(s) were added to refs/heads/camel-3.8.x by this push:
>      new 7ef2913  [CAMEL-16063]don't start camel context if event is from
> the self management ApplicationContext
> 7ef2913 is described below
>
> commit 7ef2913089f6f5307ad2d75092f0e54421892928
> Author: Freeman Fang <fr...@gmail.com>
> AuthorDate: Tue Mar 2 09:18:52 2021 -0500
>
>     [CAMEL-16063]don't start camel context if event is from the self
> management ApplicationContext
> ---
>  .../java/org/apache/camel/spring/CamelContextFactoryBean.java     | 8
> ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git
> a/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> b/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> index e91072e..43f4529 100644
> ---
> a/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> +++
> b/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> @@ -462,6 +462,14 @@ public class CamelContextFactoryBean extends
> AbstractCamelContextFactoryBean<Spr
>          // being started/refreshed, there could be a race condition with
>          // other ApplicationListeners that react to
>          // ContextRefreshedEvent but this is the best that we can do
> +        if (event.getSource() instanceof ApplicationContext) {
> +            ApplicationContext appCtx = (ApplicationContext)
> event.getSource();
> +            if (appCtx.getId().equals("application:management")) {
> +                //don't start camel context if
> +                //event is from the self management ApplicationContext
> +                return;
> +            }
> +        }
>          start();
>      }
>
>
>

Re: [camel] branch camel-3.8.x updated: [CAMEL-16063]don't start camel context if event is from the self management ApplicationContext

Posted by Freeman Fang <fr...@gmail.com>.
Got it, thanks for the clarification!
Freeman

On Tue, Mar 2, 2021 at 9:25 AM Andrea Cosentino <an...@gmail.com> wrote:

> This is not needed, 3.8.x won't be released anymore, it's not an LTS. No
> need to revert, but just to avoid confusion.
>
> Il giorno mar 2 mar 2021 alle ore 15:19 <ff...@apache.org> ha scritto:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ffang pushed a commit to branch camel-3.8.x
> > in repository https://gitbox.apache.org/repos/asf/camel.git
> >
> >
> > The following commit(s) were added to refs/heads/camel-3.8.x by this
> push:
> >      new 7ef2913  [CAMEL-16063]don't start camel context if event is from
> > the self management ApplicationContext
> > 7ef2913 is described below
> >
> > commit 7ef2913089f6f5307ad2d75092f0e54421892928
> > Author: Freeman Fang <fr...@gmail.com>
> > AuthorDate: Tue Mar 2 09:18:52 2021 -0500
> >
> >     [CAMEL-16063]don't start camel context if event is from the self
> > management ApplicationContext
> > ---
> >  .../java/org/apache/camel/spring/CamelContextFactoryBean.java     | 8
> > ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git
> >
> a/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> >
> b/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> > index e91072e..43f4529 100644
> > ---
> >
> a/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> > +++
> >
> b/components/camel-spring/src/main/java/org/apache/camel/spring/CamelContextFactoryBean.java
> > @@ -462,6 +462,14 @@ public class CamelContextFactoryBean extends
> > AbstractCamelContextFactoryBean<Spr
> >          // being started/refreshed, there could be a race condition with
> >          // other ApplicationListeners that react to
> >          // ContextRefreshedEvent but this is the best that we can do
> > +        if (event.getSource() instanceof ApplicationContext) {
> > +            ApplicationContext appCtx = (ApplicationContext)
> > event.getSource();
> > +            if (appCtx.getId().equals("application:management")) {
> > +                //don't start camel context if
> > +                //event is from the self management ApplicationContext
> > +                return;
> > +            }
> > +        }
> >          start();
> >      }
> >
> >
> >
>