You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org> on 2006/05/09 12:41:41 UTC

[jira] Created: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Cannot specify additional classpath entries in manifest when using addClasspath
-------------------------------------------------------------------------------

         Key: MNG-2284
         URL: http://jira.codehaus.org/browse/MNG-2284
     Project: Maven 2
        Type: Bug

  Components: maven-archiver  
    Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4    
 Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
    Reporter: Fredrik Vraalsen
 Attachments: MNG-archiver-classpath.patch

When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41

I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2284?page=comments#action_69265 ] 

Fredrik Vraalsen commented on MNG-2284:
---------------------------------------

Hi,

I'm still having problems with this, but of a different sort now.  If I have a configuration such as the following:

	<manifest>
		<addClasspath>true</addClasspath>
	</manifest>
	<manifestEntries>
		<Class-Path>resources/</Class-Path>
	</manifestEntries>

I now get the following in my manifest.mf:

Class-Path: resources/
Class-Path: resources/

In other words, still two Class-Path entries in the manifest file, only this time they both have the value 'resources/', and the classpath created by addClasspath is gone.  This is with latest maven-jar-plugin 2.1-SNAPSHOT (maven-archiver 2.1).

I'm trying to create a JUnit test-case for maven-archiver, but I'm still trying to work out the details of how to set this up. ;-)  In the meanwhile, I'll attach a simple stand-alone pom file which shows the problem.

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

Fredrik Vraalsen updated MNG-2284:
----------------------------------

    Attachment: MNG-2284-addClasspath-and-user-specified-classpath.patch

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-2284-addClasspath-and-user-specified-classpath.patch, MNG-archiver-classpath.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

John Casey updated MNG-2284:
----------------------------

    Fix Version: 2.0.5

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]
     
Fredrik Vraalsen reopened MNG-2284:
-----------------------------------


see previous comment

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2284?page=comments#action_68046 ] 

Brett Porter commented on MNG-2284:
-----------------------------------

I think this is ok. Basically, this gives 4 scenarios:
- no classpath
- just the default (addClasspath > true)
- just the hand coded one (Class-Path in entries)
- additive default + extras (addClassPath > true & Class-Path entries)

There aren't any other fields where an additive default makes sense.

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]
     
Brett Porter closed MNG-2284:
-----------------------------

    Resolution: Fixed

applied

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Kenney Westerhof
>      Fix For: 2.0.5
>  Attachments: MNG-2284-fix-addClasspath-and-user-specified-classpath-2.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2284?page=comments#action_68044 ] 

Mike Perham commented on MNG-2284:
----------------------------------

Anyone have any comments on this?  Is it a good idea to allow people to futz with their Class-Path?  And if so, is it a good idea to hardcode the check for Class-Path in maven-archiver as the patch does?  I'm not sure how I feel about this one...

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

Kenney Westerhof updated MNG-2284:
----------------------------------

    Attachment:     (was: MNG-archiver-classpath.patch)

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Kenney Westerhof
>      Fix For: 2.0.5
>  Attachments: MNG-2284-fix-addClasspath-and-user-specified-classpath-2.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]
     
Mike Perham closed MNG-2284:
----------------------------

     Assign To: Mike Perham
    Resolution: Fixed

Patch applied with small tweaks (the user supplied value should come first so its resources can come first in the classpath and override resources in the standard jars).  maven-archiver is no longer part of Maven, proper, so the fix version is irrelevant.  It is fixed in maven-archiver 2.1 which will be part of the maven-jar-plugin 2.1 release.

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

Kenney Westerhof updated MNG-2284:
----------------------------------

    Attachment:     (was: MNG-2284-addClasspath-and-user-specified-classpath.patch)

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Kenney Westerhof
>      Fix For: 2.0.5
>  Attachments: MNG-2284-fix-addClasspath-and-user-specified-classpath-2.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

Fredrik Vraalsen updated MNG-2284:
----------------------------------

    Attachment: pom.xml

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-archiver-classpath.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MNG-2284) Cannot specify additional classpath entries in manifest when using addClasspath

Posted by "Fredrik Vraalsen (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2284?page=all ]

Fredrik Vraalsen updated MNG-2284:
----------------------------------

    Attachment: MNG-2284-fix-addClasspath-and-user-specified-classpath-2.patch

> Cannot specify additional classpath entries in manifest when using addClasspath
> -------------------------------------------------------------------------------
>
>          Key: MNG-2284
>          URL: http://jira.codehaus.org/browse/MNG-2284
>      Project: Maven 2
>         Type: Bug

>   Components: maven-archiver
>     Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
>  Environment: Maven 2.0.4, maven-jar-plugin 2.0 and 2.1-SNAPSHOT, JDK 1.5.0_06, Windows XP
>     Reporter: Fredrik Vraalsen
>     Assignee: Mike Perham
>      Fix For: 2.0.5
>  Attachments: MNG-2284-addClasspath-and-user-specified-classpath.patch, MNG-2284-fix-addClasspath-and-user-specified-classpath-2.patch, MNG-archiver-classpath.patch, pom.xml
>
>
> When using addClasspath, e.g. in the maven-jar-plugin, it is not possible to add additional classpath entries using manifestEntries, as this generates an illegal manifest file (contains two Class-Path entries).  Please see http://jira.codehaus.org/browse/MJAR-41
> I have been looking through the code, and it seems this might need to be resolved in MavenArchiver?  I've attached a simple fix that solves the problem for me, but a more thorough solution might be needed of course. ;-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira