You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/04/02 07:04:25 UTC
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/771
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/1
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java b/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
index 4eec348..71d8a5d 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
@@ -70,7 +70,9 @@
public void init() throws HyracksDataException {
try {
dirs.clear();
- LocalFileSystemUtils.traverse(files, path.toFile(), expression, dirs);
+ if (! LocalFileSystemUtils.traverse(files, path.toFile(), expression, dirs)) {
+ throw new HyracksDataException(path + ": file not found");
+ }
it = files.iterator();
if (isFeed) {
keys.clear();
@@ -87,6 +89,8 @@
}
resume();
}
+ } catch (HyracksDataException e) {
+ throw e;
} catch (IOException e) {
throw new HyracksDataException(e);
}
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java b/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
index d6e9463..d6fea4e 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
@@ -32,10 +32,10 @@
public class LocalFileSystemUtils {
//TODO: replace this method by FileUtils.iterateFilesAndDirs(.)
- public static void traverse(final LinkedList<File> files, File root, final String expression,
+ public static boolean traverse(final LinkedList<File> files, File root, final String expression,
final LinkedList<Path> dirs) throws IOException {
if (!Files.exists(root.toPath())) {
- return;
+ return false;
}
if (!Files.isDirectory(root.toPath())) {
validateAndAdd(root.toPath(), expression, files);
@@ -65,6 +65,7 @@
return FileVisitResult.CONTINUE;
}
});
+ return ! files.isEmpty();
}
public static void validateAndAdd(Path path, String expression, LinkedList<File> files) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 6:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1130/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 7: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1131/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 1: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1089/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 6: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1130/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:
Line 78: keys.clear();
I would throw an exception here if the dir list is empty.
Line 91: }
throw an exception here if the files list is empty.
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 67: });
> Clearly my intent was on fixing the issue, that I got a success message wit
Given the parameters passed to this method, I don't think enum is appropriate. Since this is a util method, I would change this method back to void and just throw an exception in case the root doesn't exists.
Let the caller checks whether the list of files or dir is empty and decide according his logic.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 38: return false;
I think this makes sense.
Line 67: });
I am not sure about this. think of the case where the user gives the path as a directory. the directory is found but is empty.
This means IMO that the adapter should return 0 records. hence, we probably don't want this to return false and throw an exception.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 8:
As we discussed, for the first issue, it makes sense for external datasets, but not for loading. Since this code is generic for all cases now, it is okay to remove the empty files exception.
As for the second issue, traverse is called inside the for loop for each path, so if one is not found, then an exception will be thrown. As we noticed, the current init method needs to be modified for feeds since resume() is called multiple times.
Please submit a fix for it and remove the exception and add me as reviewer.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 8:
I disagree with the merged version of this change. The way it should be:
If the path the user specified was not found, then we throw an exception. If the user specified a dir and the directory was found to be empty, then this is simply an empty dataset.
What do you find wrong with this clear reasoning?
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/771
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <hu...@gmail.com>
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 79 insertions(+), 14 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Jenkins: Verified
diff --git a/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql b/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
new file mode 100644
index 0000000..37a8f14
--- /dev/null
+++ b/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/**
+ * Test loading from a file that does not exist.
+ * Expected result: fail - File not found.
+ */
+
+drop dataverse broken if exists;
+create dataverse broken;
+use dataverse broken;
+
+create type xtype as closed { id: int32 };
+create dataset X(xtype) primary key id;
diff --git a/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql b/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
new file mode 100644
index 0000000..c26ffd5
--- /dev/null
+++ b/asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/**
+ * Test loading from a file that does not exist.
+ * Expected result: fail - File not found.
+ */
+
+use dataverse broken;
+
+load dataset X using localfs(
+ ("path"="asterix_nc1://bla"),
+ ("format"="delimited-text"),
+ ("delimiter"="|")
+);
diff --git a/asterix-app/src/test/resources/runtimets/testsuite.xml b/asterix-app/src/test/resources/runtimets/testsuite.xml
index e4e12f3..0ce4103 100644
--- a/asterix-app/src/test/resources/runtimets/testsuite.xml
+++ b/asterix-app/src/test/resources/runtimets/testsuite.xml
@@ -6343,6 +6343,12 @@
<!-- <expected-error>org.apache.hyracks.api.exceptions.HyracksException</expected-error> -->
</compilation-unit>
</test-case>
+ <test-case FilePath="load">
+ <compilation-unit name="file-not-found">
+ <output-dir compare="Text">none</output-dir>
+ <expected-error>org.apache.hyracks.api.exceptions.HyracksDataException: bla: path not found</expected-error>
+ </compilation-unit>
+ </test-case>
<test-case FilePath="user-defined-functions">
<compilation-unit name="query-issue244">
<output-dir compare="Text">query-issue244</output-dir>
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java b/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
index 2519177..3c3b8fb 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
@@ -38,7 +38,7 @@
private byte lastByte;
private File currentFile;
- public LocalFSInputStream(FileSystemWatcher watcher) throws IOException {
+ public LocalFSInputStream(FileSystemWatcher watcher) {
this.watcher = watcher;
}
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java b/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
index 712ffbe..ae012f3 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
@@ -19,7 +19,6 @@
package org.apache.asterix.external.input.stream.factory;
import java.io.File;
-import java.io.IOException;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.Map;
@@ -72,11 +71,7 @@
}
watcher = new FileSystemWatcher(inputResources, expression, isFeed);
}
- try {
- return new LocalFSInputStream(watcher);
- } catch (IOException e) {
- throw new HyracksDataException(e);
- }
+ return new LocalFSInputStream(watcher);
}
@Override
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java b/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
index b15d097..ea5cc8f 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
@@ -93,6 +93,10 @@
register(dirPath);
}
resume();
+ } else {
+ if (files.isEmpty()) {
+ throw new HyracksDataException(path + ": no files found");
+ }
}
}
} catch (IOException e) {
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java b/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
index d6e9463..16dd1e9 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
@@ -29,19 +29,20 @@
import java.util.LinkedList;
import java.util.regex.Pattern;
+import org.apache.hyracks.api.exceptions.HyracksDataException;
+
public class LocalFileSystemUtils {
- //TODO: replace this method by FileUtils.iterateFilesAndDirs(.)
public static void traverse(final LinkedList<File> files, File root, final String expression,
final LinkedList<Path> dirs) throws IOException {
- if (!Files.exists(root.toPath())) {
- return;
+ final Path path = root.toPath();
+ if (!Files.exists(path)) {
+ throw new HyracksDataException(path + ": path not found");
}
- if (!Files.isDirectory(root.toPath())) {
- validateAndAdd(root.toPath(), expression, files);
+ if (!Files.isDirectory(path)) {
+ validateAndAdd(path, expression, files);
}
- //FileUtils.iterateFilesAndDirs(directory, fileFilter, dirFilter)
- Files.walkFileTree(root.toPath(), new SimpleFileVisitor<Path>() {
+ Files.walkFileTree(path, new SimpleFileVisitor<Path>() {
@Override
public FileVisitResult preVisitDirectory(Path path, BasicFileAttributes attrs) throws IOException {
if (!Files.exists(path, LinkOption.NOFOLLOW_LINKS)) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 67: });
> I think there should be a distinction between the case where passing a dire
but still with non-feed localfs, we accept dirs and not just files
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 4:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1128/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 5: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1129/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#5).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 84 insertions(+), 15 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1093/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 7:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1131/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:
Line 92: } catch (HyracksDataException e) {
This catch is not needed.
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 67: });
> I am not sure about this. think of the case where the user gives the path a
I think there should be a distinction between the case where passing a directory with no files is accepted (feed), and when it is not. Using localfs is a very common use case. It is worth getting its error messages as specific as possible.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#2).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
5 files changed, 16 insertions(+), 9 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1093/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#6).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 82 insertions(+), 14 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 2: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1091/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#4).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 88 insertions(+), 20 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1091/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#3).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 75 insertions(+), 9 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 8:
With the current implementation, a few things can go wrong IMO:
1. if a user specified a directory path and the path was found to be empty, we throw an exception. I don't think that is the correct behavior.
What I would expect:
If the directory is found, then regardless of whether it contains files or not, this should not throw an exception.
2. if a user specified a set of paths in a single NC, The first path was found to have at least one file, even if we don't find the other paths at all, no exception is thrown.
What I would expect:
If any of the passed paths doesn't exist, we throw an exception.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 67: });
> but still with non-feed localfs, we accept dirs and not just files
yeah, it depends on whether we want to consider non-feed with directories and no files as an exception or no records. I think it is better to make it an exception to avoid issues like (I loaded the dataset with success message and got no records). Besides, it will eliminate possible NPE in the future :)
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 4: Verified-1
Build Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1128/ : ABORTED
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 5:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1129/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:
Line 91: }
> throw an exception here if the files list is empty.
P.S. which should be in an else block.
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1089/
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1356: report file not found
......................................................................
Patch Set 3:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:
Line 92: } catch (HyracksDataException e) {
> This catch is not needed.
True. I put it there to avoid yet another layering of exceptions. But I agree that this is not relevant for this change ...
https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java:
Line 67: });
> yeah, it depends on whether we want to consider non-feed with directories a
Clearly my intent was on fixing the issue, that I got a success message with no results. But I also see that this might not be right for feeds. That's why I just returned if we have results or not from this method and leave the decision whether that's a problem to the caller.
I think the questions here are
* if it's good enough to have 2 outcomes or if we need 3 outcomes (files found, files not found, dir doesn't exist) and
* how we report the outcomes if we need 3 (enum vs exception?).
Thoughts?
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/771
to look at the new patch set (#7).
Change subject: ASTERIXDB-1356: report file not found
......................................................................
ASTERIXDB-1356: report file not found
Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
---
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.1.ddl.aql
A asterix-app/src/test/resources/runtimets/queries/load/file-not-found/file-not-found.2.update.aql
M asterix-app/src/test/resources/runtimets/testsuite.xml
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
M asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
M asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java
7 files changed, 79 insertions(+), 14 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/71/771/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>