You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Íñigo Goiri (JIRA)" <ji...@apache.org> on 2019/06/26 18:18:00 UTC
[jira] [Commented] (HDFS-14599) HDFS-12487 breaks test
TestDiskBalancer.testDiskBalancerWithFedClusterWithOneNameServiceEmpty
[ https://issues.apache.org/jira/browse/HDFS-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873576#comment-16873576 ]
Íñigo Goiri commented on HDFS-14599:
------------------------------------
As we are doing this, I would try to improve the debuggability of this.
Something like:
{code}
String logOut = logCapturer.getOutput();
Assert.assertTrue("Wrong log: " + logOut,
logOut.contains("NextBlock call returned null. No valid block to copy."));
{code}
> HDFS-12487 breaks test TestDiskBalancer.testDiskBalancerWithFedClusterWithOneNameServiceEmpty
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-14599
> URL: https://issues.apache.org/jira/browse/HDFS-14599
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Affects Versions: 3.3.0, 3.2.1, 3.1.3
> Reporter: Wei-Chiu Chuang
> Assignee: He Xiaoqiao
> Priority: Major
> Labels: newbie
> Attachments: HDFS-14599.001.patch
>
>
> It looks like HDFS-12487 changes the error message expected by {{TestDiskBalancer#testDiskBalancerWithFedClusterWithOneNameServiceEmpty}}.
> The test expects error "There are no blocks in the blockPool" but after HDFS-12487, it returns error string "NextBlock call returned null.No valid block to copy."
> Probably the simplest approach to fix it is to update the expected error string.
> Thoughts? [~bharatviswa] you crafted the test in HDFS-13715. Should we update the expected error string, or revert HDFS-12487?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org