You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/25 17:17:08 UTC
[GitHub] [openwhisk] rabbah opened a new issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
rabbah opened a new issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985
The annotation value `require-whisk-auth: false` on a web action leads the controller to reject the web action invocation.
1. The openwhisk documentation does not say what should happen when the value is false. I don't know why this case is omitted case https://github.com/apache/openwhisk/blob/master/docs/webactions.md#securing-web-actions
2. The implementation treats this case as "not allowed, something is not right" see line 790 in this snippet
https://github.com/apache/openwhisk/blob/d9e908cce62c2d6e9f34e0295c53736be496c195/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala#L777-L790
The controller should handle the case of the annotation being set to boolean `false` as not requiring authentication rather than reject the call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah commented on issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985#issuecomment-703121803
@nitikagarw looks right - also will need a test.
Thank you for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] nitikagarw commented on issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
Posted by GitBox <gi...@apache.org>.
nitikagarw commented on issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985#issuecomment-703106293
@rabbah @style95 I think this task just requires one more case to be added
```
case JsFalse | JsBoolean(false) => true
```
If so, Can I please pick this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
Posted by GitBox <gi...@apache.org>.
style95 commented on issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985#issuecomment-699930865
So this is the case where `require-whisk-auth` annotation is specified but the value is `false`.
I think it has not been noticed because if the annotation does not exist, it passes the authentication.
So anyone who does not require any authentication, they just skip configuring the annotation rather than set it explicitly.
But it looks clearly a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah closed issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
Posted by GitBox <gi...@apache.org>.
rabbah closed issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah commented on issue #4985: actions with require-whisk-auth annotation as boolean false are rejected by controller
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4985:
URL: https://github.com/apache/openwhisk/issues/4985#issuecomment-707176557
Thanks @nitikagarw for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org