You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by GitBox <gi...@apache.org> on 2019/01/17 15:51:38 UTC

[GitHub] franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726229
 
 

 ##########
 File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
 ##########
 @@ -974,6 +974,7 @@ public void run() {
             } catch (Throwable e) {
                result.fail(e);
                logger.error("appendDeleteRecord:" + e, e);
+               setErrorCondition(callback, null, e);
 
 Review comment:
   It is handled like this on the other append calls, let me find one...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services