You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mxnet.apache.org by Anirudh <an...@gmail.com> on 2018/06/19 01:52:21 UTC
[VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Hi,
This is the vote to release Apache MXNet (incubating) version 1.2.1. Voting
will start now and close Thursday June 21st 7:00 PM PDT.
Link to release candidate 1.2.1.rc0:
https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
View this page for installation instructions:
https://mxnet.incubator.apache.org/install/index.html
(Note: The README.md points to the 1.2.1 tag and does not work at the
moment).
Please remember to test first before voting accordingly.
+1 = approve
+0 = no opinion
-1 = disapprove (provide reason)
Anirudh
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Sergio Fernández <wi...@apache.org>.
Well, in the end, I guess, such issues can be always corrected with better
documentation.
On Mon, Jun 25, 2018, 18:29 Anirudh <an...@gmail.com> wrote:
> Hi,
>
> 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
> It does not adhere exactly with semver but it had to be made, to quickly
> help our customers who were using the APIs incorrectly.
>
> Anirudh
>
> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com> wrote:
>
> > save_parameters didn't exist in 1.2.0 so its addition usually isn't
> > supposed to happen in a patch release if we stick to semantic
> versioning. I
> > couldn't find a discussion on this exception. Did it happen?
> >
> > Would people who used 1.2.0 to save models be able to load parameters in
> > 1.2.1 using the reverted load_params? (i.e. is it backward compatible)
> >
> > -sz
> >
> >
> > On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com> wrote:
> >
> > > Hi Mu,
> > >
> > > The warining currently printed is "save_params is deprecated. Please
> use
> > > save_parameters."
> > > Isn't this similar to what you are suggesting ?
> > >
> > > Anirudh
> > >
> > > On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
> > >
> > > > v1.2.1 will print a deprecating warning message when calling
> > > > save_params. We should tell users clearly to replace "save_params"
> with
> > > > "save_parameters" or something else.
> > > >
> > > > On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
> > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > This is the vote to release Apache MXNet (incubating) version
> 1.2.1.
> > > > Voting
> > > > > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > >
> > > > > Link to release candidate 1.2.1.rc0:
> > > > >
> > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > >
> > > > > View this page for installation instructions:
> > > > >
> > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > >
> > > > > (Note: The README.md points to the 1.2.1 tag and does not work at
> the
> > > > > moment).
> > > > >
> > > > > Please remember to test first before voting accordingly.
> > > > >
> > > > > +1 = approve
> > > > > +0 = no opinion
> > > > > -1 = disapprove (provide reason)
> > > > >
> > > > > Anirudh
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi,
I have opened a PR for adding new content to 1.2.1 release notes:
https://github.com/apache/incubator-mxnet/pull/11478
Please help review. Once this PR is approved I will be cutting the release.
Thanks,
Anirudh
On Tue, Jun 26, 2018 at 7:10 PM, Chris Olivier <cj...@gmail.com>
wrote:
> +1
>
> On Tue, Jun 26, 2018 at 5:50 PM Anirudh <an...@gmail.com> wrote:
>
> > Hi all,
> >
> > The current warning message for save_params: "save_params is deprecated,
> > use save_parameters instead" is misleading
> > for users who may use the API to load into SymbolBlock. To make it
> clearer
> > for all users, a better warning message is to include alternative to
> > save_params and reference to detailed documentation.
> > The message improvement is important, but not blocking to move forward to
> > complete the voting process for MXNet v1.2.1 patch release.
> > We plan to follow up with a 1.2.2 patch release to improve the message
> and
> > potentially include other bug fixes.
> > Please let me know if you have any thoughts, questions or suggestions.
> >
> >
> > Anirudh
> >
> > On Mon, Jun 25, 2018 at 10:44 PM, Anirudh <an...@gmail.com> wrote:
> >
> > >
> > > Hi Mu,
> > >
> > > Thanks for bringing this up and hopefully this should answer Sheng's
> > > question.
> > > Thomas pointed out something similar in the PR here for the warning
> > > message which I didn't notice back then:
> > > https://github.com/apache/incubator-mxnet/pull/11127
> > >
> > > Not sure about the reasoning to not add it and if there was an offline
> > > discussion about this between Thomas and Erik.
> > > It would be nice if you guys could pitch in if there were any strong
> > > reasons.
> > >
> > > I understand that a more informed warning when using save_params would
> > > really avoid some customer frustration.
> > > Having said that, I am a little worried about the timeline though since
> > > some customers are eagerly waiting for the release of 1.2.1.
> > > Another RC would delay it by at-least one and a half weeks.
> > >
> > > Anirudh
> > >
> > > On Mon, Jun 25, 2018 at 9:54 PM, Mu Li <mu...@gmail.com> wrote:
> > >
> > >> Detailed documents should help, but the current warning message that
> > >> "save_params is deprecated, use save_parameters instead" is not
> > sufficient
> > >> enough.
> > >>
> > >> Some details about the API changes:
> > >>
> > >> 1. v1.2 changed the implementation of "save_params", which is
> explained
> > in
> > >> the release note. The main benefit for this change is that we don't
> need
> > >> to
> > >> create layers within a name scope. [1]
> > >> 2. we found this change breaks a gluon-to-symbol usage, even though we
> > >> recommended users to use "export" for this usage. [2]
> > >> 3. for some good reasons we made a decision to revert save_params in
> > >> v1.2.1, and introduced a new API called save_parameters for this new
> > >> behavior. [3]
> > >>
> > >> Since calling save_params each time will generate a warning message,
> > it's
> > >> a
> > >> major API change. The recommended for users to update their codes are:
> > >>
> > >> 1. If you save parameters to load back into a SymbolBlock, you can use
> > >> export instead, though keeping it will not break your codes except
> for a
> > >> warning message. (But it will break in v1.2)
> > >> 2. If you create gluon layers without a name scope, you must replace
> > >> save_params with save_parameters. Otherwise, your model cannot be
> loaded
> > >> back in v1.2.1 (though it works in v1.2)
> > >> 3. For the rest case, such as models are created within a name scope,
> > and
> > >> the models are loaded into gluon (not symbolblock) later, recommend
> > >> replacing save_params with save_parameteres. If you don't do it,
> nothing
> > >> will break in v1.2 and v1.2.1, but v1.2.1 will give you a warning
> > message.
> > >>
> > >> This API changes in v1.2 and v1.2.1 are pretty tricky. Anirudh did a
> > great
> > >> job in capturing them in release notes. But I feel it's hard for users
> > to
> > >> understand the impacts. I suggest to improve the warning message to
> "use
> > >> export if you want to load into SymbolBlock, otherwise use
> > >> save_parameters.
> > >> For more details, refer to this URL".
> > >>
> > >> [1] https://github.com/apache/incubator-mxnet/releases/tag/1.2.0
> > >> [2] https://github.com/apache/incubator-mxnet/issues/11091
> > >> [3] https://github.com/apache/incubator-mxnet/pull/11127
> > >>
> > >> On Mon, Jun 25, 2018 at 9:23 PM, Sheng Zha <sz...@gmail.com>
> wrote:
> > >>
> > >> > Wouldn’t this break users who are on 1.2.0 and used our API
> correctly?
> > >> Why
> > >> > do we have to revert load_params, given that it’s backward
> compatible?
> > >> >
> > >> > -sz
> > >> >
> > >> > > On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com>
> wrote:
> > >> > >
> > >> > > Hi,
> > >> > >
> > >> > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with
> > 1.2.0.
> > >> > > It does not adhere exactly with semver but it had to be made, to
> > >> quickly
> > >> > > help our customers who were using the APIs incorrectly.
> > >> > >
> > >> > > Anirudh
> > >> > >
> > >> > >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com>
> > >> wrote:
> > >> > >>
> > >> > >> save_parameters didn't exist in 1.2.0 so its addition usually
> isn't
> > >> > >> supposed to happen in a patch release if we stick to semantic
> > >> > versioning. I
> > >> > >> couldn't find a discussion on this exception. Did it happen?
> > >> > >>
> > >> > >> Would people who used 1.2.0 to save models be able to load
> > >> parameters in
> > >> > >> 1.2.1 using the reverted load_params? (i.e. is it backward
> > >> compatible)
> > >> > >>
> > >> > >> -sz
> > >> > >>
> > >> > >>
> > >> > >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <anirudh2290@gmail.com
> >
> > >> > wrote:
> > >> > >>>
> > >> > >>> Hi Mu,
> > >> > >>>
> > >> > >>> The warining currently printed is "save_params is deprecated.
> > Please
> > >> > use
> > >> > >>> save_parameters."
> > >> > >>> Isn't this similar to what you are suggesting ?
> > >> > >>>
> > >> > >>> Anirudh
> > >> > >>>
> > >> > >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com>
> > wrote:
> > >> > >>>>
> > >> > >>>> v1.2.1 will print a deprecating warning message when calling
> > >> > >>>> save_params. We should tell users clearly to replace
> > "save_params"
> > >> > with
> > >> > >>>> "save_parameters" or something else.
> > >> > >>>>
> > >> > >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <
> anirudh2290@gmail.com>
> > >> > >> wrote:
> > >> > >>>>
> > >> > >>>>> Hi,
> > >> > >>>>>
> > >> > >>>>> This is the vote to release Apache MXNet (incubating) version
> > >> 1.2.1.
> > >> > >>>> Voting
> > >> > >>>>> will start now and close Thursday June 21st 7:00 PM PDT.
> > >> > >>>>>
> > >> > >>>>> Link to release candidate 1.2.1.rc0:
> > >> > >>>>>
> > >> > >>>>>
> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > >> > >>>>>
> > >> > >>>>> View this page for installation instructions:
> > >> > >>>>>
> > >> > >>>>> https://mxnet.incubator.apache.org/install/index.html
> > >> > >>>>>
> > >> > >>>>> (Note: The README.md points to the 1.2.1 tag and does not work
> > at
> > >> the
> > >> > >>>>> moment).
> > >> > >>>>>
> > >> > >>>>> Please remember to test first before voting accordingly.
> > >> > >>>>>
> > >> > >>>>> +1 = approve
> > >> > >>>>> +0 = no opinion
> > >> > >>>>> -1 = disapprove (provide reason)
> > >> > >>>>>
> > >> > >>>>> Anirudh
> > >> > >>>>>
> > >> > >>>>
> > >> > >>>
> > >> > >>
> > >> >
> > >>
> > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Chris Olivier <cj...@gmail.com>.
+1
On Tue, Jun 26, 2018 at 5:50 PM Anirudh <an...@gmail.com> wrote:
> Hi all,
>
> The current warning message for save_params: "save_params is deprecated,
> use save_parameters instead" is misleading
> for users who may use the API to load into SymbolBlock. To make it clearer
> for all users, a better warning message is to include alternative to
> save_params and reference to detailed documentation.
> The message improvement is important, but not blocking to move forward to
> complete the voting process for MXNet v1.2.1 patch release.
> We plan to follow up with a 1.2.2 patch release to improve the message and
> potentially include other bug fixes.
> Please let me know if you have any thoughts, questions or suggestions.
>
>
> Anirudh
>
> On Mon, Jun 25, 2018 at 10:44 PM, Anirudh <an...@gmail.com> wrote:
>
> >
> > Hi Mu,
> >
> > Thanks for bringing this up and hopefully this should answer Sheng's
> > question.
> > Thomas pointed out something similar in the PR here for the warning
> > message which I didn't notice back then:
> > https://github.com/apache/incubator-mxnet/pull/11127
> >
> > Not sure about the reasoning to not add it and if there was an offline
> > discussion about this between Thomas and Erik.
> > It would be nice if you guys could pitch in if there were any strong
> > reasons.
> >
> > I understand that a more informed warning when using save_params would
> > really avoid some customer frustration.
> > Having said that, I am a little worried about the timeline though since
> > some customers are eagerly waiting for the release of 1.2.1.
> > Another RC would delay it by at-least one and a half weeks.
> >
> > Anirudh
> >
> > On Mon, Jun 25, 2018 at 9:54 PM, Mu Li <mu...@gmail.com> wrote:
> >
> >> Detailed documents should help, but the current warning message that
> >> "save_params is deprecated, use save_parameters instead" is not
> sufficient
> >> enough.
> >>
> >> Some details about the API changes:
> >>
> >> 1. v1.2 changed the implementation of "save_params", which is explained
> in
> >> the release note. The main benefit for this change is that we don't need
> >> to
> >> create layers within a name scope. [1]
> >> 2. we found this change breaks a gluon-to-symbol usage, even though we
> >> recommended users to use "export" for this usage. [2]
> >> 3. for some good reasons we made a decision to revert save_params in
> >> v1.2.1, and introduced a new API called save_parameters for this new
> >> behavior. [3]
> >>
> >> Since calling save_params each time will generate a warning message,
> it's
> >> a
> >> major API change. The recommended for users to update their codes are:
> >>
> >> 1. If you save parameters to load back into a SymbolBlock, you can use
> >> export instead, though keeping it will not break your codes except for a
> >> warning message. (But it will break in v1.2)
> >> 2. If you create gluon layers without a name scope, you must replace
> >> save_params with save_parameters. Otherwise, your model cannot be loaded
> >> back in v1.2.1 (though it works in v1.2)
> >> 3. For the rest case, such as models are created within a name scope,
> and
> >> the models are loaded into gluon (not symbolblock) later, recommend
> >> replacing save_params with save_parameteres. If you don't do it, nothing
> >> will break in v1.2 and v1.2.1, but v1.2.1 will give you a warning
> message.
> >>
> >> This API changes in v1.2 and v1.2.1 are pretty tricky. Anirudh did a
> great
> >> job in capturing them in release notes. But I feel it's hard for users
> to
> >> understand the impacts. I suggest to improve the warning message to "use
> >> export if you want to load into SymbolBlock, otherwise use
> >> save_parameters.
> >> For more details, refer to this URL".
> >>
> >> [1] https://github.com/apache/incubator-mxnet/releases/tag/1.2.0
> >> [2] https://github.com/apache/incubator-mxnet/issues/11091
> >> [3] https://github.com/apache/incubator-mxnet/pull/11127
> >>
> >> On Mon, Jun 25, 2018 at 9:23 PM, Sheng Zha <sz...@gmail.com> wrote:
> >>
> >> > Wouldn’t this break users who are on 1.2.0 and used our API correctly?
> >> Why
> >> > do we have to revert load_params, given that it’s backward compatible?
> >> >
> >> > -sz
> >> >
> >> > > On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com> wrote:
> >> > >
> >> > > Hi,
> >> > >
> >> > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with
> 1.2.0.
> >> > > It does not adhere exactly with semver but it had to be made, to
> >> quickly
> >> > > help our customers who were using the APIs incorrectly.
> >> > >
> >> > > Anirudh
> >> > >
> >> > >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com>
> >> wrote:
> >> > >>
> >> > >> save_parameters didn't exist in 1.2.0 so its addition usually isn't
> >> > >> supposed to happen in a patch release if we stick to semantic
> >> > versioning. I
> >> > >> couldn't find a discussion on this exception. Did it happen?
> >> > >>
> >> > >> Would people who used 1.2.0 to save models be able to load
> >> parameters in
> >> > >> 1.2.1 using the reverted load_params? (i.e. is it backward
> >> compatible)
> >> > >>
> >> > >> -sz
> >> > >>
> >> > >>
> >> > >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com>
> >> > wrote:
> >> > >>>
> >> > >>> Hi Mu,
> >> > >>>
> >> > >>> The warining currently printed is "save_params is deprecated.
> Please
> >> > use
> >> > >>> save_parameters."
> >> > >>> Isn't this similar to what you are suggesting ?
> >> > >>>
> >> > >>> Anirudh
> >> > >>>
> >> > >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com>
> wrote:
> >> > >>>>
> >> > >>>> v1.2.1 will print a deprecating warning message when calling
> >> > >>>> save_params. We should tell users clearly to replace
> "save_params"
> >> > with
> >> > >>>> "save_parameters" or something else.
> >> > >>>>
> >> > >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
> >> > >> wrote:
> >> > >>>>
> >> > >>>>> Hi,
> >> > >>>>>
> >> > >>>>> This is the vote to release Apache MXNet (incubating) version
> >> 1.2.1.
> >> > >>>> Voting
> >> > >>>>> will start now and close Thursday June 21st 7:00 PM PDT.
> >> > >>>>>
> >> > >>>>> Link to release candidate 1.2.1.rc0:
> >> > >>>>>
> >> > >>>>>
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> >> > >>>>>
> >> > >>>>> View this page for installation instructions:
> >> > >>>>>
> >> > >>>>> https://mxnet.incubator.apache.org/install/index.html
> >> > >>>>>
> >> > >>>>> (Note: The README.md points to the 1.2.1 tag and does not work
> at
> >> the
> >> > >>>>> moment).
> >> > >>>>>
> >> > >>>>> Please remember to test first before voting accordingly.
> >> > >>>>>
> >> > >>>>> +1 = approve
> >> > >>>>> +0 = no opinion
> >> > >>>>> -1 = disapprove (provide reason)
> >> > >>>>>
> >> > >>>>> Anirudh
> >> > >>>>>
> >> > >>>>
> >> > >>>
> >> > >>
> >> >
> >>
> >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi all,
The current warning message for save_params: "save_params is deprecated,
use save_parameters instead" is misleading
for users who may use the API to load into SymbolBlock. To make it clearer
for all users, a better warning message is to include alternative to
save_params and reference to detailed documentation.
The message improvement is important, but not blocking to move forward to
complete the voting process for MXNet v1.2.1 patch release.
We plan to follow up with a 1.2.2 patch release to improve the message and
potentially include other bug fixes.
Please let me know if you have any thoughts, questions or suggestions.
Anirudh
On Mon, Jun 25, 2018 at 10:44 PM, Anirudh <an...@gmail.com> wrote:
>
> Hi Mu,
>
> Thanks for bringing this up and hopefully this should answer Sheng's
> question.
> Thomas pointed out something similar in the PR here for the warning
> message which I didn't notice back then:
> https://github.com/apache/incubator-mxnet/pull/11127
>
> Not sure about the reasoning to not add it and if there was an offline
> discussion about this between Thomas and Erik.
> It would be nice if you guys could pitch in if there were any strong
> reasons.
>
> I understand that a more informed warning when using save_params would
> really avoid some customer frustration.
> Having said that, I am a little worried about the timeline though since
> some customers are eagerly waiting for the release of 1.2.1.
> Another RC would delay it by at-least one and a half weeks.
>
> Anirudh
>
> On Mon, Jun 25, 2018 at 9:54 PM, Mu Li <mu...@gmail.com> wrote:
>
>> Detailed documents should help, but the current warning message that
>> "save_params is deprecated, use save_parameters instead" is not sufficient
>> enough.
>>
>> Some details about the API changes:
>>
>> 1. v1.2 changed the implementation of "save_params", which is explained in
>> the release note. The main benefit for this change is that we don't need
>> to
>> create layers within a name scope. [1]
>> 2. we found this change breaks a gluon-to-symbol usage, even though we
>> recommended users to use "export" for this usage. [2]
>> 3. for some good reasons we made a decision to revert save_params in
>> v1.2.1, and introduced a new API called save_parameters for this new
>> behavior. [3]
>>
>> Since calling save_params each time will generate a warning message, it's
>> a
>> major API change. The recommended for users to update their codes are:
>>
>> 1. If you save parameters to load back into a SymbolBlock, you can use
>> export instead, though keeping it will not break your codes except for a
>> warning message. (But it will break in v1.2)
>> 2. If you create gluon layers without a name scope, you must replace
>> save_params with save_parameters. Otherwise, your model cannot be loaded
>> back in v1.2.1 (though it works in v1.2)
>> 3. For the rest case, such as models are created within a name scope, and
>> the models are loaded into gluon (not symbolblock) later, recommend
>> replacing save_params with save_parameteres. If you don't do it, nothing
>> will break in v1.2 and v1.2.1, but v1.2.1 will give you a warning message.
>>
>> This API changes in v1.2 and v1.2.1 are pretty tricky. Anirudh did a great
>> job in capturing them in release notes. But I feel it's hard for users to
>> understand the impacts. I suggest to improve the warning message to "use
>> export if you want to load into SymbolBlock, otherwise use
>> save_parameters.
>> For more details, refer to this URL".
>>
>> [1] https://github.com/apache/incubator-mxnet/releases/tag/1.2.0
>> [2] https://github.com/apache/incubator-mxnet/issues/11091
>> [3] https://github.com/apache/incubator-mxnet/pull/11127
>>
>> On Mon, Jun 25, 2018 at 9:23 PM, Sheng Zha <sz...@gmail.com> wrote:
>>
>> > Wouldn’t this break users who are on 1.2.0 and used our API correctly?
>> Why
>> > do we have to revert load_params, given that it’s backward compatible?
>> >
>> > -sz
>> >
>> > > On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com> wrote:
>> > >
>> > > Hi,
>> > >
>> > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
>> > > It does not adhere exactly with semver but it had to be made, to
>> quickly
>> > > help our customers who were using the APIs incorrectly.
>> > >
>> > > Anirudh
>> > >
>> > >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com>
>> wrote:
>> > >>
>> > >> save_parameters didn't exist in 1.2.0 so its addition usually isn't
>> > >> supposed to happen in a patch release if we stick to semantic
>> > versioning. I
>> > >> couldn't find a discussion on this exception. Did it happen?
>> > >>
>> > >> Would people who used 1.2.0 to save models be able to load
>> parameters in
>> > >> 1.2.1 using the reverted load_params? (i.e. is it backward
>> compatible)
>> > >>
>> > >> -sz
>> > >>
>> > >>
>> > >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com>
>> > wrote:
>> > >>>
>> > >>> Hi Mu,
>> > >>>
>> > >>> The warining currently printed is "save_params is deprecated. Please
>> > use
>> > >>> save_parameters."
>> > >>> Isn't this similar to what you are suggesting ?
>> > >>>
>> > >>> Anirudh
>> > >>>
>> > >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
>> > >>>>
>> > >>>> v1.2.1 will print a deprecating warning message when calling
>> > >>>> save_params. We should tell users clearly to replace "save_params"
>> > with
>> > >>>> "save_parameters" or something else.
>> > >>>>
>> > >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
>> > >> wrote:
>> > >>>>
>> > >>>>> Hi,
>> > >>>>>
>> > >>>>> This is the vote to release Apache MXNet (incubating) version
>> 1.2.1.
>> > >>>> Voting
>> > >>>>> will start now and close Thursday June 21st 7:00 PM PDT.
>> > >>>>>
>> > >>>>> Link to release candidate 1.2.1.rc0:
>> > >>>>>
>> > >>>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>> > >>>>>
>> > >>>>> View this page for installation instructions:
>> > >>>>>
>> > >>>>> https://mxnet.incubator.apache.org/install/index.html
>> > >>>>>
>> > >>>>> (Note: The README.md points to the 1.2.1 tag and does not work at
>> the
>> > >>>>> moment).
>> > >>>>>
>> > >>>>> Please remember to test first before voting accordingly.
>> > >>>>>
>> > >>>>> +1 = approve
>> > >>>>> +0 = no opinion
>> > >>>>> -1 = disapprove (provide reason)
>> > >>>>>
>> > >>>>> Anirudh
>> > >>>>>
>> > >>>>
>> > >>>
>> > >>
>> >
>>
>
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi Mu,
Thanks for bringing this up and hopefully this should answer Sheng's
question.
Thomas pointed out something similar in the PR here for the warning message
which I didn't notice back then:
https://github.com/apache/incubator-mxnet/pull/11127
Not sure about the reasoning to not add it and if there was an offline
discussion about this between Thomas and Erik.
It would be nice if you guys could pitch in if there were any strong
reasons.
I understand that a more informed warning when using save_params would
really avoid some customer frustration.
Having said that, I am a little worried about the timeline though since
some customers are eagerly waiting for the release of 1.2.1.
Another RC would delay it by at-least one and a half weeks.
Anirudh
On Mon, Jun 25, 2018 at 9:54 PM, Mu Li <mu...@gmail.com> wrote:
> Detailed documents should help, but the current warning message that
> "save_params is deprecated, use save_parameters instead" is not sufficient
> enough.
>
> Some details about the API changes:
>
> 1. v1.2 changed the implementation of "save_params", which is explained in
> the release note. The main benefit for this change is that we don't need to
> create layers within a name scope. [1]
> 2. we found this change breaks a gluon-to-symbol usage, even though we
> recommended users to use "export" for this usage. [2]
> 3. for some good reasons we made a decision to revert save_params in
> v1.2.1, and introduced a new API called save_parameters for this new
> behavior. [3]
>
> Since calling save_params each time will generate a warning message, it's a
> major API change. The recommended for users to update their codes are:
>
> 1. If you save parameters to load back into a SymbolBlock, you can use
> export instead, though keeping it will not break your codes except for a
> warning message. (But it will break in v1.2)
> 2. If you create gluon layers without a name scope, you must replace
> save_params with save_parameters. Otherwise, your model cannot be loaded
> back in v1.2.1 (though it works in v1.2)
> 3. For the rest case, such as models are created within a name scope, and
> the models are loaded into gluon (not symbolblock) later, recommend
> replacing save_params with save_parameteres. If you don't do it, nothing
> will break in v1.2 and v1.2.1, but v1.2.1 will give you a warning message.
>
> This API changes in v1.2 and v1.2.1 are pretty tricky. Anirudh did a great
> job in capturing them in release notes. But I feel it's hard for users to
> understand the impacts. I suggest to improve the warning message to "use
> export if you want to load into SymbolBlock, otherwise use save_parameters.
> For more details, refer to this URL".
>
> [1] https://github.com/apache/incubator-mxnet/releases/tag/1.2.0
> [2] https://github.com/apache/incubator-mxnet/issues/11091
> [3] https://github.com/apache/incubator-mxnet/pull/11127
>
> On Mon, Jun 25, 2018 at 9:23 PM, Sheng Zha <sz...@gmail.com> wrote:
>
> > Wouldn’t this break users who are on 1.2.0 and used our API correctly?
> Why
> > do we have to revert load_params, given that it’s backward compatible?
> >
> > -sz
> >
> > > On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
> > > It does not adhere exactly with semver but it had to be made, to
> quickly
> > > help our customers who were using the APIs incorrectly.
> > >
> > > Anirudh
> > >
> > >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com>
> wrote:
> > >>
> > >> save_parameters didn't exist in 1.2.0 so its addition usually isn't
> > >> supposed to happen in a patch release if we stick to semantic
> > versioning. I
> > >> couldn't find a discussion on this exception. Did it happen?
> > >>
> > >> Would people who used 1.2.0 to save models be able to load parameters
> in
> > >> 1.2.1 using the reverted load_params? (i.e. is it backward compatible)
> > >>
> > >> -sz
> > >>
> > >>
> > >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com>
> > wrote:
> > >>>
> > >>> Hi Mu,
> > >>>
> > >>> The warining currently printed is "save_params is deprecated. Please
> > use
> > >>> save_parameters."
> > >>> Isn't this similar to what you are suggesting ?
> > >>>
> > >>> Anirudh
> > >>>
> > >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
> > >>>>
> > >>>> v1.2.1 will print a deprecating warning message when calling
> > >>>> save_params. We should tell users clearly to replace "save_params"
> > with
> > >>>> "save_parameters" or something else.
> > >>>>
> > >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
> > >> wrote:
> > >>>>
> > >>>>> Hi,
> > >>>>>
> > >>>>> This is the vote to release Apache MXNet (incubating) version
> 1.2.1.
> > >>>> Voting
> > >>>>> will start now and close Thursday June 21st 7:00 PM PDT.
> > >>>>>
> > >>>>> Link to release candidate 1.2.1.rc0:
> > >>>>>
> > >>>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > >>>>>
> > >>>>> View this page for installation instructions:
> > >>>>>
> > >>>>> https://mxnet.incubator.apache.org/install/index.html
> > >>>>>
> > >>>>> (Note: The README.md points to the 1.2.1 tag and does not work at
> the
> > >>>>> moment).
> > >>>>>
> > >>>>> Please remember to test first before voting accordingly.
> > >>>>>
> > >>>>> +1 = approve
> > >>>>> +0 = no opinion
> > >>>>> -1 = disapprove (provide reason)
> > >>>>>
> > >>>>> Anirudh
> > >>>>>
> > >>>>
> > >>>
> > >>
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Mu Li <mu...@gmail.com>.
Detailed documents should help, but the current warning message that
"save_params is deprecated, use save_parameters instead" is not sufficient
enough.
Some details about the API changes:
1. v1.2 changed the implementation of "save_params", which is explained in
the release note. The main benefit for this change is that we don't need to
create layers within a name scope. [1]
2. we found this change breaks a gluon-to-symbol usage, even though we
recommended users to use "export" for this usage. [2]
3. for some good reasons we made a decision to revert save_params in
v1.2.1, and introduced a new API called save_parameters for this new
behavior. [3]
Since calling save_params each time will generate a warning message, it's a
major API change. The recommended for users to update their codes are:
1. If you save parameters to load back into a SymbolBlock, you can use
export instead, though keeping it will not break your codes except for a
warning message. (But it will break in v1.2)
2. If you create gluon layers without a name scope, you must replace
save_params with save_parameters. Otherwise, your model cannot be loaded
back in v1.2.1 (though it works in v1.2)
3. For the rest case, such as models are created within a name scope, and
the models are loaded into gluon (not symbolblock) later, recommend
replacing save_params with save_parameteres. If you don't do it, nothing
will break in v1.2 and v1.2.1, but v1.2.1 will give you a warning message.
This API changes in v1.2 and v1.2.1 are pretty tricky. Anirudh did a great
job in capturing them in release notes. But I feel it's hard for users to
understand the impacts. I suggest to improve the warning message to "use
export if you want to load into SymbolBlock, otherwise use save_parameters.
For more details, refer to this URL".
[1] https://github.com/apache/incubator-mxnet/releases/tag/1.2.0
[2] https://github.com/apache/incubator-mxnet/issues/11091
[3] https://github.com/apache/incubator-mxnet/pull/11127
On Mon, Jun 25, 2018 at 9:23 PM, Sheng Zha <sz...@gmail.com> wrote:
> Wouldn’t this break users who are on 1.2.0 and used our API correctly? Why
> do we have to revert load_params, given that it’s backward compatible?
>
> -sz
>
> > On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com> wrote:
> >
> > Hi,
> >
> > 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
> > It does not adhere exactly with semver but it had to be made, to quickly
> > help our customers who were using the APIs incorrectly.
> >
> > Anirudh
> >
> >> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com> wrote:
> >>
> >> save_parameters didn't exist in 1.2.0 so its addition usually isn't
> >> supposed to happen in a patch release if we stick to semantic
> versioning. I
> >> couldn't find a discussion on this exception. Did it happen?
> >>
> >> Would people who used 1.2.0 to save models be able to load parameters in
> >> 1.2.1 using the reverted load_params? (i.e. is it backward compatible)
> >>
> >> -sz
> >>
> >>
> >>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com>
> wrote:
> >>>
> >>> Hi Mu,
> >>>
> >>> The warining currently printed is "save_params is deprecated. Please
> use
> >>> save_parameters."
> >>> Isn't this similar to what you are suggesting ?
> >>>
> >>> Anirudh
> >>>
> >>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
> >>>>
> >>>> v1.2.1 will print a deprecating warning message when calling
> >>>> save_params. We should tell users clearly to replace "save_params"
> with
> >>>> "save_parameters" or something else.
> >>>>
> >>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
> >> wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> This is the vote to release Apache MXNet (incubating) version 1.2.1.
> >>>> Voting
> >>>>> will start now and close Thursday June 21st 7:00 PM PDT.
> >>>>>
> >>>>> Link to release candidate 1.2.1.rc0:
> >>>>>
> >>>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> >>>>>
> >>>>> View this page for installation instructions:
> >>>>>
> >>>>> https://mxnet.incubator.apache.org/install/index.html
> >>>>>
> >>>>> (Note: The README.md points to the 1.2.1 tag and does not work at the
> >>>>> moment).
> >>>>>
> >>>>> Please remember to test first before voting accordingly.
> >>>>>
> >>>>> +1 = approve
> >>>>> +0 = no opinion
> >>>>> -1 = disapprove (provide reason)
> >>>>>
> >>>>> Anirudh
> >>>>>
> >>>>
> >>>
> >>
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Sheng Zha <sz...@gmail.com>.
Wouldn’t this break users who are on 1.2.0 and used our API correctly? Why do we have to revert load_params, given that it’s backward compatible?
-sz
> On Jun 25, 2018, at 6:30 PM, Anirudh <an...@gmail.com> wrote:
>
> Hi,
>
> 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
> It does not adhere exactly with semver but it had to be made, to quickly
> help our customers who were using the APIs incorrectly.
>
> Anirudh
>
>> On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com> wrote:
>>
>> save_parameters didn't exist in 1.2.0 so its addition usually isn't
>> supposed to happen in a patch release if we stick to semantic versioning. I
>> couldn't find a discussion on this exception. Did it happen?
>>
>> Would people who used 1.2.0 to save models be able to load parameters in
>> 1.2.1 using the reverted load_params? (i.e. is it backward compatible)
>>
>> -sz
>>
>>
>>> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com> wrote:
>>>
>>> Hi Mu,
>>>
>>> The warining currently printed is "save_params is deprecated. Please use
>>> save_parameters."
>>> Isn't this similar to what you are suggesting ?
>>>
>>> Anirudh
>>>
>>>> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
>>>>
>>>> v1.2.1 will print a deprecating warning message when calling
>>>> save_params. We should tell users clearly to replace "save_params" with
>>>> "save_parameters" or something else.
>>>>
>>>> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> This is the vote to release Apache MXNet (incubating) version 1.2.1.
>>>> Voting
>>>>> will start now and close Thursday June 21st 7:00 PM PDT.
>>>>>
>>>>> Link to release candidate 1.2.1.rc0:
>>>>>
>>>>> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>>>>>
>>>>> View this page for installation instructions:
>>>>>
>>>>> https://mxnet.incubator.apache.org/install/index.html
>>>>>
>>>>> (Note: The README.md points to the 1.2.1 tag and does not work at the
>>>>> moment).
>>>>>
>>>>> Please remember to test first before voting accordingly.
>>>>>
>>>>> +1 = approve
>>>>> +0 = no opinion
>>>>> -1 = disapprove (provide reason)
>>>>>
>>>>> Anirudh
>>>>>
>>>>
>>>
>>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi,
1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
It does not adhere exactly with semver but it had to be made, to quickly
help our customers who were using the APIs incorrectly.
Anirudh
On Mon, Jun 25, 2018 at 5:42 PM, Sheng Zha <sz...@gmail.com> wrote:
> save_parameters didn't exist in 1.2.0 so its addition usually isn't
> supposed to happen in a patch release if we stick to semantic versioning. I
> couldn't find a discussion on this exception. Did it happen?
>
> Would people who used 1.2.0 to save models be able to load parameters in
> 1.2.1 using the reverted load_params? (i.e. is it backward compatible)
>
> -sz
>
>
> On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com> wrote:
>
> > Hi Mu,
> >
> > The warining currently printed is "save_params is deprecated. Please use
> > save_parameters."
> > Isn't this similar to what you are suggesting ?
> >
> > Anirudh
> >
> > On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
> >
> > > v1.2.1 will print a deprecating warning message when calling
> > > save_params. We should tell users clearly to replace "save_params" with
> > > "save_parameters" or something else.
> > >
> > > On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com>
> wrote:
> > >
> > > > Hi,
> > > >
> > > > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> > > Voting
> > > > will start now and close Thursday June 21st 7:00 PM PDT.
> > > >
> > > > Link to release candidate 1.2.1.rc0:
> > > >
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > >
> > > > View this page for installation instructions:
> > > >
> > > > https://mxnet.incubator.apache.org/install/index.html
> > > >
> > > > (Note: The README.md points to the 1.2.1 tag and does not work at the
> > > > moment).
> > > >
> > > > Please remember to test first before voting accordingly.
> > > >
> > > > +1 = approve
> > > > +0 = no opinion
> > > > -1 = disapprove (provide reason)
> > > >
> > > > Anirudh
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Sheng Zha <sz...@gmail.com>.
save_parameters didn't exist in 1.2.0 so its addition usually isn't
supposed to happen in a patch release if we stick to semantic versioning. I
couldn't find a discussion on this exception. Did it happen?
Would people who used 1.2.0 to save models be able to load parameters in
1.2.1 using the reverted load_params? (i.e. is it backward compatible)
-sz
On Mon, Jun 25, 2018 at 4:07 PM, Anirudh <an...@gmail.com> wrote:
> Hi Mu,
>
> The warining currently printed is "save_params is deprecated. Please use
> save_parameters."
> Isn't this similar to what you are suggesting ?
>
> Anirudh
>
> On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
>
> > v1.2.1 will print a deprecating warning message when calling
> > save_params. We should tell users clearly to replace "save_params" with
> > "save_parameters" or something else.
> >
> > On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> > Voting
> > > will start now and close Thursday June 21st 7:00 PM PDT.
> > >
> > > Link to release candidate 1.2.1.rc0:
> > >
> > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > >
> > > View this page for installation instructions:
> > >
> > > https://mxnet.incubator.apache.org/install/index.html
> > >
> > > (Note: The README.md points to the 1.2.1 tag and does not work at the
> > > moment).
> > >
> > > Please remember to test first before voting accordingly.
> > >
> > > +1 = approve
> > > +0 = no opinion
> > > -1 = disapprove (provide reason)
> > >
> > > Anirudh
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi Mu,
The warining currently printed is "save_params is deprecated. Please use
save_parameters."
Isn't this similar to what you are suggesting ?
Anirudh
On Mon, Jun 25, 2018 at 3:47 PM, Mu Li <mu...@gmail.com> wrote:
> v1.2.1 will print a deprecating warning message when calling
> save_params. We should tell users clearly to replace "save_params" with
> "save_parameters" or something else.
>
> On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com> wrote:
>
> > Hi,
> >
> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> Voting
> > will start now and close Thursday June 21st 7:00 PM PDT.
> >
> > Link to release candidate 1.2.1.rc0:
> >
> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> >
> > View this page for installation instructions:
> >
> > https://mxnet.incubator.apache.org/install/index.html
> >
> > (Note: The README.md points to the 1.2.1 tag and does not work at the
> > moment).
> >
> > Please remember to test first before voting accordingly.
> >
> > +1 = approve
> > +0 = no opinion
> > -1 = disapprove (provide reason)
> >
> > Anirudh
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Mu Li <mu...@gmail.com>.
v1.2.1 will print a deprecating warning message when calling
save_params. We should tell users clearly to replace "save_params" with
"save_parameters" or something else.
On Mon, Jun 18, 2018 at 6:52 PM, Anirudh <an...@gmail.com> wrote:
> Hi,
>
> This is the vote to release Apache MXNet (incubating) version 1.2.1. Voting
> will start now and close Thursday June 21st 7:00 PM PDT.
>
> Link to release candidate 1.2.1.rc0:
>
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>
> View this page for installation instructions:
>
> https://mxnet.incubator.apache.org/install/index.html
>
> (Note: The README.md points to the 1.2.1 tag and does not work at the
> moment).
>
> Please remember to test first before voting accordingly.
>
> +1 = approve
> +0 = no opinion
> -1 = disapprove (provide reason)
>
> Anirudh
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi all,
Please help with the testing and voting for 1.2.1 release.
Anirudh
On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
> Hi,
>
> This is the vote to release Apache MXNet (incubating) version 1.2.1.
> Voting will start now and close Thursday June 21st 7:00 PM PDT.
>
> Link to release candidate 1.2.1.rc0:
>
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>
> View this page for installation instructions:
>
> https://mxnet.incubator.apache.org/install/index.html
>
> (Note: The README.md points to the 1.2.1 tag and does not work at the
> moment).
>
> Please remember to test first before voting accordingly.
>
> +1 = approve
> +0 = no opinion
> -1 = disapprove (provide reason)
>
> Anirudh
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
I guess that's why I disable openmp for development, so given that it's a
known issue an the unit tests passed on osx I change my vote accordingly
to +1 not to block the release.
On Thu, Jun 21, 2018 at 1:52 PM Anirudh <an...@gmail.com> wrote:
> Hi Pedro,
>
> I have seen this with the DEBUG flag on, not without it.
> I opened an issue here some time back:
> https://github.com/apache/incubator-mxnet/issues/10856
>
> Anirudh
>
> On Thu, Jun 21, 2018 at 12:16 PM, Pedro Larroy <
> pedro.larroy.lists@gmail.com
> > wrote:
>
> > Got it. Sorry to bring this up, and the deja-vu :-) . Makes sense not to
> > consider this issue again as you suggested, thanks.
> >
> >
> > I compiled in OSX and run unit tests. Also run SSD detector and is
> working
> > fine.
> > Compiled in ubuntu / cpu / debug with openmp. And run unit tests. I have
> > the following failure
> > in test_gluon_data:test_multi_worker_forked_data_loader
> >
> >
> > test_gluon_data.test_image_folder_dataset ... ok
> > Test should successfully run its course of multi-process/forked data
> loader
> > without errors ... Assertion failure at kmp_runtime.cpp(6479):
> > __kmp_thread_pool == __null.
> > OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
> > OMP: Hint: Please submit a bug report with this message, compile and run
> > commands used, and machine configuration info including native compiler
> and
> > operating system versions. Faster response will be obtained by including
> > all program sources. For information on submitting this issue, please see
> > https://bugs.llvm.org/.
> > Assertion failure at kmp_runtime.cpp(6479): __kmp_thread_pool == __null.
> > OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
> > OMP: Hint: Please submit a bug report with this message, compile and run
> > commands used, and machine configuration info including native compiler
> and
> > operating system versions. Faster response will be obtained by including
> > all program sources. For information on submitting this issue, please see
> > https://bugs.llvm.org/.
> >
> >
> > Can be reproduced, anyone has seen this error before? Is this a known
> > issue?
> >
> > Pedro.
> >
> >
> >
> > On Thu, Jun 21, 2018 at 11:08 AM Anirudh <an...@gmail.com> wrote:
> >
> > > Hi Pedro,
> > >
> > > I think you raised this issue in 1.2.0 release here:
> > >
> > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > .
> > > I actually forgot about this issue during this release. Having said
> > that, I
> > > think since this works with make and the customers using cmake with
> > > USE_OPENMP=OFF should be considerably small we should not block the
> > release
> > > for this.
> > > The main reason we are doing this release is for this issue
> > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > > this
> > > change for the cmake fix would be also mean we need to pull 8 more
> > commits
> > > from dmlc-core and its considerable risk to introduce for the patch
> > > release.
> > > This would also mean cutting another rc. I think in the interest of our
> > > customers who are eagerly waiting for the patch release to fix the main
> > > issue, we should move ahead here.
> > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > release
> > > notes. I will do that now.
> > >
> > > Anirudh
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > pedro.larroy.lists@gmail.com
> > > > wrote:
> > >
> > > > I think I have fixed this before, I will check if the patch didn't
> make
> > > it
> > > > to the branch.
> > > >
> > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com>
> > > > wrote:
> > > >
> > > > > -1 I can't compile:
> > > > >
> > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&)':
> > > > > /usr/include/c++/5/thread:137: undefined reference to
> > `pthread_create'
> > > > > collect2: error: ld returned 1 exit status
> > > > > ninja: build stopped: subcommand failed.
> > > > >
> > > > >
> > > > > No LSB modules are available.
> > > > > Distributor ID: Ubuntu
> > > > > Description: Ubuntu 16.04.4 LTS
> > > > > Release: 16.04
> > > > > Codename: xenial
> > > > >
> > > > >
> > > > > My build script:
> > > > >
> > > > >
> > > > > #!/bin/bash
> > > > > set -e
> > > > > set -x
> > > > >
> > > > > renice -n 19 -p $$
> > > > >
> > > > > mkdir -p build && cd build
> > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > -DUSE_OPENCV=ON
> > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > ninja -v
> > > > >
> > > > > cd ..
> > > > > if [ ! -d mxnet_py3 ]; then
> > > > > virtualenv -p `which python3` mxnet_py3
> > > > > fi
> > > > > source mxnet_py3/bin/activate
> > > > > cd python
> > > > > pip install -e .
> > > > > cd ..
> > > > > pip install opencv-python
> > > > > pip install ipython
> > > > > pip install matplotlib
> > > > >
> > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > This is the vote to release Apache MXNet (incubating) version
> > 1.2.1.
> > > > >> Voting
> > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > >> >
> > > > >> > Link to release candidate 1.2.1.rc0:
> > > > >> >
> > > > >> >
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > >> >
> > > > >> > View this page for installation instructions:
> > > > >> >
> > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > >> >
> > > > >> > (Note: The README.md points to the 1.2.1 tag and does not work
> at
> > > the
> > > > >> > moment).
> > > > >> >
> > > > >> > Please remember to test first before voting accordingly.
> > > > >> >
> > > > >> > +1 = approve
> > > > >> > +0 = no opinion
> > > > >> > -1 = disapprove (provide reason)
> > > > >> >
> > > > >> > Anirudh
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi Pedro,
I have seen this with the DEBUG flag on, not without it.
I opened an issue here some time back:
https://github.com/apache/incubator-mxnet/issues/10856
Anirudh
On Thu, Jun 21, 2018 at 12:16 PM, Pedro Larroy <pedro.larroy.lists@gmail.com
> wrote:
> Got it. Sorry to bring this up, and the deja-vu :-) . Makes sense not to
> consider this issue again as you suggested, thanks.
>
>
> I compiled in OSX and run unit tests. Also run SSD detector and is working
> fine.
> Compiled in ubuntu / cpu / debug with openmp. And run unit tests. I have
> the following failure
> in test_gluon_data:test_multi_worker_forked_data_loader
>
>
> test_gluon_data.test_image_folder_dataset ... ok
> Test should successfully run its course of multi-process/forked data loader
> without errors ... Assertion failure at kmp_runtime.cpp(6479):
> __kmp_thread_pool == __null.
> OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
> OMP: Hint: Please submit a bug report with this message, compile and run
> commands used, and machine configuration info including native compiler and
> operating system versions. Faster response will be obtained by including
> all program sources. For information on submitting this issue, please see
> https://bugs.llvm.org/.
> Assertion failure at kmp_runtime.cpp(6479): __kmp_thread_pool == __null.
> OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
> OMP: Hint: Please submit a bug report with this message, compile and run
> commands used, and machine configuration info including native compiler and
> operating system versions. Faster response will be obtained by including
> all program sources. For information on submitting this issue, please see
> https://bugs.llvm.org/.
>
>
> Can be reproduced, anyone has seen this error before? Is this a known
> issue?
>
> Pedro.
>
>
>
> On Thu, Jun 21, 2018 at 11:08 AM Anirudh <an...@gmail.com> wrote:
>
> > Hi Pedro,
> >
> > I think you raised this issue in 1.2.0 release here:
> >
> > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > .
> > I actually forgot about this issue during this release. Having said
> that, I
> > think since this works with make and the customers using cmake with
> > USE_OPENMP=OFF should be considerably small we should not block the
> release
> > for this.
> > The main reason we are doing this release is for this issue
> > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > this
> > change for the cmake fix would be also mean we need to pull 8 more
> commits
> > from dmlc-core and its considerable risk to introduce for the patch
> > release.
> > This would also mean cutting another rc. I think in the interest of our
> > customers who are eagerly waiting for the patch release to fix the main
> > issue, we should move ahead here.
> > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> release
> > notes. I will do that now.
> >
> > Anirudh
> >
> >
> >
> > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > pedro.larroy.lists@gmail.com
> > > wrote:
> >
> > > I think I have fixed this before, I will check if the patch didn't make
> > it
> > > to the branch.
> > >
> > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > pedro.larroy.lists@gmail.com>
> > > wrote:
> > >
> > > > -1 I can't compile:
> > > >
> > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > ()>)::{lambda()#1}&)':
> > > > /usr/include/c++/5/thread:137: undefined reference to
> `pthread_create'
> > > > collect2: error: ld returned 1 exit status
> > > > ninja: build stopped: subcommand failed.
> > > >
> > > >
> > > > No LSB modules are available.
> > > > Distributor ID: Ubuntu
> > > > Description: Ubuntu 16.04.4 LTS
> > > > Release: 16.04
> > > > Codename: xenial
> > > >
> > > >
> > > > My build script:
> > > >
> > > >
> > > > #!/bin/bash
> > > > set -e
> > > > set -x
> > > >
> > > > renice -n 19 -p $$
> > > >
> > > > mkdir -p build && cd build
> > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > -DUSE_OPENCV=ON
> > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > ninja -v
> > > >
> > > > cd ..
> > > > if [ ! -d mxnet_py3 ]; then
> > > > virtualenv -p `which python3` mxnet_py3
> > > > fi
> > > > source mxnet_py3/bin/activate
> > > > cd python
> > > > pip install -e .
> > > > cd ..
> > > > pip install opencv-python
> > > > pip install ipython
> > > > pip install matplotlib
> > > >
> > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> wrote:
> > > >
> > > >> +1
> > > >>
> > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > This is the vote to release Apache MXNet (incubating) version
> 1.2.1.
> > > >> Voting
> > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > >> >
> > > >> > Link to release candidate 1.2.1.rc0:
> > > >> >
> > > >> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > >> >
> > > >> > View this page for installation instructions:
> > > >> >
> > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > >> >
> > > >> > (Note: The README.md points to the 1.2.1 tag and does not work at
> > the
> > > >> > moment).
> > > >> >
> > > >> > Please remember to test first before voting accordingly.
> > > >> >
> > > >> > +1 = approve
> > > >> > +0 = no opinion
> > > >> > -1 = disapprove (provide reason)
> > > >> >
> > > >> > Anirudh
> > > >> >
> > > >>
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
Got it. Sorry to bring this up, and the deja-vu :-) . Makes sense not to
consider this issue again as you suggested, thanks.
I compiled in OSX and run unit tests. Also run SSD detector and is working
fine.
Compiled in ubuntu / cpu / debug with openmp. And run unit tests. I have
the following failure
in test_gluon_data:test_multi_worker_forked_data_loader
test_gluon_data.test_image_folder_dataset ... ok
Test should successfully run its course of multi-process/forked data loader
without errors ... Assertion failure at kmp_runtime.cpp(6479):
__kmp_thread_pool == __null.
OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
OMP: Hint: Please submit a bug report with this message, compile and run
commands used, and machine configuration info including native compiler and
operating system versions. Faster response will be obtained by including
all program sources. For information on submitting this issue, please see
https://bugs.llvm.org/.
Assertion failure at kmp_runtime.cpp(6479): __kmp_thread_pool == __null.
OMP: Error #13: Assertion failure at kmp_runtime.cpp(6479).
OMP: Hint: Please submit a bug report with this message, compile and run
commands used, and machine configuration info including native compiler and
operating system versions. Faster response will be obtained by including
all program sources. For information on submitting this issue, please see
https://bugs.llvm.org/.
Can be reproduced, anyone has seen this error before? Is this a known
issue?
Pedro.
On Thu, Jun 21, 2018 at 11:08 AM Anirudh <an...@gmail.com> wrote:
> Hi Pedro,
>
> I think you raised this issue in 1.2.0 release here:
>
> https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> .
> I actually forgot about this issue during this release. Having said that, I
> think since this works with make and the customers using cmake with
> USE_OPENMP=OFF should be considerably small we should not block the release
> for this.
> The main reason we are doing this release is for this issue
> <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> this
> change for the cmake fix would be also mean we need to pull 8 more commits
> from dmlc-core and its considerable risk to introduce for the patch
> release.
> This would also mean cutting another rc. I think in the interest of our
> customers who are eagerly waiting for the patch release to fix the main
> issue, we should move ahead here.
> I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1 release
> notes. I will do that now.
>
> Anirudh
>
>
>
> On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> pedro.larroy.lists@gmail.com
> > wrote:
>
> > I think I have fixed this before, I will check if the patch didn't make
> it
> > to the branch.
> >
> > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > pedro.larroy.lists@gmail.com>
> > wrote:
> >
> > > -1 I can't compile:
> > >
> > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > InputSplitBase::Chunk>::Init(std::function<bool
> > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > InputSplitBase::Chunk>::Init(std::function<bool
> > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > ()>)::{lambda()#1}&)':
> > > /usr/include/c++/5/thread:137: undefined reference to `pthread_create'
> > > collect2: error: ld returned 1 exit status
> > > ninja: build stopped: subcommand failed.
> > >
> > >
> > > No LSB modules are available.
> > > Distributor ID: Ubuntu
> > > Description: Ubuntu 16.04.4 LTS
> > > Release: 16.04
> > > Codename: xenial
> > >
> > >
> > > My build script:
> > >
> > >
> > > #!/bin/bash
> > > set -e
> > > set -x
> > >
> > > renice -n 19 -p $$
> > >
> > > mkdir -p build && cd build
> > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > -DUSE_OPENCV=ON
> > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > ninja -v
> > >
> > > cd ..
> > > if [ ! -d mxnet_py3 ]; then
> > > virtualenv -p `which python3` mxnet_py3
> > > fi
> > > source mxnet_py3/bin/activate
> > > cd python
> > > pip install -e .
> > > cd ..
> > > pip install opencv-python
> > > pip install ipython
> > > pip install matplotlib
> > >
> > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com> wrote:
> > >
> > >> +1
> > >>
> > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> > >> Voting
> > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > >> >
> > >> > Link to release candidate 1.2.1.rc0:
> > >> >
> > >> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > >> >
> > >> > View this page for installation instructions:
> > >> >
> > >> > https://mxnet.incubator.apache.org/install/index.html
> > >> >
> > >> > (Note: The README.md points to the 1.2.1 tag and does not work at
> the
> > >> > moment).
> > >> >
> > >> > Please remember to test first before voting accordingly.
> > >> >
> > >> > +1 = approve
> > >> > +0 = no opinion
> > >> > -1 = disapprove (provide reason)
> > >> >
> > >> > Anirudh
> > >> >
> > >>
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi all,
Thanks a lot for checking the release. This vote has passed with:
6 +1s
Binding:
Sandeep
Haibin
Indhu
Non Binding:
Carin
Pedro
Lai
Anirudh
On Fri, Jun 22, 2018 at 8:00 AM, sandeep krishnamurthy <
sandeep.krishna98@gmail.com> wrote:
> +1
>
> Lai (https://github.com/roywei) and myself tested with Keras-MXNet for CNN
> and RNN standard use cases, things are working as expected on CPU and GPU.
>
> Best,
> Sandeep
>
> On Thu, Jun 21, 2018 at 11:06 PM Anirudh <an...@gmail.com> wrote:
>
> > Hi all,
> >
> > Thanks for checking the release. We need one more binding +1. I would
> > request committers to help out here so that we can get the vote started
> on
> > general@.
> >
> > Anirudh
> >
> > On Thu, Jun 21, 2018 at 3:06 PM, Pedro Larroy <
> > pedro.larroy.lists@gmail.com>
> > wrote:
> >
> > > I already changed my vote to +1 I don't think this a big issue, just
> a
> > > pixel difference of 1 when loading an image.
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 2:20 PM Marco de Abreu
> > > <ma...@googlemail.com.invalid> wrote:
> > >
> > > > We had 868 successful runs and no failures for that test so far,
> Pedro.
> > > >
> > > > On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com>
> > > > wrote:
> > > >
> > > > > Observed just one failure in OSX in test_imdecode:
> > > > >
> > > > >
> > > > >
> > ======================================================================
> > > > > FAIL: test_imdecode (test_image.TestImage)
> > > > >
> > ----------------------------------------------------------------------
> > > > > Traceback (most recent call last):
> > > > > File
> > > > >
> > > > >
> > > > "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> > > unittest/test_image.py",
> > > > > line 94, in test_imdecode
> > > > > assert_almost_equal(image.asnumpy(), cv_image)
> > > > > File
> > > > > "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/
> > > test_utils.py",
> > > > > line 493, in assert_almost_equal
> > > > > raise AssertionError(msg)
> > > > > AssertionError:
> > > > > Items are not equal:
> > > > > Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.
> > > > Location
> > > > > of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> > > > > a: array([[[ 0, 10, 20],
> > > > > [ 0, 11, 19],
> > > > > [ 2, 12, 19],...
> > > > > b: array([[[ 0, 10, 20],
> > > > > [ 0, 11, 19],
> > > > > [ 2, 12, 19],...
> > > > >
> > > > >
> > ----------------------------------------------------------------------
> > > > > Ran 505 tests in 2018.430s
> > > > >
> > > > >
> > > > > Is this one known?
> > > > >
> > > > > The other unit tests passed.
> > > > >
> > > > > On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <
> haibin.lin.aws@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > Built from source with CUDA on Ubuntu.
> > > > > >
> > > > > > Ran example/gluon/word_language_model/train.py
> > > > > >
> > > > > > Best,
> > > > > > Haibin
> > > > > >
> > > > > >
> > > > > > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <anirudh2290@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > > Hi Pedro,
> > > > > > >
> > > > > > > I think you raised this issue in 1.2.0 release here:
> > > > > > > https://lists.apache.org/thread.html/
> > > ddc088a21aac179144350ea97353a7
> > > > > > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > > > > > .
> > > > > > > I actually forgot about this issue during this release. Having
> > said
> > > > > > that, I
> > > > > > > think since this works with make and the customers using cmake
> > with
> > > > > > > USE_OPENMP=OFF should be considerably small we should not block
> > the
> > > > > > release
> > > > > > > for this.
> > > > > > > The main reason we are doing this release is for this issue
> > > > > > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now
> > > > pulling
> > > > > > > this
> > > > > > > change for the cmake fix would be also mean we need to pull 8
> > more
> > > > > > commits
> > > > > > > from dmlc-core and its considerable risk to introduce for the
> > patch
> > > > > > > release.
> > > > > > > This would also mean cutting another rc. I think in the
> interest
> > of
> > > > our
> > > > > > > customers who are eagerly waiting for the patch release to fix
> > the
> > > > main
> > > > > > > issue, we should move ahead here.
> > > > > > > I missed reviewing all the known issue of 1.2.0 and add it to
> > 1.2.1
> > > > > > release
> > > > > > > notes. I will do that now.
> > > > > > >
> > > > > > > Anirudh
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > > > > > pedro.larroy.lists@gmail.com
> > > > > > > > wrote:
> > > > > > >
> > > > > > > > I think I have fixed this before, I will check if the patch
> > > didn't
> > > > > make
> > > > > > > it
> > > > > > > > to the branch.
> > > > > > > >
> > > > > > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > > > > > pedro.larroy.lists@gmail.com>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > -1 I can't compile:
> > > > > > > > >
> > > > > > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > > > ()>)::{lambda()#1}&)':
> > > > > > > > > /usr/include/c++/5/thread:137: undefined reference to
> > > > > > `pthread_create'
> > > > > > > > > collect2: error: ld returned 1 exit status
> > > > > > > > > ninja: build stopped: subcommand failed.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > No LSB modules are available.
> > > > > > > > > Distributor ID: Ubuntu
> > > > > > > > > Description: Ubuntu 16.04.4 LTS
> > > > > > > > > Release: 16.04
> > > > > > > > > Codename: xenial
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > My build script:
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > #!/bin/bash
> > > > > > > > > set -e
> > > > > > > > > set -x
> > > > > > > > >
> > > > > > > > > renice -n 19 -p $$
> > > > > > > > >
> > > > > > > > > mkdir -p build && cd build
> > > > > > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > > > > > -DUSE_OPENCV=ON
> > > > > > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > > > > > ninja -v
> > > > > > > > >
> > > > > > > > > cd ..
> > > > > > > > > if [ ! -d mxnet_py3 ]; then
> > > > > > > > > virtualenv -p `which python3` mxnet_py3
> > > > > > > > > fi
> > > > > > > > > source mxnet_py3/bin/activate
> > > > > > > > > cd python
> > > > > > > > > pip install -e .
> > > > > > > > > cd ..
> > > > > > > > > pip install opencv-python
> > > > > > > > > pip install ipython
> > > > > > > > > pip install matplotlib
> > > > > > > > >
> > > > > > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <
> > indhubharathi@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > > >
> > > > > > > > >> +1
> > > > > > > > >>
> > > > > > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <
> > anirudh2290@gmail.com>
> > > > > > wrote:
> > > > > > > > >>
> > > > > > > > >> > Hi,
> > > > > > > > >> >
> > > > > > > > >> > This is the vote to release Apache MXNet (incubating)
> > > version
> > > > > > 1.2.1.
> > > > > > > > >> Voting
> > > > > > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > > > > > >> >
> > > > > > > > >> > Link to release candidate 1.2.1.rc0:
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > > > > > >> >
> > > > > > > > >> > View this page for installation instructions:
> > > > > > > > >> >
> > > > > > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > > >> >
> > > > > > > > >> > (Note: The README.md points to the 1.2.1 tag and does
> not
> > > work
> > > > > at
> > > > > > > the
> > > > > > > > >> > moment).
> > > > > > > > >> >
> > > > > > > > >> > Please remember to test first before voting accordingly.
> > > > > > > > >> >
> > > > > > > > >> > +1 = approve
> > > > > > > > >> > +0 = no opinion
> > > > > > > > >> > -1 = disapprove (provide reason)
> > > > > > > > >> >
> > > > > > > > >> > Anirudh
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> Sandeep Krishnamurthy
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by sandeep krishnamurthy <sa...@gmail.com>.
+1
Lai (https://github.com/roywei) and myself tested with Keras-MXNet for CNN
and RNN standard use cases, things are working as expected on CPU and GPU.
Best,
Sandeep
On Thu, Jun 21, 2018 at 11:06 PM Anirudh <an...@gmail.com> wrote:
> Hi all,
>
> Thanks for checking the release. We need one more binding +1. I would
> request committers to help out here so that we can get the vote started on
> general@.
>
> Anirudh
>
> On Thu, Jun 21, 2018 at 3:06 PM, Pedro Larroy <
> pedro.larroy.lists@gmail.com>
> wrote:
>
> > I already changed my vote to +1 I don't think this a big issue, just a
> > pixel difference of 1 when loading an image.
> >
> >
> >
> > On Thu, Jun 21, 2018 at 2:20 PM Marco de Abreu
> > <ma...@googlemail.com.invalid> wrote:
> >
> > > We had 868 successful runs and no failures for that test so far, Pedro.
> > >
> > > On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy <
> > > pedro.larroy.lists@gmail.com>
> > > wrote:
> > >
> > > > Observed just one failure in OSX in test_imdecode:
> > > >
> > > >
> > > >
> ======================================================================
> > > > FAIL: test_imdecode (test_image.TestImage)
> > > >
> ----------------------------------------------------------------------
> > > > Traceback (most recent call last):
> > > > File
> > > >
> > > >
> > > "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> > unittest/test_image.py",
> > > > line 94, in test_imdecode
> > > > assert_almost_equal(image.asnumpy(), cv_image)
> > > > File
> > > > "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/
> > test_utils.py",
> > > > line 493, in assert_almost_equal
> > > > raise AssertionError(msg)
> > > > AssertionError:
> > > > Items are not equal:
> > > > Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.
> > > Location
> > > > of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> > > > a: array([[[ 0, 10, 20],
> > > > [ 0, 11, 19],
> > > > [ 2, 12, 19],...
> > > > b: array([[[ 0, 10, 20],
> > > > [ 0, 11, 19],
> > > > [ 2, 12, 19],...
> > > >
> > > >
> ----------------------------------------------------------------------
> > > > Ran 505 tests in 2018.430s
> > > >
> > > >
> > > > Is this one known?
> > > >
> > > > The other unit tests passed.
> > > >
> > > > On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <haibin.lin.aws@gmail.com
> >
> > > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > Built from source with CUDA on Ubuntu.
> > > > >
> > > > > Ran example/gluon/word_language_model/train.py
> > > > >
> > > > > Best,
> > > > > Haibin
> > > > >
> > > > >
> > > > > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Hi Pedro,
> > > > > >
> > > > > > I think you raised this issue in 1.2.0 release here:
> > > > > > https://lists.apache.org/thread.html/
> > ddc088a21aac179144350ea97353a7
> > > > > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > > > > .
> > > > > > I actually forgot about this issue during this release. Having
> said
> > > > > that, I
> > > > > > think since this works with make and the customers using cmake
> with
> > > > > > USE_OPENMP=OFF should be considerably small we should not block
> the
> > > > > release
> > > > > > for this.
> > > > > > The main reason we are doing this release is for this issue
> > > > > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now
> > > pulling
> > > > > > this
> > > > > > change for the cmake fix would be also mean we need to pull 8
> more
> > > > > commits
> > > > > > from dmlc-core and its considerable risk to introduce for the
> patch
> > > > > > release.
> > > > > > This would also mean cutting another rc. I think in the interest
> of
> > > our
> > > > > > customers who are eagerly waiting for the patch release to fix
> the
> > > main
> > > > > > issue, we should move ahead here.
> > > > > > I missed reviewing all the known issue of 1.2.0 and add it to
> 1.2.1
> > > > > release
> > > > > > notes. I will do that now.
> > > > > >
> > > > > > Anirudh
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > > > > pedro.larroy.lists@gmail.com
> > > > > > > wrote:
> > > > > >
> > > > > > > I think I have fixed this before, I will check if the patch
> > didn't
> > > > make
> > > > > > it
> > > > > > > to the branch.
> > > > > > >
> > > > > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > > > > pedro.larroy.lists@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > -1 I can't compile:
> > > > > > > >
> > > > > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > > ()>)::{lambda()#1}&)':
> > > > > > > > /usr/include/c++/5/thread:137: undefined reference to
> > > > > `pthread_create'
> > > > > > > > collect2: error: ld returned 1 exit status
> > > > > > > > ninja: build stopped: subcommand failed.
> > > > > > > >
> > > > > > > >
> > > > > > > > No LSB modules are available.
> > > > > > > > Distributor ID: Ubuntu
> > > > > > > > Description: Ubuntu 16.04.4 LTS
> > > > > > > > Release: 16.04
> > > > > > > > Codename: xenial
> > > > > > > >
> > > > > > > >
> > > > > > > > My build script:
> > > > > > > >
> > > > > > > >
> > > > > > > > #!/bin/bash
> > > > > > > > set -e
> > > > > > > > set -x
> > > > > > > >
> > > > > > > > renice -n 19 -p $$
> > > > > > > >
> > > > > > > > mkdir -p build && cd build
> > > > > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > > > > -DUSE_OPENCV=ON
> > > > > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > > > > ninja -v
> > > > > > > >
> > > > > > > > cd ..
> > > > > > > > if [ ! -d mxnet_py3 ]; then
> > > > > > > > virtualenv -p `which python3` mxnet_py3
> > > > > > > > fi
> > > > > > > > source mxnet_py3/bin/activate
> > > > > > > > cd python
> > > > > > > > pip install -e .
> > > > > > > > cd ..
> > > > > > > > pip install opencv-python
> > > > > > > > pip install ipython
> > > > > > > > pip install matplotlib
> > > > > > > >
> > > > > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <
> indhubharathi@gmail.com
> > >
> > > > > wrote:
> > > > > > > >
> > > > > > > >> +1
> > > > > > > >>
> > > > > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <
> anirudh2290@gmail.com>
> > > > > wrote:
> > > > > > > >>
> > > > > > > >> > Hi,
> > > > > > > >> >
> > > > > > > >> > This is the vote to release Apache MXNet (incubating)
> > version
> > > > > 1.2.1.
> > > > > > > >> Voting
> > > > > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > > > > >> >
> > > > > > > >> > Link to release candidate 1.2.1.rc0:
> > > > > > > >> >
> > > > > > > >> >
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > > > > >> >
> > > > > > > >> > View this page for installation instructions:
> > > > > > > >> >
> > > > > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > >> >
> > > > > > > >> > (Note: The README.md points to the 1.2.1 tag and does not
> > work
> > > > at
> > > > > > the
> > > > > > > >> > moment).
> > > > > > > >> >
> > > > > > > >> > Please remember to test first before voting accordingly.
> > > > > > > >> >
> > > > > > > >> > +1 = approve
> > > > > > > >> > +0 = no opinion
> > > > > > > >> > -1 = disapprove (provide reason)
> > > > > > > >> >
> > > > > > > >> > Anirudh
> > > > > > > >> >
> > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
Sandeep Krishnamurthy
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi all,
Thanks for checking the release. We need one more binding +1. I would
request committers to help out here so that we can get the vote started on
general@.
Anirudh
On Thu, Jun 21, 2018 at 3:06 PM, Pedro Larroy <pe...@gmail.com>
wrote:
> I already changed my vote to +1 I don't think this a big issue, just a
> pixel difference of 1 when loading an image.
>
>
>
> On Thu, Jun 21, 2018 at 2:20 PM Marco de Abreu
> <ma...@googlemail.com.invalid> wrote:
>
> > We had 868 successful runs and no failures for that test so far, Pedro.
> >
> > On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy <
> > pedro.larroy.lists@gmail.com>
> > wrote:
> >
> > > Observed just one failure in OSX in test_imdecode:
> > >
> > >
> > > ======================================================================
> > > FAIL: test_imdecode (test_image.TestImage)
> > > ----------------------------------------------------------------------
> > > Traceback (most recent call last):
> > > File
> > >
> > >
> > "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> unittest/test_image.py",
> > > line 94, in test_imdecode
> > > assert_almost_equal(image.asnumpy(), cv_image)
> > > File
> > > "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/
> test_utils.py",
> > > line 493, in assert_almost_equal
> > > raise AssertionError(msg)
> > > AssertionError:
> > > Items are not equal:
> > > Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.
> > Location
> > > of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> > > a: array([[[ 0, 10, 20],
> > > [ 0, 11, 19],
> > > [ 2, 12, 19],...
> > > b: array([[[ 0, 10, 20],
> > > [ 0, 11, 19],
> > > [ 2, 12, 19],...
> > >
> > > ----------------------------------------------------------------------
> > > Ran 505 tests in 2018.430s
> > >
> > >
> > > Is this one known?
> > >
> > > The other unit tests passed.
> > >
> > > On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > >
> > > > Built from source with CUDA on Ubuntu.
> > > >
> > > > Ran example/gluon/word_language_model/train.py
> > > >
> > > > Best,
> > > > Haibin
> > > >
> > > >
> > > > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com>
> > wrote:
> > > >
> > > > > Hi Pedro,
> > > > >
> > > > > I think you raised this issue in 1.2.0 release here:
> > > > > https://lists.apache.org/thread.html/
> ddc088a21aac179144350ea97353a7
> > > > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > > > .
> > > > > I actually forgot about this issue during this release. Having said
> > > > that, I
> > > > > think since this works with make and the customers using cmake with
> > > > > USE_OPENMP=OFF should be considerably small we should not block the
> > > > release
> > > > > for this.
> > > > > The main reason we are doing this release is for this issue
> > > > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now
> > pulling
> > > > > this
> > > > > change for the cmake fix would be also mean we need to pull 8 more
> > > > commits
> > > > > from dmlc-core and its considerable risk to introduce for the patch
> > > > > release.
> > > > > This would also mean cutting another rc. I think in the interest of
> > our
> > > > > customers who are eagerly waiting for the patch release to fix the
> > main
> > > > > issue, we should move ahead here.
> > > > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > > > release
> > > > > notes. I will do that now.
> > > > >
> > > > > Anirudh
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > > > pedro.larroy.lists@gmail.com
> > > > > > wrote:
> > > > >
> > > > > > I think I have fixed this before, I will check if the patch
> didn't
> > > make
> > > > > it
> > > > > > to the branch.
> > > > > >
> > > > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > > > pedro.larroy.lists@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > -1 I can't compile:
> > > > > > >
> > > > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > > ()>)::{lambda()#1}&)':
> > > > > > > /usr/include/c++/5/thread:137: undefined reference to
> > > > `pthread_create'
> > > > > > > collect2: error: ld returned 1 exit status
> > > > > > > ninja: build stopped: subcommand failed.
> > > > > > >
> > > > > > >
> > > > > > > No LSB modules are available.
> > > > > > > Distributor ID: Ubuntu
> > > > > > > Description: Ubuntu 16.04.4 LTS
> > > > > > > Release: 16.04
> > > > > > > Codename: xenial
> > > > > > >
> > > > > > >
> > > > > > > My build script:
> > > > > > >
> > > > > > >
> > > > > > > #!/bin/bash
> > > > > > > set -e
> > > > > > > set -x
> > > > > > >
> > > > > > > renice -n 19 -p $$
> > > > > > >
> > > > > > > mkdir -p build && cd build
> > > > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > > > -DUSE_OPENCV=ON
> > > > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > > > ninja -v
> > > > > > >
> > > > > > > cd ..
> > > > > > > if [ ! -d mxnet_py3 ]; then
> > > > > > > virtualenv -p `which python3` mxnet_py3
> > > > > > > fi
> > > > > > > source mxnet_py3/bin/activate
> > > > > > > cd python
> > > > > > > pip install -e .
> > > > > > > cd ..
> > > > > > > pip install opencv-python
> > > > > > > pip install ipython
> > > > > > > pip install matplotlib
> > > > > > >
> > > > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <indhubharathi@gmail.com
> >
> > > > wrote:
> > > > > > >
> > > > > > >> +1
> > > > > > >>
> > > > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > > > wrote:
> > > > > > >>
> > > > > > >> > Hi,
> > > > > > >> >
> > > > > > >> > This is the vote to release Apache MXNet (incubating)
> version
> > > > 1.2.1.
> > > > > > >> Voting
> > > > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > > > >> >
> > > > > > >> > Link to release candidate 1.2.1.rc0:
> > > > > > >> >
> > > > > > >> >
> > > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > > > >> >
> > > > > > >> > View this page for installation instructions:
> > > > > > >> >
> > > > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > > > >> >
> > > > > > >> > (Note: The README.md points to the 1.2.1 tag and does not
> work
> > > at
> > > > > the
> > > > > > >> > moment).
> > > > > > >> >
> > > > > > >> > Please remember to test first before voting accordingly.
> > > > > > >> >
> > > > > > >> > +1 = approve
> > > > > > >> > +0 = no opinion
> > > > > > >> > -1 = disapprove (provide reason)
> > > > > > >> >
> > > > > > >> > Anirudh
> > > > > > >> >
> > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
I already changed my vote to +1 I don't think this a big issue, just a
pixel difference of 1 when loading an image.
On Thu, Jun 21, 2018 at 2:20 PM Marco de Abreu
<ma...@googlemail.com.invalid> wrote:
> We had 868 successful runs and no failures for that test so far, Pedro.
>
> On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy <
> pedro.larroy.lists@gmail.com>
> wrote:
>
> > Observed just one failure in OSX in test_imdecode:
> >
> >
> > ======================================================================
> > FAIL: test_imdecode (test_image.TestImage)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File
> >
> >
> "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/unittest/test_image.py",
> > line 94, in test_imdecode
> > assert_almost_equal(image.asnumpy(), cv_image)
> > File
> > "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
> > line 493, in assert_almost_equal
> > raise AssertionError(msg)
> > AssertionError:
> > Items are not equal:
> > Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.
> Location
> > of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> > a: array([[[ 0, 10, 20],
> > [ 0, 11, 19],
> > [ 2, 12, 19],...
> > b: array([[[ 0, 10, 20],
> > [ 0, 11, 19],
> > [ 2, 12, 19],...
> >
> > ----------------------------------------------------------------------
> > Ran 505 tests in 2018.430s
> >
> >
> > Is this one known?
> >
> > The other unit tests passed.
> >
> > On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > Built from source with CUDA on Ubuntu.
> > >
> > > Ran example/gluon/word_language_model/train.py
> > >
> > > Best,
> > > Haibin
> > >
> > >
> > > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com>
> wrote:
> > >
> > > > Hi Pedro,
> > > >
> > > > I think you raised this issue in 1.2.0 release here:
> > > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > > .
> > > > I actually forgot about this issue during this release. Having said
> > > that, I
> > > > think since this works with make and the customers using cmake with
> > > > USE_OPENMP=OFF should be considerably small we should not block the
> > > release
> > > > for this.
> > > > The main reason we are doing this release is for this issue
> > > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now
> pulling
> > > > this
> > > > change for the cmake fix would be also mean we need to pull 8 more
> > > commits
> > > > from dmlc-core and its considerable risk to introduce for the patch
> > > > release.
> > > > This would also mean cutting another rc. I think in the interest of
> our
> > > > customers who are eagerly waiting for the patch release to fix the
> main
> > > > issue, we should move ahead here.
> > > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > > release
> > > > notes. I will do that now.
> > > >
> > > > Anirudh
> > > >
> > > >
> > > >
> > > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com
> > > > > wrote:
> > > >
> > > > > I think I have fixed this before, I will check if the patch didn't
> > make
> > > > it
> > > > > to the branch.
> > > > >
> > > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > > pedro.larroy.lists@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > -1 I can't compile:
> > > > > >
> > > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > ()>)::{lambda()#1}&)':
> > > > > > /usr/include/c++/5/thread:137: undefined reference to
> > > `pthread_create'
> > > > > > collect2: error: ld returned 1 exit status
> > > > > > ninja: build stopped: subcommand failed.
> > > > > >
> > > > > >
> > > > > > No LSB modules are available.
> > > > > > Distributor ID: Ubuntu
> > > > > > Description: Ubuntu 16.04.4 LTS
> > > > > > Release: 16.04
> > > > > > Codename: xenial
> > > > > >
> > > > > >
> > > > > > My build script:
> > > > > >
> > > > > >
> > > > > > #!/bin/bash
> > > > > > set -e
> > > > > > set -x
> > > > > >
> > > > > > renice -n 19 -p $$
> > > > > >
> > > > > > mkdir -p build && cd build
> > > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > > -DUSE_OPENCV=ON
> > > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > > ninja -v
> > > > > >
> > > > > > cd ..
> > > > > > if [ ! -d mxnet_py3 ]; then
> > > > > > virtualenv -p `which python3` mxnet_py3
> > > > > > fi
> > > > > > source mxnet_py3/bin/activate
> > > > > > cd python
> > > > > > pip install -e .
> > > > > > cd ..
> > > > > > pip install opencv-python
> > > > > > pip install ipython
> > > > > > pip install matplotlib
> > > > > >
> > > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> > > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > > wrote:
> > > > > >>
> > > > > >> > Hi,
> > > > > >> >
> > > > > >> > This is the vote to release Apache MXNet (incubating) version
> > > 1.2.1.
> > > > > >> Voting
> > > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > > >> >
> > > > > >> > Link to release candidate 1.2.1.rc0:
> > > > > >> >
> > > > > >> >
> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > > >> >
> > > > > >> > View this page for installation instructions:
> > > > > >> >
> > > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > > >> >
> > > > > >> > (Note: The README.md points to the 1.2.1 tag and does not work
> > at
> > > > the
> > > > > >> > moment).
> > > > > >> >
> > > > > >> > Please remember to test first before voting accordingly.
> > > > > >> >
> > > > > >> > +1 = approve
> > > > > >> > +0 = no opinion
> > > > > >> > -1 = disapprove (provide reason)
> > > > > >> >
> > > > > >> > Anirudh
> > > > > >> >
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Marco de Abreu <ma...@googlemail.com.INVALID>.
We had 868 successful runs and no failures for that test so far, Pedro.
On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy <pe...@gmail.com>
wrote:
> Observed just one failure in OSX in test_imdecode:
>
>
> ======================================================================
> FAIL: test_imdecode (test_image.TestImage)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
>
> "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/unittest/test_image.py",
> line 94, in test_imdecode
> assert_almost_equal(image.asnumpy(), cv_image)
> File
> "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
> line 493, in assert_almost_equal
> raise AssertionError(msg)
> AssertionError:
> Items are not equal:
> Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000. Location
> of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> a: array([[[ 0, 10, 20],
> [ 0, 11, 19],
> [ 2, 12, 19],...
> b: array([[[ 0, 10, 20],
> [ 0, 11, 19],
> [ 2, 12, 19],...
>
> ----------------------------------------------------------------------
> Ran 505 tests in 2018.430s
>
>
> Is this one known?
>
> The other unit tests passed.
>
> On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com>
> wrote:
>
> > +1
> >
> > Built from source with CUDA on Ubuntu.
> >
> > Ran example/gluon/word_language_model/train.py
> >
> > Best,
> > Haibin
> >
> >
> > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com> wrote:
> >
> > > Hi Pedro,
> > >
> > > I think you raised this issue in 1.2.0 release here:
> > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > .
> > > I actually forgot about this issue during this release. Having said
> > that, I
> > > think since this works with make and the customers using cmake with
> > > USE_OPENMP=OFF should be considerably small we should not block the
> > release
> > > for this.
> > > The main reason we are doing this release is for this issue
> > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > > this
> > > change for the cmake fix would be also mean we need to pull 8 more
> > commits
> > > from dmlc-core and its considerable risk to introduce for the patch
> > > release.
> > > This would also mean cutting another rc. I think in the interest of our
> > > customers who are eagerly waiting for the patch release to fix the main
> > > issue, we should move ahead here.
> > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > release
> > > notes. I will do that now.
> > >
> > > Anirudh
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > pedro.larroy.lists@gmail.com
> > > > wrote:
> > >
> > > > I think I have fixed this before, I will check if the patch didn't
> make
> > > it
> > > > to the branch.
> > > >
> > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com>
> > > > wrote:
> > > >
> > > > > -1 I can't compile:
> > > > >
> > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&)':
> > > > > /usr/include/c++/5/thread:137: undefined reference to
> > `pthread_create'
> > > > > collect2: error: ld returned 1 exit status
> > > > > ninja: build stopped: subcommand failed.
> > > > >
> > > > >
> > > > > No LSB modules are available.
> > > > > Distributor ID: Ubuntu
> > > > > Description: Ubuntu 16.04.4 LTS
> > > > > Release: 16.04
> > > > > Codename: xenial
> > > > >
> > > > >
> > > > > My build script:
> > > > >
> > > > >
> > > > > #!/bin/bash
> > > > > set -e
> > > > > set -x
> > > > >
> > > > > renice -n 19 -p $$
> > > > >
> > > > > mkdir -p build && cd build
> > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > -DUSE_OPENCV=ON
> > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > ninja -v
> > > > >
> > > > > cd ..
> > > > > if [ ! -d mxnet_py3 ]; then
> > > > > virtualenv -p `which python3` mxnet_py3
> > > > > fi
> > > > > source mxnet_py3/bin/activate
> > > > > cd python
> > > > > pip install -e .
> > > > > cd ..
> > > > > pip install opencv-python
> > > > > pip install ipython
> > > > > pip install matplotlib
> > > > >
> > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > This is the vote to release Apache MXNet (incubating) version
> > 1.2.1.
> > > > >> Voting
> > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > >> >
> > > > >> > Link to release candidate 1.2.1.rc0:
> > > > >> >
> > > > >> >
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > > >> >
> > > > >> > View this page for installation instructions:
> > > > >> >
> > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > >> >
> > > > >> > (Note: The README.md points to the 1.2.1 tag and does not work
> at
> > > the
> > > > >> > moment).
> > > > >> >
> > > > >> > Please remember to test first before voting accordingly.
> > > > >> >
> > > > >> > +1 = approve
> > > > >> > +0 = no opinion
> > > > >> > -1 = disapprove (provide reason)
> > > > >> >
> > > > >> > Anirudh
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Carin Meier <ca...@gmail.com>.
+1 I tested the Scala jars (through the clojure package) on staging on for
the various platforms and they look good.
On Thu, Jun 21, 2018 at 5:20 PM, Anirudh <an...@gmail.com> wrote:
> That looks like a flaky test because of atol being too small. please force
> rtol and atol values and see if you are still able to reproduce.
>
> On Thu, Jun 21, 2018 at 2:16 PM, Pedro Larroy <
> pedro.larroy.lists@gmail.com>
> wrote:
>
> > Observed just one failure in OSX in test_imdecode:
> >
> >
> > ======================================================================
> > FAIL: test_imdecode (test_image.TestImage)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File
> > "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> > unittest/test_image.py",
> > line 94, in test_imdecode
> > assert_almost_equal(image.asnumpy(), cv_image)
> > File
> > "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
> > line 493, in assert_almost_equal
> > raise AssertionError(msg)
> > AssertionError:
> > Items are not equal:
> > Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000.
> Location
> > of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> > a: array([[[ 0, 10, 20],
> > [ 0, 11, 19],
> > [ 2, 12, 19],...
> > b: array([[[ 0, 10, 20],
> > [ 0, 11, 19],
> > [ 2, 12, 19],...
> >
> > ----------------------------------------------------------------------
> > Ran 505 tests in 2018.430s
> >
> >
> > Is this one known?
> >
> > The other unit tests passed.
> >
> > On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > Built from source with CUDA on Ubuntu.
> > >
> > > Ran example/gluon/word_language_model/train.py
> > >
> > > Best,
> > > Haibin
> > >
> > >
> > > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com>
> wrote:
> > >
> > > > Hi Pedro,
> > > >
> > > > I think you raised this issue in 1.2.0 release here:
> > > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > > .
> > > > I actually forgot about this issue during this release. Having said
> > > that, I
> > > > think since this works with make and the customers using cmake with
> > > > USE_OPENMP=OFF should be considerably small we should not block the
> > > release
> > > > for this.
> > > > The main reason we are doing this release is for this issue
> > > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now
> pulling
> > > > this
> > > > change for the cmake fix would be also mean we need to pull 8 more
> > > commits
> > > > from dmlc-core and its considerable risk to introduce for the patch
> > > > release.
> > > > This would also mean cutting another rc. I think in the interest of
> our
> > > > customers who are eagerly waiting for the patch release to fix the
> main
> > > > issue, we should move ahead here.
> > > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > > release
> > > > notes. I will do that now.
> > > >
> > > > Anirudh
> > > >
> > > >
> > > >
> > > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com
> > > > > wrote:
> > > >
> > > > > I think I have fixed this before, I will check if the patch didn't
> > make
> > > > it
> > > > > to the branch.
> > > > >
> > > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > > pedro.larroy.lists@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > -1 I can't compile:
> > > > > >
> > > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > > ()>)::{lambda()#1}&)':
> > > > > > /usr/include/c++/5/thread:137: undefined reference to
> > > `pthread_create'
> > > > > > collect2: error: ld returned 1 exit status
> > > > > > ninja: build stopped: subcommand failed.
> > > > > >
> > > > > >
> > > > > > No LSB modules are available.
> > > > > > Distributor ID: Ubuntu
> > > > > > Description: Ubuntu 16.04.4 LTS
> > > > > > Release: 16.04
> > > > > > Codename: xenial
> > > > > >
> > > > > >
> > > > > > My build script:
> > > > > >
> > > > > >
> > > > > > #!/bin/bash
> > > > > > set -e
> > > > > > set -x
> > > > > >
> > > > > > renice -n 19 -p $$
> > > > > >
> > > > > > mkdir -p build && cd build
> > > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > > -DUSE_OPENCV=ON
> > > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > > ninja -v
> > > > > >
> > > > > > cd ..
> > > > > > if [ ! -d mxnet_py3 ]; then
> > > > > > virtualenv -p `which python3` mxnet_py3
> > > > > > fi
> > > > > > source mxnet_py3/bin/activate
> > > > > > cd python
> > > > > > pip install -e .
> > > > > > cd ..
> > > > > > pip install opencv-python
> > > > > > pip install ipython
> > > > > > pip install matplotlib
> > > > > >
> > > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> > > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > > wrote:
> > > > > >>
> > > > > >> > Hi,
> > > > > >> >
> > > > > >> > This is the vote to release Apache MXNet (incubating) version
> > > 1.2.1.
> > > > > >> Voting
> > > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > > >> >
> > > > > >> > Link to release candidate 1.2.1.rc0:
> > > > > >> >
> > > > > >> > https://github.com/apache/incubator-mxnet/releases/tag/
> > 1.2.1.rc0
> > > > > >> >
> > > > > >> > View this page for installation instructions:
> > > > > >> >
> > > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > > >> >
> > > > > >> > (Note: The README.md points to the 1.2.1 tag and does not work
> > at
> > > > the
> > > > > >> > moment).
> > > > > >> >
> > > > > >> > Please remember to test first before voting accordingly.
> > > > > >> >
> > > > > >> > +1 = approve
> > > > > >> > +0 = no opinion
> > > > > >> > -1 = disapprove (provide reason)
> > > > > >> >
> > > > > >> > Anirudh
> > > > > >> >
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
That looks like a flaky test because of atol being too small. please force
rtol and atol values and see if you are still able to reproduce.
On Thu, Jun 21, 2018 at 2:16 PM, Pedro Larroy <pe...@gmail.com>
wrote:
> Observed just one failure in OSX in test_imdecode:
>
>
> ======================================================================
> FAIL: test_imdecode (test_image.TestImage)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/
> unittest/test_image.py",
> line 94, in test_imdecode
> assert_almost_equal(image.asnumpy(), cv_image)
> File
> "/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
> line 493, in assert_almost_equal
> raise AssertionError(msg)
> AssertionError:
> Items are not equal:
> Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000. Location
> of maximum error:(100, 457, 1), a=103.000000, b=102.000000
> a: array([[[ 0, 10, 20],
> [ 0, 11, 19],
> [ 2, 12, 19],...
> b: array([[[ 0, 10, 20],
> [ 0, 11, 19],
> [ 2, 12, 19],...
>
> ----------------------------------------------------------------------
> Ran 505 tests in 2018.430s
>
>
> Is this one known?
>
> The other unit tests passed.
>
> On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com>
> wrote:
>
> > +1
> >
> > Built from source with CUDA on Ubuntu.
> >
> > Ran example/gluon/word_language_model/train.py
> >
> > Best,
> > Haibin
> >
> >
> > On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com> wrote:
> >
> > > Hi Pedro,
> > >
> > > I think you raised this issue in 1.2.0 release here:
> > > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > > .
> > > I actually forgot about this issue during this release. Having said
> > that, I
> > > think since this works with make and the customers using cmake with
> > > USE_OPENMP=OFF should be considerably small we should not block the
> > release
> > > for this.
> > > The main reason we are doing this release is for this issue
> > > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > > this
> > > change for the cmake fix would be also mean we need to pull 8 more
> > commits
> > > from dmlc-core and its considerable risk to introduce for the patch
> > > release.
> > > This would also mean cutting another rc. I think in the interest of our
> > > customers who are eagerly waiting for the patch release to fix the main
> > > issue, we should move ahead here.
> > > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> > release
> > > notes. I will do that now.
> > >
> > > Anirudh
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > > pedro.larroy.lists@gmail.com
> > > > wrote:
> > >
> > > > I think I have fixed this before, I will check if the patch didn't
> make
> > > it
> > > > to the branch.
> > > >
> > > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > > pedro.larroy.lists@gmail.com>
> > > > wrote:
> > > >
> > > > > -1 I can't compile:
> > > > >
> > > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > > ()>)::{lambda()#1}&)':
> > > > > /usr/include/c++/5/thread:137: undefined reference to
> > `pthread_create'
> > > > > collect2: error: ld returned 1 exit status
> > > > > ninja: build stopped: subcommand failed.
> > > > >
> > > > >
> > > > > No LSB modules are available.
> > > > > Distributor ID: Ubuntu
> > > > > Description: Ubuntu 16.04.4 LTS
> > > > > Release: 16.04
> > > > > Codename: xenial
> > > > >
> > > > >
> > > > > My build script:
> > > > >
> > > > >
> > > > > #!/bin/bash
> > > > > set -e
> > > > > set -x
> > > > >
> > > > > renice -n 19 -p $$
> > > > >
> > > > > mkdir -p build && cd build
> > > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > > -DUSE_OPENCV=ON
> > > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > > ninja -v
> > > > >
> > > > > cd ..
> > > > > if [ ! -d mxnet_py3 ]; then
> > > > > virtualenv -p `which python3` mxnet_py3
> > > > > fi
> > > > > source mxnet_py3/bin/activate
> > > > > cd python
> > > > > pip install -e .
> > > > > cd ..
> > > > > pip install opencv-python
> > > > > pip install ipython
> > > > > pip install matplotlib
> > > > >
> > > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > This is the vote to release Apache MXNet (incubating) version
> > 1.2.1.
> > > > >> Voting
> > > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > > >> >
> > > > >> > Link to release candidate 1.2.1.rc0:
> > > > >> >
> > > > >> > https://github.com/apache/incubator-mxnet/releases/tag/
> 1.2.1.rc0
> > > > >> >
> > > > >> > View this page for installation instructions:
> > > > >> >
> > > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > > >> >
> > > > >> > (Note: The README.md points to the 1.2.1 tag and does not work
> at
> > > the
> > > > >> > moment).
> > > > >> >
> > > > >> > Please remember to test first before voting accordingly.
> > > > >> >
> > > > >> > +1 = approve
> > > > >> > +0 = no opinion
> > > > >> > -1 = disapprove (provide reason)
> > > > >> >
> > > > >> > Anirudh
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
Observed just one failure in OSX in test_imdecode:
======================================================================
FAIL: test_imdecode (test_image.TestImage)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/pllarroy/devel/mxnet/mxnet_release/tests/python/unittest/test_image.py",
line 94, in test_imdecode
assert_almost_equal(image.asnumpy(), cv_image)
File
"/Users/pllarroy/devel/mxnet/mxnet_release/python/mxnet/test_utils.py",
line 493, in assert_almost_equal
raise AssertionError(msg)
AssertionError:
Items are not equal:
Error 980.392157 exceeds tolerance rtol=0.000010, atol=0.000000. Location
of maximum error:(100, 457, 1), a=103.000000, b=102.000000
a: array([[[ 0, 10, 20],
[ 0, 11, 19],
[ 2, 12, 19],...
b: array([[[ 0, 10, 20],
[ 0, 11, 19],
[ 2, 12, 19],...
----------------------------------------------------------------------
Ran 505 tests in 2018.430s
Is this one known?
The other unit tests passed.
On Thu, Jun 21, 2018 at 2:09 PM Haibin Lin <ha...@gmail.com> wrote:
> +1
>
> Built from source with CUDA on Ubuntu.
>
> Ran example/gluon/word_language_model/train.py
>
> Best,
> Haibin
>
>
> On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com> wrote:
>
> > Hi Pedro,
> >
> > I think you raised this issue in 1.2.0 release here:
> > https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> > ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> > .
> > I actually forgot about this issue during this release. Having said
> that, I
> > think since this works with make and the customers using cmake with
> > USE_OPENMP=OFF should be considerably small we should not block the
> release
> > for this.
> > The main reason we are doing this release is for this issue
> > <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> > this
> > change for the cmake fix would be also mean we need to pull 8 more
> commits
> > from dmlc-core and its considerable risk to introduce for the patch
> > release.
> > This would also mean cutting another rc. I think in the interest of our
> > customers who are eagerly waiting for the patch release to fix the main
> > issue, we should move ahead here.
> > I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1
> release
> > notes. I will do that now.
> >
> > Anirudh
> >
> >
> >
> > On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> > pedro.larroy.lists@gmail.com
> > > wrote:
> >
> > > I think I have fixed this before, I will check if the patch didn't make
> > it
> > > to the branch.
> > >
> > > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > > pedro.larroy.lists@gmail.com>
> > > wrote:
> > >
> > > > -1 I can't compile:
> > > >
> > > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > > InputSplitBase::Chunk>::Init(std::function<bool
> > > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > > ()>)::{lambda()#1}&)':
> > > > /usr/include/c++/5/thread:137: undefined reference to
> `pthread_create'
> > > > collect2: error: ld returned 1 exit status
> > > > ninja: build stopped: subcommand failed.
> > > >
> > > >
> > > > No LSB modules are available.
> > > > Distributor ID: Ubuntu
> > > > Description: Ubuntu 16.04.4 LTS
> > > > Release: 16.04
> > > > Codename: xenial
> > > >
> > > >
> > > > My build script:
> > > >
> > > >
> > > > #!/bin/bash
> > > > set -e
> > > > set -x
> > > >
> > > > renice -n 19 -p $$
> > > >
> > > > mkdir -p build && cd build
> > > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > > -DUSE_OPENCV=ON
> > > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > > ninja -v
> > > >
> > > > cd ..
> > > > if [ ! -d mxnet_py3 ]; then
> > > > virtualenv -p `which python3` mxnet_py3
> > > > fi
> > > > source mxnet_py3/bin/activate
> > > > cd python
> > > > pip install -e .
> > > > cd ..
> > > > pip install opencv-python
> > > > pip install ipython
> > > > pip install matplotlib
> > > >
> > > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com>
> wrote:
> > > >
> > > >> +1
> > > >>
> > > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com>
> wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > This is the vote to release Apache MXNet (incubating) version
> 1.2.1.
> > > >> Voting
> > > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > > >> >
> > > >> > Link to release candidate 1.2.1.rc0:
> > > >> >
> > > >> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > > >> >
> > > >> > View this page for installation instructions:
> > > >> >
> > > >> > https://mxnet.incubator.apache.org/install/index.html
> > > >> >
> > > >> > (Note: The README.md points to the 1.2.1 tag and does not work at
> > the
> > > >> > moment).
> > > >> >
> > > >> > Please remember to test first before voting accordingly.
> > > >> >
> > > >> > +1 = approve
> > > >> > +0 = no opinion
> > > >> > -1 = disapprove (provide reason)
> > > >> >
> > > >> > Anirudh
> > > >> >
> > > >>
> > > >
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Haibin Lin <ha...@gmail.com>.
+1
Built from source with CUDA on Ubuntu.
Ran example/gluon/word_language_model/train.py
Best,
Haibin
On Thu, Jun 21, 2018 at 11:08 AM, Anirudh <an...@gmail.com> wrote:
> Hi Pedro,
>
> I think you raised this issue in 1.2.0 release here:
> https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
> ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
> .
> I actually forgot about this issue during this release. Having said that, I
> think since this works with make and the customers using cmake with
> USE_OPENMP=OFF should be considerably small we should not block the release
> for this.
> The main reason we are doing this release is for this issue
> <https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling
> this
> change for the cmake fix would be also mean we need to pull 8 more commits
> from dmlc-core and its considerable risk to introduce for the patch
> release.
> This would also mean cutting another rc. I think in the interest of our
> customers who are eagerly waiting for the patch release to fix the main
> issue, we should move ahead here.
> I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1 release
> notes. I will do that now.
>
> Anirudh
>
>
>
> On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <
> pedro.larroy.lists@gmail.com
> > wrote:
>
> > I think I have fixed this before, I will check if the patch didn't make
> it
> > to the branch.
> >
> > On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> > pedro.larroy.lists@gmail.com>
> > wrote:
> >
> > > -1 I can't compile:
> > >
> > > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> > InputSplitBase::Chunk>::Init(std::function<bool
> > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> > InputSplitBase::Chunk>::Init(std::function<bool
> > > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > > ()>)::{lambda()#1}&)':
> > > /usr/include/c++/5/thread:137: undefined reference to `pthread_create'
> > > collect2: error: ld returned 1 exit status
> > > ninja: build stopped: subcommand failed.
> > >
> > >
> > > No LSB modules are available.
> > > Distributor ID: Ubuntu
> > > Description: Ubuntu 16.04.4 LTS
> > > Release: 16.04
> > > Codename: xenial
> > >
> > >
> > > My build script:
> > >
> > >
> > > #!/bin/bash
> > > set -e
> > > set -x
> > >
> > > renice -n 19 -p $$
> > >
> > > mkdir -p build && cd build
> > > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> > -DUSE_OPENCV=ON
> > > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > > ninja -v
> > >
> > > cd ..
> > > if [ ! -d mxnet_py3 ]; then
> > > virtualenv -p `which python3` mxnet_py3
> > > fi
> > > source mxnet_py3/bin/activate
> > > cd python
> > > pip install -e .
> > > cd ..
> > > pip install opencv-python
> > > pip install ipython
> > > pip install matplotlib
> > >
> > > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com> wrote:
> > >
> > >> +1
> > >>
> > >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> > >> Voting
> > >> > will start now and close Thursday June 21st 7:00 PM PDT.
> > >> >
> > >> > Link to release candidate 1.2.1.rc0:
> > >> >
> > >> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> > >> >
> > >> > View this page for installation instructions:
> > >> >
> > >> > https://mxnet.incubator.apache.org/install/index.html
> > >> >
> > >> > (Note: The README.md points to the 1.2.1 tag and does not work at
> the
> > >> > moment).
> > >> >
> > >> > Please remember to test first before voting accordingly.
> > >> >
> > >> > +1 = approve
> > >> > +0 = no opinion
> > >> > -1 = disapprove (provide reason)
> > >> >
> > >> > Anirudh
> > >> >
> > >>
> > >
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Anirudh <an...@gmail.com>.
Hi Pedro,
I think you raised this issue in 1.2.0 release here:
https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
.
I actually forgot about this issue during this release. Having said that, I
think since this works with make and the customers using cmake with
USE_OPENMP=OFF should be considerably small we should not block the release
for this.
The main reason we are doing this release is for this issue
<https://github.com/apache/incubator-mxnet/issues/11091> . Now pulling this
change for the cmake fix would be also mean we need to pull 8 more commits
from dmlc-core and its considerable risk to introduce for the patch release.
This would also mean cutting another rc. I think in the interest of our
customers who are eagerly waiting for the patch release to fix the main
issue, we should move ahead here.
I missed reviewing all the known issue of 1.2.0 and add it to 1.2.1 release
notes. I will do that now.
Anirudh
On Thu, Jun 21, 2018 at 10:42 AM, Pedro Larroy <pedro.larroy.lists@gmail.com
> wrote:
> I think I have fixed this before, I will check if the patch didn't make it
> to the branch.
>
> On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <
> pedro.larroy.lists@gmail.com>
> wrote:
>
> > -1 I can't compile:
> >
> > 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> > `std::thread::thread<dmlc::ThreadedIter<dmlc::io::
> InputSplitBase::Chunk>::Init(std::function<bool
> > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::
> InputSplitBase::Chunk>::Init(std::function<bool
> > (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> > ()>)::{lambda()#1}&)':
> > /usr/include/c++/5/thread:137: undefined reference to `pthread_create'
> > collect2: error: ld returned 1 exit status
> > ninja: build stopped: subcommand failed.
> >
> >
> > No LSB modules are available.
> > Distributor ID: Ubuntu
> > Description: Ubuntu 16.04.4 LTS
> > Release: 16.04
> > Codename: xenial
> >
> >
> > My build script:
> >
> >
> > #!/bin/bash
> > set -e
> > set -x
> >
> > renice -n 19 -p $$
> >
> > mkdir -p build && cd build
> > cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF
> -DUSE_OPENCV=ON
> > -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> > ninja -v
> >
> > cd ..
> > if [ ! -d mxnet_py3 ]; then
> > virtualenv -p `which python3` mxnet_py3
> > fi
> > source mxnet_py3/bin/activate
> > cd python
> > pip install -e .
> > cd ..
> > pip install opencv-python
> > pip install ipython
> > pip install matplotlib
> >
> > On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com> wrote:
> >
> >> +1
> >>
> >> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
> >>
> >> > Hi,
> >> >
> >> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> >> Voting
> >> > will start now and close Thursday June 21st 7:00 PM PDT.
> >> >
> >> > Link to release candidate 1.2.1.rc0:
> >> >
> >> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> >> >
> >> > View this page for installation instructions:
> >> >
> >> > https://mxnet.incubator.apache.org/install/index.html
> >> >
> >> > (Note: The README.md points to the 1.2.1 tag and does not work at the
> >> > moment).
> >> >
> >> > Please remember to test first before voting accordingly.
> >> >
> >> > +1 = approve
> >> > +0 = no opinion
> >> > -1 = disapprove (provide reason)
> >> >
> >> > Anirudh
> >> >
> >>
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
I think I have fixed this before, I will check if the patch didn't make it
to the branch.
On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy <pe...@gmail.com>
wrote:
> -1 I can't compile:
>
> 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> `std::thread::thread<dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::function<bool
> (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> ()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::function<bool
> (dmlc::io::InputSplitBase::Chunk**)>, std::function<void
> ()>)::{lambda()#1}&)':
> /usr/include/c++/5/thread:137: undefined reference to `pthread_create'
> collect2: error: ld returned 1 exit status
> ninja: build stopped: subcommand failed.
>
>
> No LSB modules are available.
> Distributor ID: Ubuntu
> Description: Ubuntu 16.04.4 LTS
> Release: 16.04
> Codename: xenial
>
>
> My build script:
>
>
> #!/bin/bash
> set -e
> set -x
>
> renice -n 19 -p $$
>
> mkdir -p build && cd build
> cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF -DUSE_OPENCV=ON
> -DCMAKE_BUILD_TYPE=Debug -GNinja ..
> ninja -v
>
> cd ..
> if [ ! -d mxnet_py3 ]; then
> virtualenv -p `which python3` mxnet_py3
> fi
> source mxnet_py3/bin/activate
> cd python
> pip install -e .
> cd ..
> pip install opencv-python
> pip install ipython
> pip install matplotlib
>
> On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com> wrote:
>
>> +1
>>
>> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
>>
>> > Hi,
>> >
>> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
>> Voting
>> > will start now and close Thursday June 21st 7:00 PM PDT.
>> >
>> > Link to release candidate 1.2.1.rc0:
>> >
>> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>> >
>> > View this page for installation instructions:
>> >
>> > https://mxnet.incubator.apache.org/install/index.html
>> >
>> > (Note: The README.md points to the 1.2.1 tag and does not work at the
>> > moment).
>> >
>> > Please remember to test first before voting accordingly.
>> >
>> > +1 = approve
>> > +0 = no opinion
>> > -1 = disapprove (provide reason)
>> >
>> > Anirudh
>> >
>>
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Pedro Larroy <pe...@gmail.com>.
-1 I can't compile:
3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
`std::thread::thread<dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::function<bool
(dmlc::io::InputSplitBase::Chunk**)>, std::function<void
()>)::{lambda()#1}&>(dmlc::ThreadedIter<dmlc::io::InputSplitBase::Chunk>::Init(std::function<bool
(dmlc::io::InputSplitBase::Chunk**)>, std::function<void
()>)::{lambda()#1}&)':
/usr/include/c++/5/thread:137: undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.4 LTS
Release: 16.04
Codename: xenial
My build script:
#!/bin/bash
set -e
set -x
renice -n 19 -p $$
mkdir -p build && cd build
cmake -DUSE_CPP_PACKAGE=ON -DUSE_CUDA=OFF -DUSE_OPENMP=OFF -DUSE_OPENCV=ON
-DCMAKE_BUILD_TYPE=Debug -GNinja ..
ninja -v
cd ..
if [ ! -d mxnet_py3 ]; then
virtualenv -p `which python3` mxnet_py3
fi
source mxnet_py3/bin/activate
cd python
pip install -e .
cd ..
pip install opencv-python
pip install ipython
pip install matplotlib
On Wed, Jun 20, 2018 at 6:33 PM Indhu <in...@gmail.com> wrote:
> +1
>
> On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
>
> > Hi,
> >
> > This is the vote to release Apache MXNet (incubating) version 1.2.1.
> Voting
> > will start now and close Thursday June 21st 7:00 PM PDT.
> >
> > Link to release candidate 1.2.1.rc0:
> >
> > https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
> >
> > View this page for installation instructions:
> >
> > https://mxnet.incubator.apache.org/install/index.html
> >
> > (Note: The README.md points to the 1.2.1 tag and does not work at the
> > moment).
> >
> > Please remember to test first before voting accordingly.
> >
> > +1 = approve
> > +0 = no opinion
> > -1 = disapprove (provide reason)
> >
> > Anirudh
> >
>
Re: [VOTE] Release MXNet version 1.2.1.RC0 (Patch Release)
Posted by Indhu <in...@gmail.com>.
+1
On Mon, Jun 18, 2018, 6:52 PM Anirudh <an...@gmail.com> wrote:
> Hi,
>
> This is the vote to release Apache MXNet (incubating) version 1.2.1. Voting
> will start now and close Thursday June 21st 7:00 PM PDT.
>
> Link to release candidate 1.2.1.rc0:
>
> https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc0
>
> View this page for installation instructions:
>
> https://mxnet.incubator.apache.org/install/index.html
>
> (Note: The README.md points to the 1.2.1 tag and does not work at the
> moment).
>
> Please remember to test first before voting accordingly.
>
> +1 = approve
> +0 = no opinion
> -1 = disapprove (provide reason)
>
> Anirudh
>