You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ywkaras (via GitHub)" <gi...@apache.org> on 2023/05/15 21:47:25 UTC
[GitHub] [trafficserver] ywkaras opened a new pull request, #9712: Remove deprecated debug output functions from 53 files.
ywkaras opened a new pull request, #9712:
URL: https://github.com/apache/trafficserver/pull/9712
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1201442734
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
Do you mean, if a file currently only uses `static` for file scope, I should nonetheless use an anonymous namespace for new DbgCtl file scope objects. I'll do that if @SolidWallOfCode concurs. Hard to anticipate what color bikeshed everyone wants beforehand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1194412967
##########
plugins/conf_remap/conf_remap.cc:
##########
@@ -28,6 +29,9 @@
static const char PLUGIN_NAME[] = "conf_remap";
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static TSDbgCtl const *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
namespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1202596122
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
I only mentioned it because you have done so in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1194425397
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
mission creep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1194412821
##########
plugins/certifier/certifier.cc:
##########
@@ -44,9 +44,13 @@
#include <algorithm>
#include "ts/ts.h"
+#include <tscpp/api/Cleanup.h>
const char *PLUGIN_NAME = "certifier";
+atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+TSDbgCtl const *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1194412278
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1201394073
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
How much of what is currently not ideal about ATS do I personally need to commit to fixing so I can get the PR approved? What's next, are my relatives going to be kidnapped also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#issuecomment-1690865255
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras closed pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras closed pull request #9712: Remove deprecated debug output functions from 53 files.
URL: https://github.com/apache/trafficserver/pull/9712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#discussion_r1201222731
##########
example/plugins/c-api/cache_scan/cache_scan.cc:
##########
@@ -33,10 +33,12 @@
#include "ts/ts.h"
#include "ts/experimental.h"
#include "tscore/ink_defs.h"
+#include "tscpp/api/Cleanup.h"
#define PLUGIN_NAME "cache_scan"
-static const TSDbgCtl *const dbg_ctl = TSDbgCtlCreate(PLUGIN_NAME);
+static atscppapi::TSDbgCtlUniqPtr dbg_ctl_guard{TSDbgCtlCreate(PLUGIN_NAME)};
+static const TSDbgCtl *const dbg_ctl{dbg_ctl_guard.get()};
Review Comment:
How so? Are you going to fix it in a future PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#issuecomment-1559569264
Yeh, I agree with Walt, lets do one "task" per PR, adding namespaces and other C++ fluff can be done in another set of PRs / cleanup tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #9712: Remove deprecated debug output functions from 53 files.
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #9712:
URL: https://github.com/apache/trafficserver/pull/9712#issuecomment-1554920762
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org