[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4193: fs: Change off_t and related types to int64_t if long long is supported

[GitBox <gi...@apache.org>]

davids5 commented on a change in pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#discussion_r673899009



##########
File path: include/dirent.h
##########
@@ -86,6 +86,14 @@
 #define DT_LNK                    DTYPE_LINK
 #define DT_SOCK                   DTYPE_SOCK
 
+#define dirent64                  dirent
+#define readdir64                 readdir
+#define readdir64_r               readdir_r
+#define scandir64                 scandir
+#define alphasort64               alphasort
+#define versionsort64             versionsort
+#define getdents64                getdents
+

Review comment:
       Please point to where this is defined in pubs.opengroup.org
   
   If it is shims for linux maybe we should consider a different approach. 
   
   Should this all be behind the Kconfig to get an error if config is wrong? 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org