You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2024/01/09 07:44:20 UTC
[PR] [WIP][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean [spark]
beliefer opened a new pull request, #44638:
URL: https://github.com/apache/spark/pull/44638
### What changes were proposed in this pull request?
This PR propose to replace `AtomicBoolean` with `volatile` boolean for some code.
### Why are the changes needed?
volatile could keep the visibility and is a lightweight synchronization method.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
GA tests.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46650][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #44638: [SPARK-46650][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean
URL: https://github.com/apache/spark/pull/44638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46650][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44638:
URL: https://github.com/apache/spark/pull/44638#issuecomment-1884556786
> It's probably fine but does this improve anything? It's about the same
Reduce a little overhead due to `AtomicBoolean's` `get` and `set` actually use volatile .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46650][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44638:
URL: https://github.com/apache/spark/pull/44638#issuecomment-1884154440
ping @srowen @dongjoon-hyun @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46650][CORE][SQL][YARN] Replace AtomicBoolean with volatile boolean [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #44638:
URL: https://github.com/apache/spark/pull/44638#issuecomment-1884463326
It's probably fine but does this improve anything? It's about the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org