You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/05/19 07:40:04 UTC

[GitHub] [jackrabbit-oak] kwin commented on pull request #293: OAK-9436 clean transient session storage after exceptions during import

kwin commented on pull request #293:
URL: https://github.com/apache/jackrabbit-oak/pull/293#issuecomment-843834384


   > does the session contain any modifications after the exception
   Without this PR yes, afterwards not.
   
   > adding a {{assertFalse(session.hasPendingChanges()}} should be added to the tests.
   Good point, will ad it.]
   
   > also i would like you to invite more oak-committers for the review as i am not the owner of the importer code and might well miss some crucial pieces.
   I would love to but that isn't possible due to https://lists.apache.org/thread.html/rc57f0d58647113bad470d2632ec9cf3013ae3c6d41b759ada14c47be%40%3Cdev.jackrabbit.apache.org%3E.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org