[jira] Resolved: (SLING-1213) Filters to support servlet-API-level scope configuration

["Felix Meschberger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1213.
--------------------------------------

    Fix Version/s: Engine 2.1.2
       Resolution: Fixed

Implemented support for the new filter scopes and defined respective constants in the EngineConstants class in Rev. 993280.

The supported filter scopes are now:

   REQUEST  -- request level filters
   INCLUDE -- filters only called on RequestDispatcher.include (also for jsp:include, and sling:include)
   FORWARD -- filters only called on RequestDispatcher.forward (also for jsp:forward, and sling:forward)
   ERROR -- filters only called handling status responses due to sendError and unhandled Throwables
   COMPONENT -- filters called after REQUEST level filters and upon RequestDispatcher.forward and include

> Filters to support servlet-API-level scope configuration
> --------------------------------------------------------
>
>                 Key: SLING-1213
>                 URL: https://issues.apache.org/jira/browse/SLING-1213
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>            Reporter: Mike Pfaff
>            Assignee: Felix Meschberger
>             Fix For: Engine 2.1.2
>
>
> Currently the filter.scope supports either
> - component (comparable to <dispatcher>INCLUDE,FORWARD,ERROR</dispatcher> of the servlet API) 
> or
> - request (comparable to <dispatcher>REQUEST</dispatcher> of the servlet API)
> In certain cases one wants to have finer control over the filter scopes, e.g. have a filter that would do <dispatcher>REQUEST,FORWARD</dispatcher>, so that the filter is applied first for the request and then again when you do a requestDispatcher.forward().
> Therefore i suggest that the filter.scope should be enhanced as follows:
> - Make filter.scope a multi-value property
> - Add filter scopes: include, forward and error
> - The existing filter scope "component"(quasi an alias for "include,forward,error") should for backward-compatibility not change.
> - Add filter chains for the new filter scopes (don't know if this is needed internally?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.