Re: [PR] feat(ci): publish Python unit test results as PR check annotations [superset]

["bito-code-review[bot] (via GitHub)" <gi...@apache.org>]

bito-code-review[bot] commented on PR #42503:
URL: https://github.com/apache/superset/pull/42503#issuecomment-5154610776

   <!-- Bito Reply -->
   The current implementation uses `merge-multiple: true` in `actions/download-artifact` to combine artifacts from different matrix runs into a single directory. Since the XML filenames are identical across Python versions, they overwrite each other. To resolve this, you can either keep the artifact-name directories (by setting `merge-multiple: false`) or include the Python version in the XML filenames during the `pytest` execution in `superset-python-unittest.yml`.
   
   **.github/workflows/superset-python-unittest-report.yml**
   ```
   with:
             pattern: "junit-results-*"
             path: artifacts
             merge-multiple: false
   ```
   
   **.github/workflows/superset-python-unittest.yml**
   ```
   run: |
               pytest ... --junit-xml=test-results/junit-unit-${{ matrix.python-version }}.xml
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org