You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/05/14 09:24:19 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

bartekkuncer opened a new pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270


   ## Description ##
   This change upgrades oneDNN used on v1.x branch to v2.2.2.
   
   ## Checklist ##
   ### Changes ###
   - [x] Change oneDNN tag
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-841270807


   @mxnet-bot run ci [unix-gpu, windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-841270850


   Jenkins CI successfully triggered : [windows-gpu, unix-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.3

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-860054788






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842065876


   Jenkins CI successfully triggered : [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-845123836


   Jenkins CI successfully triggered : [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-841126837


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, website, windows-gpu, sanity, unix-cpu, centos-cpu, edge, centos-gpu, clang, unix-gpu, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-878843550


   @mxnet-bot run ci [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842220712


   @mxnet-bot run ci [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842065782


   @mxnet-bot run ci [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842065782






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#discussion_r633977583



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -430,8 +430,7 @@ void MKLDNNConvolutionForwardFullFeature(const MKLDNNConvFullParam &param, const
       weight.MKLDNNDataReorderAsync(fwd->GetPd().weights_desc());
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), param.conv_param.num_group);
     } else {
-      weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      weight_mem = weight.GetMKLDNNDataReorder(fwd->GetPd().weights_desc());

Review comment:
       Is this change required due to the new oneDNN version or is it a bugfix? I ask because we have a customer facing an issue with this check failing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842220765


   Jenkins CI successfully triggered : [windows-cpu, windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-879092191


   Thanks @bartekkuncer @bgawrych 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#discussion_r633977583



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -430,8 +430,7 @@ void MKLDNNConvolutionForwardFullFeature(const MKLDNNConvFullParam &param, const
       weight.MKLDNNDataReorderAsync(fwd->GetPd().weights_desc());
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), param.conv_param.num_group);
     } else {
-      weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      weight_mem = weight.GetMKLDNNDataReorder(fwd->GetPd().weights_desc());

Review comment:
       Is this change required due to the new oneDNN version or is it a bugfix? I ask because we have a customer facing an issue with this CHECK() failing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-842065876






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-878977643


   @szha Please help with the merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-845123748


   @mxnet-bot run ci [windows-gpu, windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#discussion_r635350378



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -430,8 +430,7 @@ void MKLDNNConvolutionForwardFullFeature(const MKLDNNConvFullParam &param, const
       weight.MKLDNNDataReorderAsync(fwd->GetPd().weights_desc());
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), param.conv_param.num_group);
     } else {
-      weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      weight_mem = weight.GetMKLDNNDataReorder(fwd->GetPd().weights_desc());

Review comment:
       Hi @josephevans , sorry for the late response, I must have overlooked your comment. This change is required due to the new oneDNN version, but may fix your customer issue as well. If you sent me a link to the issue I might be able to say something more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-878843583


   Jenkins CI successfully triggered : [windows-cpu, windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-876278737


   This change requires https://github.com/apache/incubator-mxnet/pull/20350 to be merged first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-876273737


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.3

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-860054799






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
szha merged pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.3

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#issuecomment-876273673


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org