You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/02/11 02:42:38 UTC

Re: Review Request 17858: Made Group's state transitions monotonic except when expiration it is reset to the initial state (DISCONNECTED).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17858/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 5:42 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Addressed comments.


Summary (updated)
-----------------

Made Group's state transitions monotonic except when expiration it is reset to the initial state (DISCONNECTED).


Repository: mesos-git


Description
-------

- Reconnecting does not reset the state to CONNECTING now. The steps the group has taken to set up the group are remembered (thus not redone) across reconnections.
- Improved comments on state transitions.
- Added the DISCONNECTED state back for the parity between Group and ZooKeeperStorage.


Diffs (updated)
-----

  src/zookeeper/group.hpp e51ebb2cf5f09a633462c101f913ee8272be9a6c 
  src/zookeeper/group.cpp a61a384510c54c152fcf330003e315b870f43bc8 

Diff: https://reviews.apache.org/r/17858/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 17858: Made Group's state transitions monotonic except when expiration it is reset to the initial state (DISCONNECTED).

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17858/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 5:43 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

- Reconnecting does not reset the state to CONNECTING now. The steps the group has taken to set up the group are remembered (thus not redone) across reconnections.
- Improved comments on state transitions.
- Added the DISCONNECTED state back for the parity between Group and ZooKeeperStorage.


Diffs
-----

  src/zookeeper/group.hpp e51ebb2cf5f09a633462c101f913ee8272be9a6c 
  src/zookeeper/group.cpp a61a384510c54c152fcf330003e315b870f43bc8 

Diff: https://reviews.apache.org/r/17858/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu