You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/30 19:26:15 UTC
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9871
to review the following change.
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
---
M docs/troubleshooting.adoc
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9871/1
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 )
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 30 Mar 2018 21:37:20 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9871
to look at the new patch set (#2).
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
---
M docs/troubleshooting.adoc
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9871/2
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9871 )
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Reviewed-on: http://gerrit.cloudera.org:8080/9871
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/troubleshooting.adoc
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 )
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9871/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/9871/1/docs/troubleshooting.adoc@59
PS1, Line 59: ext3, or ext4 formatted device; see link:https://unix.stackexchange.com/q/60723[this Stack
> why don't we put the file and blkid examples here instead of linking to sta
Well, if we're going to do that, I'd like to include the tune2fs example too (because I don't know exactly what UNIX tools someone has installed). And that's a lot of text. I figured this is rare enough that going to SE isn't such a big deal.
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 30 Mar 2018 21:11:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 )
Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9871/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/9871/1/docs/troubleshooting.adoc@59
PS1, Line 59: ext3, or ext4 formatted device; see link:https://unix.stackexchange.com/q/60723[this Stack
why don't we put the file and blkid examples here instead of linking to stack exchange?
--
To view, visit http://gerrit.cloudera.org:8080/9871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4917e144690943e43bf5aa380b59379669846d9
Gerrit-Change-Number: 9871
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 30 Mar 2018 19:54:55 +0000
Gerrit-HasComments: Yes