[GitHub] [flink] kl0u commented on a change in pull request #10276: [FLINK-14885][client] YarnClusterDescriptor should not know about detached option

[GitBox <gi...@apache.org>]

kl0u commented on a change in pull request #10276: [FLINK-14885][client] YarnClusterDescriptor should not know about detached option
URL: https://github.com/apache/flink/pull/10276#discussion_r350178768
 
 

 ##########
 File path: flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java
 ##########
 @@ -124,27 +124,6 @@ public void testCorrectSettingOfMaxSlots() throws Exception {
 		assertEquals(1, clusterSpecification.getNumberTaskManagers());
 	}
 
-	@Test
-	public void testCorrectSettingOfDetachedMode() throws Exception {
 
 Review comment:
   I would leave this test and simply do:
   
   ```
   		assertTrue(!executorConfig.get(DeploymentOptions.ATTACHED));
   ```
   
   at the end, without going through the descriptor. Simply to verify that the `-yd` flag is correctly propagated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services