You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/12/04 12:30:01 UTC
Review Request 64297: Updated modules documentation with some more
details.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around ook modules.
Diffs
-----
docs/hook.md PRE-CREATION
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/1/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196293
-----------------------------------------------------------
docs/modules.md
Lines 145 (patched)
<https://reviews.apache.org/r/64297/#comment275846>
s/- Used/Used/
I wonder if there is any value in keeping the TestModule around.
- Kapil Arya
On Jan. 25, 2018, 4:58 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 4:58 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/hook.md PRE-CREATION
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196296
-----------------------------------------------------------
PASS: Mesos patch 64297 was successfully built and tested.
Reviews applied: `['64297']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64297
- Mesos Reviewbot Windows
On Jan. 25, 2018, 2:16 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196294
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Jan. 25, 2018, 5:16 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 5:16 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 10:16 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around hook modules.
Diffs (updated)
-----
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/3/
Changes: https://reviews.apache.org/r/64297/diff/2-3/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 9:58 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Changes
-------
Addressed comments.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around hook modules.
Diffs (updated)
-----
docs/hook.md PRE-CREATION
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/2/
Changes: https://reviews.apache.org/r/64297/diff/1-2/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review192760
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['64297']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64297
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64297/logs/libprocess-tests-stdout.log):
```
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(446): error: (await_subprocess(client.get(), 0)).failure():
[++++++++++] Subprocess output.
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SSLClientTest
[ RUN ] SSLClientTest.client
[ OK ] SSLClientTest.client (18 ms)
[----------] 1 test from SSLClientTest (18 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (18 ms total)
[ PASSED ] 1 test.
[++++++++++]
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (1519 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1052 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (3895 ms total)
[----------] Global test environment tear-down
[==========] 222 tests from 35 test cases ran. (52318 ms total)
[ PASSED ] 221 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false"
1 FAILED TEST
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64297/logs/libprocess-tests-stderr.log):
```
LIBPROCESS_SSL_VERIFY_CERT set to true
I1204 21:08:01.001610 2680 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\m3DSJF\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1204 21:08:02.363243 1604 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1204 21:08:02.364307 1604 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1204 21:08:02.364307 1604 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1204 21:08:02.364307 1604 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1204 21:08:02.365309 1604 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\yjhfxJ\cert.pem
bject alternative name certificate extension.
I1204 21:07:59.838918 2440 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1204 21:07:59.839900 2440 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\M81pPo\cert.pem
I1204 21:07:59.839900 2440 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\M81pPo
I1204 21:08:00.701602 2440 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1204 21:08:00.701602 2440 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1204 21:08:00.701602 2440 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1204 21:08:00.701602 2440 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\m3DSJF\cert.pem
I1204 21:08:02.065299 2440 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1204 21:08:02.065299 2440 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1204 21:08:02.065299 2440 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1204 21:08:02.065299 2440 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1204 21:08:02.066304 2440 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\yjhfxJ\cert.pem
I1204 21:08:02.568505 2904 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 4, 2017, 1:25 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/hook.md PRE-CREATION
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review194134
-----------------------------------------------------------
docs/hook.md
Lines 30 (patched)
<https://reviews.apache.org/r/64297/#comment272867>
You use `slave` instead of `Agent` in other parts of this file.
docs/hook.md
Lines 56 (patched)
<https://reviews.apache.org/r/64297/#comment272868>
This document contains `within slave` and `within the slave`, using the same wording every time would be cleaner.
docs/hook.md
Lines 61 (patched)
<https://reviews.apache.org/r/64297/#comment272869>
The `a` can be removed.
docs/hook.md
Lines 72 (patched)
<https://reviews.apache.org/r/64297/#comment272870>
s/`docker`/`Docker`
docs/hook.md
Lines 82 (patched)
<https://reviews.apache.org/r/64297/#comment272871>
s/`the hook loaded last`/`the last hook loaded`
docs/hook.md
Lines 157 (patched)
<https://reviews.apache.org/r/64297/#comment272872>
s/`attributes for`/`attributes of`
docs/modules.md
Lines 135 (patched)
<https://reviews.apache.org/r/64297/#comment272873>
Even if no dedicated section exists for this module yet, could a one-liner description be added in this array? Same for the ones at the end of the array.
docs/modules.md
Lines 141 (patched)
<https://reviews.apache.org/r/64297/#comment272866>
s/`implementubg`/`implementing`
- Armand Grillet
On Dec. 4, 2017, 1:25 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/hook.md PRE-CREATION
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 1:25 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description (updated)
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around hook modules.
Diffs
-----
docs/hook.md PRE-CREATION
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/1/
Testing
-------
Thanks,
Till Toenshoff