You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/08 08:31:19 UTC
[GitHub] [iotdb] zhengjp31 opened a new pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
zhengjp31 opened a new pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530
This is the English proofreading of the user guide (v0.12x).
Contains the following sections: Quick Start, Data Concept, CLI, Administration Management, IoTDB-SQL Language, API, UDF, Communication Service Protocol and System Tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530#discussion_r673868810
##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -65,21 +65,30 @@
### 1.2 TsFile Overview
+
+
<!-- TODO
+
Here is the structure diagram of TsFile.
<img style="width:100%; max-width:800px; max-height:600px; margin-left:auto; margin-right:auto; display:block;" src="https://user-images.githubusercontent.com/33376433/123052025-f47aab80-d434-11eb-94c2-9b75429e5c54.png">
-This TsFile contains two entities: d1, d2. Each entity contains two measurements: s1, s2. 4 timeseries in total. Each timeseries contains 2 Chunks.
+
+Here is another representation of the TsFile structure:
+
-->
There are two parts in TsFile: **Data Area** and **Index Area**.
There are three concepts, from small to large, in **Data Area:**
-* **Page**: A page is a sequence of timeseries. It is the smallest unit in which a data block is deserialized.
Review comment:
why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530#discussion_r673868671
##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -65,21 +65,30 @@
### 1.2 TsFile Overview
+
+
<!-- TODO
+
Here is the structure diagram of TsFile.
<img style="width:100%; max-width:800px; max-height:600px; margin-left:auto; margin-right:auto; display:block;" src="https://user-images.githubusercontent.com/33376433/123052025-f47aab80-d434-11eb-94c2-9b75429e5c54.png">
-This TsFile contains two entities: d1, d2. Each entity contains two measurements: s1, s2. 4 timeseries in total. Each timeseries contains 2 Chunks.
+
+Here is another representation of the TsFile structure:
+
-->
There are two parts in TsFile: **Data Area** and **Index Area**.
There are three concepts, from small to large, in **Data Area:**
-* **Page**: A page is a sequence of timeseries. It is the smallest unit in which a data block is deserialized.
+
+* A list of ChunkMetadata organized by timeseries.
Review comment:
this belongs to Index Area..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530#discussion_r673872140
##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -226,19 +236,29 @@ The degree of the index tree (that is, the max number of each node's children) c
In the case of 5 entities with 5 measurements each: Since the numbers of entities and measurements are both no more than `max_degree_of_index_node`, the tree has only measurement index level by default. In this level, each IndexNode is composed of no more than 10 index entries. The root node is `INTERNAL_ENTITY` type, and the 5 index entries point to index nodes of related entities. These nodes point to `TimeseriesIndex` directly, as they are `LEAF_MEASUREMENT` type.
-* Example 2: 1 entity with 150 measurements
+
+In the case of 5 devices with 5 measurements each: Since the numbers of devices and measurements are both no more than `max_degree_of_index_node`, the tree has only measurement index level by default. In this level, each MetadataIndexNode is composed of no more than 10 MetadataIndex entries. The root nonde is `INTERNAL_MEASUREMENT` type, and the 5 MetadataIndex entries point to MetadataIndex nodes of related devices. These nodes point to `TimeseriesMetadata` directly, as they are `LEAF_MEASUREMENT` type.
Review comment:
duplicated
##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -226,19 +236,29 @@ The degree of the index tree (that is, the max number of each node's children) c
In the case of 5 entities with 5 measurements each: Since the numbers of entities and measurements are both no more than `max_degree_of_index_node`, the tree has only measurement index level by default. In this level, each IndexNode is composed of no more than 10 index entries. The root node is `INTERNAL_ENTITY` type, and the 5 index entries point to index nodes of related entities. These nodes point to `TimeseriesIndex` directly, as they are `LEAF_MEASUREMENT` type.
-* Example 2: 1 entity with 150 measurements
Review comment:
why remove...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
Posted by GitBox <gi...@apache.org>.
HTHou closed pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #3530: English proofreading of User Guide (v0.12x) Before Ecosystem Integration
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3530:
URL: https://github.com/apache/iotdb/pull/3530#discussion_r666016182
##########
File path: docs/SystemDesign/TsFile/Read.md
##########
@@ -63,7 +63,7 @@ ValueLt|value filter|value on this column < some value|ValueLt("string") means v
ValueLtEq|value filter|value on this column <= some value|ValueLtEq(-100) means value on this column shold be less than or equal to -100
ValueNotEq|value filter|value on this column != some value|ValueNotEq(true) means value on this column should not be true
-Filter can be composed of one or two Filter children。If a Filter is composed of a single Filter, it is also termed as UnaryFilter.If it contains two filters, it is termed as BinaryFilter. In this case, the two filters are connected with a logical relation, AND or OR, where the formar is termed as AndFilter, and the latter is OrFilter. Obviously, both AndFilter and OrFilter are BinaryFilter.
+A filter can consist of one or two sub-filters.。If a Filter is composed of a single Filter, it is also termed as UnaryFilter.If it contains two filters, it is termed as BinaryFilter. In this case, the two filters are connected with a logical relation, AND or OR, where the formar is termed as AndFilter, and the latter is OrFilter. Obviously, both AndFilter and OrFilter are BinaryFilter.
Review comment:
```suggestion
A filter can consist of one or two sub-filters.If a Filter is composed of a single Filter, it is also termed as UnaryFilter.If it contains two filters, it is termed as BinaryFilter. In this case, the two filters are connected with a logical relation, AND or OR, where the formar is termed as AndFilter, and the latter is OrFilter. Obviously, both AndFilter and OrFilter are BinaryFilter.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org