You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by "estib-prog (via GitHub)" <gi...@apache.org> on 2026/04/16 07:16:59 UTC
[PR] Added Status [royale-asjs]
estib-prog opened a new pull request, #1282:
URL: https://github.com/apache/royale-asjs/pull/1282
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4321672700
## [](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4474834063
## [](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_royale-sdk-asjs&pullRequest=1282&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_royale-sdk-asjs&pullRequest=1282&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_royale-sdk-asjs&pullRequest=1282&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_royale-sdk-asjs&pullRequest=1282&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_royale-sdk-asjs&pullRequest=1282&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4258112453
## [](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "estib-prog (via GitHub)" <gi...@apache.org>.
estib-prog commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4321672026
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "Harbs (via GitHub)" <gi...@apache.org>.
Harbs commented on code in PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#discussion_r3144937185
##########
frameworks/projects/Style/src/main/royale/org/apache/royale/style/skins/StatusSkin.as:
##########
@@ -0,0 +1,97 @@
+// //////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// //////////////////////////////////////////////////////////////////////////////
+package org.apache.royale.style.skins
+{
+ import org.apache.royale.style.StyleSkin;
+ import org.apache.royale.style.Status;
+ import org.apache.royale.core.IStrand;
+ import org.apache.royale.style.stylebeads.background.BackgroundColor;
+ import org.apache.royale.style.stylebeads.border.BorderRadius;
+ import org.apache.royale.style.stylebeads.border.Outline;
+ import org.apache.royale.style.stylebeads.layout.Display;
+ import org.apache.royale.style.stylebeads.layout.Overflow;
+ import org.apache.royale.style.stylebeads.layout.Position;
+ import org.apache.royale.style.stylebeads.layout.Left;
+ import org.apache.royale.style.stylebeads.layout.Top;
+ import org.apache.royale.style.stylebeads.sizing.HeightStyle;
+ import org.apache.royale.style.stylebeads.sizing.WidthStyle;
+ import org.apache.royale.style.stylebeads.typography.VerticalAlign;
+ import org.apache.royale.style.stylebeads.effects.OpacityStyle;
+ import org.apache.royale.style.colors.ColorSwatch;
+ import org.apache.royale.style.colors.ThemeColorSet;
+ import org.apache.royale.style.util.ThemeManager;
+
+ public class StatusSkin extends StyleSkin
+ {
+ public function StatusSkin()
+ {
+ super();
+ }
+
+ private function get host():Status
+ {
+ return _strand as Status;
+ }
+ // Currently using the simplest implementation.
+ // There are additional styling options available for the status indicator
+ // (e.g. different animations, and visual effects)
+ // clsses:
+ // <span class="relative inline-block h-2 w-2 overflow-hidden animate-bounce rounded-full bg-[#3abff8] shadow-[0_2.8px_3.5px_-0.7px_rgba(15,23,42,0.22)] after:absolute after:left-[18%] after:top-[16%] after:h-[38%] after:w-[38%] after:rounded-full after:bg-white/60 after:blur-[1.4px] after:content-['']"></span>
+ // <span class="relative inline-flex h-2 w-2 overflow-hidden rounded-full bg-[#f87272] shadow-[0_2.8px_3.5px_-0.7px_rgba(15,23,42,0.22)] after:absolute after:left-[18%] after:top-[16%] after:h-[38%] after:w-[38%] after:rounded-full after:bg-white/60 after:blur-[1.4px] after:content-['']"></span>
+ override public function set strand(value:IStrand):void
+ {
+ super.strand = value;
+ if (_styles)
+ return;
+ var colorSet:ThemeColorSet = ThemeManager.instance.activeTheme.themeColorSet;
+ var baseColor:ColorSwatch = (host.theme && host.theme != "default") ? colorSet.getSwatch(host.theme, 600) : colorSet.getSwatch(ThemeColorSet.NEUTRAL, 300);
+ var heightWidth:String = computeSize(getSize(), host.unit);
Review Comment:
Using unit is probably wrong because this will not work for anything other than rem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4324563466
## [](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) **Quality Gate failed**
Failed conditions
 [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_royale-sdk-asjs&pullRequest=1282)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "estib-prog (via GitHub)" <gi...@apache.org>.
estib-prog commented on code in PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#discussion_r3145266343
##########
frameworks/projects/Style/src/main/royale/org/apache/royale/style/skins/StatusSkin.as:
##########
@@ -0,0 +1,97 @@
+// //////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// //////////////////////////////////////////////////////////////////////////////
+package org.apache.royale.style.skins
+{
+ import org.apache.royale.style.StyleSkin;
+ import org.apache.royale.style.Status;
+ import org.apache.royale.core.IStrand;
+ import org.apache.royale.style.stylebeads.background.BackgroundColor;
+ import org.apache.royale.style.stylebeads.border.BorderRadius;
+ import org.apache.royale.style.stylebeads.border.Outline;
+ import org.apache.royale.style.stylebeads.layout.Display;
+ import org.apache.royale.style.stylebeads.layout.Overflow;
+ import org.apache.royale.style.stylebeads.layout.Position;
+ import org.apache.royale.style.stylebeads.layout.Left;
+ import org.apache.royale.style.stylebeads.layout.Top;
+ import org.apache.royale.style.stylebeads.sizing.HeightStyle;
+ import org.apache.royale.style.stylebeads.sizing.WidthStyle;
+ import org.apache.royale.style.stylebeads.typography.VerticalAlign;
+ import org.apache.royale.style.stylebeads.effects.OpacityStyle;
+ import org.apache.royale.style.colors.ColorSwatch;
+ import org.apache.royale.style.colors.ThemeColorSet;
+ import org.apache.royale.style.util.ThemeManager;
+
+ public class StatusSkin extends StyleSkin
+ {
+ public function StatusSkin()
+ {
+ super();
+ }
+
+ private function get host():Status
+ {
+ return _strand as Status;
+ }
+ // Currently using the simplest implementation.
+ // There are additional styling options available for the status indicator
+ // (e.g. different animations, and visual effects)
+ // clsses:
+ // <span class="relative inline-block h-2 w-2 overflow-hidden animate-bounce rounded-full bg-[#3abff8] shadow-[0_2.8px_3.5px_-0.7px_rgba(15,23,42,0.22)] after:absolute after:left-[18%] after:top-[16%] after:h-[38%] after:w-[38%] after:rounded-full after:bg-white/60 after:blur-[1.4px] after:content-['']"></span>
+ // <span class="relative inline-flex h-2 w-2 overflow-hidden rounded-full bg-[#f87272] shadow-[0_2.8px_3.5px_-0.7px_rgba(15,23,42,0.22)] after:absolute after:left-[18%] after:top-[16%] after:h-[38%] after:w-[38%] after:rounded-full after:bg-white/60 after:blur-[1.4px] after:content-['']"></span>
+ override public function set strand(value:IStrand):void
+ {
+ super.strand = value;
+ if (_styles)
+ return;
+ var colorSet:ThemeColorSet = ThemeManager.instance.activeTheme.themeColorSet;
+ var baseColor:ColorSwatch = (host.theme && host.theme != "default") ? colorSet.getSwatch(host.theme, 600) : colorSet.getSwatch(ThemeColorSet.NEUTRAL, 300);
+ var heightWidth:String = computeSize(getSize(), host.unit);
Review Comment:
I used the `computeSize` function, so I assumed it would handle different units correctly. Is there a specific case where this breaks that I should account for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "Harbs (via GitHub)" <gi...@apache.org>.
Harbs commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4321569435
Why is the size in px instead of rem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added Status [royale-asjs]
Posted by "estib-prog (via GitHub)" <gi...@apache.org>.
estib-prog commented on PR #1282:
URL: https://github.com/apache/royale-asjs/pull/1282#issuecomment-4258110219
@Harbs Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org