You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/05/04 02:20:00 UTC
[jira] [Commented] (CASSANDRA-13994) Remove COMPACT STORAGE
internals before 4.0 release
[ https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098630#comment-17098630 ]
Ekaterina Dimitrova commented on CASSANDRA-13994:
-------------------------------------------------
[Patch|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-13994]
[CI Java8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/118/workflows/9e57522d-52fa-4d44-88d8-5cec0e87f517]
[CI Java11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/118/workflows/4938a2b2-28dd-45e7-971a-cbe5d656f86e]
There are a couple of failures which are flaky tests that exist also on the trunk, not related.
Two outstanding questions:
- After the user migrates the compact storage, is it enough if we update the upgrade documentation and indexes defunct properly in case the user still have them and try to use them? Or do we want to iterate on start through the indexes again (further to checking for not migrated COMPACT STORAGE tables) check for old indexes of kind KEYS, and prevent the server from start? For now there is a warning added to the one, that the user should migrate from compact storage on start if they haven't done It yet.
- The system table Built_indexes, I saw there is some SystemKeyspaceMigrator40 class, I guess on start we can check and migrate this table (if it was not already migrated) there?
> Remove COMPACT STORAGE internals before 4.0 release
> ---------------------------------------------------
>
> Key: CASSANDRA-13994
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13994
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
> Reporter: Alex Petrov
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-rc
>
>
> 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of the related functionality is useless.
> There are still some things to consider:
> 1. One of the system tables (built indexes) was compact. For now, we just added {{value}} column to it to make sure it's backwards-compatible, but we might want to make sure it's just a "normal" table and doesn't have redundant columns.
> 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is trivial, but this would mean that all built indexes will be defunct. We could log a warning for now and ask users to migrate off those for now and completely remove it from future releases. It's just a couple of classes though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org