You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mastanik <gi...@git.apache.org> on 2015/03/13 10:42:23 UTC
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
GitHub user mastanik opened a pull request:
https://github.com/apache/activemq-6/pull/182
Added possibility to intercept stomp frames
Initially I was trying to log all the incoming stomp frames from the client on a server side, but could not find any easy way of doing this. This pr adds possibility to intercept stomp frames via interceptor section in activemq-configuration.xml.
Interceptor list was already passed as a parameter to StompProtocolManager constructor, but was not used in any way. I decided to introduce new abstract class which implements Interceptor interface as the simplest solution and then invoke its intercept method like it is done with the regular interceptors.
Clients need to extend this class and put it under activemq class path, just as a regular jms interceptor.
Looking forward to your comments, and feel free to reject it in case it does not make any sense.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mastanik/activemq-6 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit 05b469589dc7fe5b4f9e58654437e3501b6bc2f9
Author: nberdikov <nb...@groupon.com>
Date: 2015-03-13T09:29:33Z
Added possibility to intercept stomp frames
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-81347599
There's a risk of something wrong with your PR. We have a release tomorrow so I will wait until the release is done before I merge this, ok?
I'm concerned with the case with having a regular interceptor. and a stomp acceptor where no acceptors were supposed to be used and having a class cast exception.
I will do some work on this right after the release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-78967583
Nicely done... +1 on me for a merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-79020971
If you have a chance also, add a paragraph to the docs :) I will do it right away if you don't have time to do it.. but please advise if that's the case so I will do the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-82330121
Can you close this one please ? I have imported your commit into mine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-79020069
I will hold the PR open until you do it then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-81538505
Yes, it's ok.
If there would be any problems with my PR please let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-81176956
Added 2 new commits with outgoing frames support and new stomp interceptor paragrap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-78994222
Yes, sure, I will update this pr when it is done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik closed the pull request at:
https://github.com/apache/activemq-6/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by HornetQBot <gi...@git.apache.org>.
Github user HornetQBot commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-78891438
Can one of the admins verify this patch by saying "ok to test"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-81980131
as I promised I would work on this after the release...#191
The release is now under vote, so I continued your work at #191 where I did some refactoring.
As soon as #191 is merged this one should be closed automatically.
If you could please review my changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-81177534
I will merge it later today when I get home
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik commented on the pull request:
https://github.com/apache/activemq-6/pull/182#issuecomment-79029355
Sure, I will update it as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---