You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by mikewallace1979 <gi...@git.apache.org> on 2016/03/10 15:30:44 UTC

[GitHub] couchdb-couch-log pull request: Remove module_loaded check in get_...

GitHub user mikewallace1979 opened a pull request:

    https://github.com/apache/couchdb-couch-log/pull/11

    Remove module_loaded check in get_backend

    See [the JIRA ticket](https://issues.apache.org/jira/browse/COUCHDB-2968) for
    the full context.
    
    I'm not sure whether or not we're losing anything by removing the check or whether
    there's another way we could fix this. /cc @kxepal 
    
    ---
    When the code server loads modules dynamically,
    module_loaded(Backend) will not return true until it has actually
    been called. Since couch_log is the only thing that calls it, this
    can result in the backend module never being loaded.
    
    Closes COUCHDB-2968

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewallace1979/couchdb-couch-log 2968-remove-module_loaded-check-in-get_backend

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-log/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit ad17fcf92d6635666042b2d7f96bdb0fca41848e
Author: Mike Wallace <mi...@apache.org>
Date:   2016-03-10T14:15:15Z

    Remove module_loaded check in get_backend
    
    When the code server loads modules dynamically,
    module_loaded(Backend) will not return true until it has actually
    been called. Since couch_log is the only thing that calls it this
    can result in the backend module never being loaded.
    
    Closes COUCHDB-2968

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-log pull request: Remove module_loaded check in get_...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch-log/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-log pull request: Remove module_loaded check in get_...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch-log/pull/11#issuecomment-194980113
  
    Oh, nice. I didn't test it with `make install`. Good to know that it loads dynamically, though it's quite strange, but ok. 
    
    I made it to make graceful fallback to stderr backend when couch_log_lager atom eventually constructed, but no such module actually used (Cloudant case or else with different backend). But now I cannot figure the case when this fallback will save anyone from a crash.
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---