[GitHub] [cassandra-in-jvm-dtest-api] jonmeredith commented on a change in pull request #8: CASSANDRA-15714 Support for replacing logback with alternate logger config (like log4j2)

[GitBox <gi...@apache.org>]

jonmeredith commented on a change in pull request #8:  CASSANDRA-15714 Support for replacing logback with alternate logger config (like log4j2)
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/8#discussion_r407629993
 
 

 ##########
 File path: src/main/java/org/apache/cassandra/distributed/api/ICluster.java
 ##########
 @@ -89,7 +91,8 @@ static void setupLogging()
         {
             File root = Files.createTempDirectory("in-jvm-dtest").toFile();
             root.deleteOnExit();
-            String testConfPath = "test/conf/logback-dtest.xml";
+            String logConfigPropertyName = System.getProperty(PROPERTY_PREFIX + ".logConfigProperty", "logback.configurationFile");
+            String testConfPath = System.getProperty(PROPERTY_PREFIX + ".logConfigPath", "test/conf/logback-dtest.xml");
             Path logConfPath = Paths.get(root.getPath(), "/logback-dtest.xml");
 
 Review comment:
   agreed - fixed up and rebased on top of #7 (so the commits for this now looks weird, but didn't want to point it at your personal repo).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org