You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/01 16:46:34 UTC

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6148: Remove bower from TP

zrhoffman commented on a change in pull request #6148:
URL: https://github.com/apache/trafficcontrol/pull/6148#discussion_r700388541



##########
File path: traffic_portal/package.json
##########
@@ -50,12 +50,12 @@
     "angular-route": "1.8.0",
     "angular-sanitize": "1.8.0",
     "angular-ui-bootstrap": "0.14.3",
-    "bootstrap-sass": "^3.3.6",
-    "es5-shim": "^4.5.6",
-    "flot": "^2.1.6",
-    "font-awesome": "^4.5.0",
-    "jquery": "^2.1.4",
-    "jquery.flot.tooltip": "^0.9.0",
-    "json3": "^3.3.2"
+    "bootstrap-sass": "3.3.6",
+    "es5-shim": "4.5.6",
+    "flot": "2.1.6",

Review comment:
       This downgrades `flot` from `2.3.2`, since `^` can refer to future minor or patch versions. The exact version should refer to what was previously the calculated `^` version to keep it from downgrading. So, `flot` should be `2.3.2`.

##########
File path: CHANGELOG.md
##########
@@ -3,7 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
-## [unreleased]
+## unreleased
+### Changed
+* Migrated completely off of bower in favor of npm
+
+## [6.0.x](https://github.com/apache/trafficcontrol/tree/6.0.x) - branched

Review comment:
       Put it in the current *Changed* changelog section, I'll take care of the 6.0.0 part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org