You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2023/03/13 22:09:46 UTC

[superset] branch hugh/migrate-estimate_query_cost-to-v1 updated (3c39fbf5c0 -> 75899cbe24)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh/migrate-estimate_query_cost-to-v1
in repository https://gitbox.apache.org/repos/asf/superset.git


    from 3c39fbf5c0 address concerns
     add b479e93b49 fix: add disallowed query params for engines specs (#23217)
     add 0a7016df2e chore: Add statsd logger for ssh tunneling creation (#23225)
     add 473a69a704 fix(dashboard): Don't show cross filters checkbox to users without write permissions (#23237)
     add ae8aa60844 docs: update installation docs to include frontend asset build (#23199)
     add aba6900994 build(deps): bump pip-compile-multi from 2.6.1 to 2.6.2 in /requirements (#23122)
     add 7196e87833 fix(dashboard): Cross-filters not working properly for new dashboards (#23194)
     add b180319bbf fix: refuse to start with default secret on non debug envs (#23186)
     add 5a099e0762 fix(dao): use explicit id filter (#23246)
     add 6076457b90 fix(explore): Dashboard filters on adhoc cols not working in Explore (#23239)
     add d16eda6e56 refactor: Organizes the pages in their own folder (#23241)
     add 022df93422 fix: Video Game Sales dashboard default filters (#23242)
     add 5f0c320415 chore: Deprecate show_native_filters (#23228)
     add 134acba99a chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled (#23142)
     add 2ba9d1b79e fix(dashboard): Cross-filter search icon in filter bar (#23250)
     add d3e698eb54 chore(webdriver): Tuning the Webdriver logging a bit (#23255)
     add 1f3eb56688 fix: customize tab on heatmap chart is blank (#23243)
     add 9d0eea9600 fix(dashboard): Missing filter card styles (#23256)
     add 7d8383cbd5 fix: ignore ts warnings from older typescript versions (#23262)
     add 006f3dd88c chore(cache): Tuning logging in cache manager (#23266)
     add 42980a69a7 fix(dashboard): Charts crashing when cross filter on adhoc column is applied (#23238)
     add 71a9d0d403 fix(plugin-chart-echarts): render horizontal categories from top (#23273)
     add 1b139d0748 feat(generic-x-axis): add x sorting on series limit metric (#23274)
     add d16512b775 fix(dashboard): Allow selecting text in cells in Table and PivotTable without triggering cross filters (#23283)
     add f7e7652270 fix(migration): Address issue in #23228 (#23276)
     add ed11123709 chore(dashboard): Cleanup example dashboard filter scopes (#23260)
     add a3d49ca335 fix(dashboard): Infinite load when filter with default first value is out of scope (#23299)
     add e0d976dcca fix(clickhouse):  Update to working clickhouse-connect version (#23296)
     add 376ad39576 chore: upgrade @ant-design/icons for react upgrade (#22890)
     add dae6a9f701 docs: typo 'admnistrators' in security.mdx (#23166)
     add 9df7812e9c build(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 in /superset-websocket (#23292)
     add 56380027f4 build(deps-dev): bump @types/node from 18.14.1 to 18.14.6 in /superset-websocket (#23281)
     add 0a588d11a5 chore: bump docusaurus to latest stable (#23317)
     add eb3d5602c2 docs: add lost _filters param docs (#23316)
     add 57db8f938b feat(docs): adds BugHerd to documentation site. (#23287)
     add 989fe27a0f chore: log different selenium timeout errors differently (#23290)
     add 33b758d716 docs: improve API v1 migration documentation (#23298)
     add 2cf75cc0ce docs(alerts and reports): Update ExecutorType class (#23323)
     add 6311b40329 build(deps-dev): bump @typescript-eslint/parser from 5.53.0 to 5.54.1 in /superset-websocket (#23294)
     add c2b282ac71 feat(dashboard): Refactor FiltersBadge (#23286)
     add a8d5cb89a8 chore: use util test env for init check (#23325)
     add a591130e0b fix(trino): normalize non-iso timestamps (#23339)
     add 78ee60e227 fix(dashboard): Cross filters with time shifted series (#23347)
     add f3055fcaff feat(dashboard): Change default opacity of icon in FiltersBadge (#23350)
     add b99d38dfef fix: dashboard DAO small code improvement (#23348)
     add 82cadccced chore: Remove Cross Filter scoping modal (#23216)
     add 3919ca6060 fix(dashboard): deepmerge htmlSchemaOverrides (#23329)
     add e83f4e6f79 fix(trino): Disallow alias to source column (#23324)
     add d415eed717 fix(examples): Cleanup granularity_sqla column (#23322)
     add 8bc92b0c5a Merge branch 'master' of https://github.com/apache/superset into hugh/migrate-estimate_query_cost-to-v1
     add 75899cbe24 fix lint

No new revisions were added by this update.

Summary of changes:
 .github/workflows/superset-python-unittest.yml     |   2 +
 UPDATING.md                                        |  12 ++
 docker/.env-non-dev                                |   1 +
 docs/docs/installation/alerts-reports.mdx          |  14 +-
 docs/docs/installation/configuring-superset.mdx    |   4 +-
 .../installing-superset-from-scratch.mdx           |   6 +
 docs/docs/installation/sql-templating.mdx          |  47 ++++-
 docs/docs/security.mdx                             |   2 +-
 docs/docusaurus.config.js                          |   9 +-
 docs/package.json                                  |  14 +-
 requirements/integration.txt                       |   2 +-
 setup.py                                           |   2 +-
 superset-embedded-sdk/package-lock.json            |   4 +-
 superset-embedded-sdk/package.json                 |   2 +-
 superset-embedded-sdk/src/index.ts                 |   2 +
 .../cypress/integration/dashboard/load.test.ts     |   3 +-
 .../integration/dashboard/nativeFilters.test.ts    |   8 +-
 superset-frontend/package-lock.json                |  83 ++++++--
 superset-frontend/package.json                     |   2 +-
 .../superset-ui-chart-controls/package.json        |   2 +-
 .../src/operators/pivotOperator.ts                 |   6 +-
 .../src/operators/sortOperator.ts                  |   4 +-
 .../src/operators/utils/extractExtraMetrics.ts}    |  34 ++--
 .../src/operators/utils/index.ts                   |   1 +
 .../src/shared-controls/customControls.tsx         |  83 ++++----
 .../test/operators/pivotOperator.test.ts           |  30 +++
 .../test/operators/sortOperator.test.ts            |  25 +++
 .../operators/utils/extractExtraMetrics.test.ts    |  94 +++++++++
 .../src/components/SafeMarkdown.tsx                |  16 +-
 .../superset-ui-core/src/time-format/index.ts      |   2 +
 .../src/time-format/utils/normalizeTimestamp.ts}   |  14 +-
 .../superset-ui-core/src/utils/getSelectedText.ts} |   7 +-
 .../packages/superset-ui-core/src/utils/index.ts   |   1 +
 .../test/components/SafeMarkdown.test.ts}          |  35 ++--
 .../time-format/utils/normalizeTimestamp.test.ts   |  43 +++++
 .../test/utils/getSelectedText.test.ts}            |  25 ++-
 .../src/Timeseries/buildQuery.ts                   |  35 ++--
 .../src/Timeseries/transformProps.ts               |  67 ++++---
 .../plugin-chart-echarts/src/Timeseries/types.ts   |   1 +
 .../plugin-chart-echarts/src/utils/series.ts       |   3 +
 .../test/Timeseries/transformProps.test.ts         |  69 +++++++
 .../plugins/plugin-chart-pivot-table/package.json  |   2 +-
 .../src/PivotTableChart.tsx                        |   6 +
 .../plugins/plugin-chart-table/src/TableChart.tsx  |   8 +-
 .../src/utils/DateWithFormatter.ts                 |  21 +-
 .../spec/fixtures/mockDashboardState.js            |   2 +-
 .../src/assets/images/icons/filter.svg             |   5 +-
 superset-frontend/src/constants.ts                 |   4 -
 .../src/dashboard/actions/dashboardState.js        |  25 +--
 superset-frontend/src/dashboard/actions/hydrate.js |  69 ++-----
 .../src/dashboard/actions/sliceEntities.js         |   9 +
 .../CrossFilterScopingForm.test.tsx                |  60 ------
 .../CrossFilterScopingForm/index.tsx               |  57 ------
 .../CrossFilterScopingModal.tsx                    | 112 -----------
 .../DashboardBuilder/DashboardBuilder.test.tsx     |   1 -
 .../dashboard/components/DashboardBuilder/state.ts |   6 -
 .../DetailsPanel/DetailsPanel.test.tsx             |  80 +-------
 .../components/FiltersBadge/DetailsPanel/index.tsx | 211 +++++----------------
 .../FiltersBadge/FilterIndicator/index.tsx         |  49 ++---
 .../components/FiltersBadge/FiltersBadge.test.tsx  |  71 +------
 .../dashboard/components/FiltersBadge/Styles.tsx   | 147 ++++++--------
 .../dashboard/components/FiltersBadge/index.tsx    | 100 +++++-----
 .../src/dashboard/components/SliceHeader/index.tsx |  40 ++--
 .../components/SliceHeaderControls/index.tsx       |  46 +----
 .../FilterBar/CrossFilters/CrossFilter.tsx         |   4 +-
 .../FilterBar/CrossFilters/Vertical.tsx            |  10 +-
 .../FilterBar/CrossFilters/selectors.ts            |  46 +++--
 .../FilterBarSettings/FilterBarSettings.test.tsx   |   1 -
 .../FilterBar/FilterBarSettings/index.tsx          |   2 +-
 .../FilterBar/FilterControls/FilterControls.tsx    |  17 +-
 .../FilterBar/FiltersDropdownContent/index.tsx     |   3 +
 .../FiltersOutOfScopeCollapsible/index.tsx         |   3 +
 .../nativeFilters/FilterBar/Horizontal.tsx         |   9 +-
 .../components/nativeFilters/selectors.ts          |  98 ++++++----
 .../src/dashboard/containers/DashboardPage.tsx     |  13 +-
 superset-frontend/src/dashboard/types.ts           |   1 -
 .../src/dashboard/util/crossFilters.test.ts        | 207 ++++++++++++++++++++
 .../src/dashboard/util/crossFilters.ts             |  61 +++++-
 .../components/ControlPanelsContainer.test.tsx     |  39 ++++
 .../explore/components/ControlPanelsContainer.tsx  |   5 +-
 .../src/explore/components/SaveModal.tsx           |  54 +++---
 .../DndFilterSelect.test.tsx                       |   5 +-
 .../DndColumnSelectControl/DndFilterSelect.tsx     |   6 +-
 .../FilterControl/AdhocFilter/AdhocFilter.test.js  |   6 +-
 .../controls/FilterControl/AdhocFilter/index.js    |  51 +----
 .../AdhocFilterControl/AdhocFilterControl.test.jsx |   6 +-
 .../FilterControl/AdhocFilterControl/index.jsx     |   6 +-
 .../AdhocFilterEditPopover.test.jsx                |   6 +-
 .../FilterControl/AdhocFilterEditPopover/index.jsx |   5 +-
 ...AdhocFilterEditPopoverSimpleTabContent.test.tsx |   6 +-
 .../index.tsx                                      |   6 +-
 .../AdhocFilterEditPopoverSqlTabContent.test.jsx   |   6 +-
 .../AdhocFilterEditPopoverSqlTabContent/index.jsx  |   6 +-
 .../AdhocFilterOption/AdhocFilterOption.test.tsx   |   6 +-
 .../AdhocFilterPopoverTrigger.test.tsx             |   6 +-
 .../controls/FilterControl/adhocFilterType.js      |   2 +-
 .../components/controls/FilterControl/types.ts}    |  19 +-
 .../controls/FilterControl/utils/translateToSQL.ts |  76 ++++++++
 .../utils/useGetTimeRangeLabel.test.ts             |   3 +-
 .../FilterControl/utils/useGetTimeRangeLabel.tsx   |   3 +-
 .../getFormDataFromDashboardContext.test.ts        |  36 ++++
 .../getFormDataWithDashboardContext.ts             |  54 ++++--
 superset-frontend/src/filters/utils.ts             |   8 +-
 .../AlertReportList/AlertReportList.test.jsx}      |   2 +-
 .../AlertReportList/index.tsx}                     |   4 +-
 .../AllEntities/index.tsx}                         |   2 +-
 .../AnnotationLayerList.test.jsx}                  |   2 +-
 .../AnnotationLayerList/index.tsx}                 |   4 +-
 .../AnnotationList}/AnnotationList.test.jsx        |   2 +-
 .../AnnotationList/index.tsx}                      |   4 +-
 .../ExplorePage.tsx => pages/Chart/index.tsx}      |  14 +-
 .../src/pages/ChartCreation/index.tsx              |   8 +
 superset-frontend/src/pages/ChartList/index.tsx    |   2 +-
 .../CssTemplateList/CssTemplateList.test.jsx}      |   2 +-
 .../CssTemplateList/index.tsx}                     |   4 +-
 .../Dashboard/index.tsx}                           |   2 +-
 .../DashboardList}/DashboardList.test.jsx          |   2 +-
 .../DashboardList/index.tsx}                       |   4 +-
 .../DatabaseList}/DatabaseList.test.jsx            |   2 +-
 .../DatabaseList/index.tsx}                        |   5 +-
 .../DatasetCreation/DatasetCreation.test.tsx}      |   2 +-
 .../AddDataset => pages/DatasetCreation}/index.tsx |  18 +-
 .../DatasetList}/DatasetList.test.tsx              |   2 +-
 .../DatasetList/index.tsx}                         |   4 +-
 .../ExecutionLogList/ExecutionLogList.test.jsx}    |   2 +-
 .../ExecutionLogList/index.tsx}                    |   2 +-
 .../Welcome.test.tsx => pages/Home/Home.test.tsx}  |   2 +-
 .../welcome/Welcome.tsx => pages/Home/index.tsx}   |  10 +-
 .../QueryHistoryList/QueryHistoryList.test.tsx}    |   2 +-
 .../QueryHistoryList/index.tsx}                    |   2 +-
 .../SavedQueryList}/SavedQueryList.test.jsx        |   2 +-
 .../SavedQueryList/index.tsx}                      |   2 +-
 .../CRUD/tags/TagList.tsx => pages/Tags/index.tsx} |   4 +-
 .../ChartList => views/CRUD/chart}/ChartCard.tsx   |   0
 .../src/views/CRUD/welcome/ActivityTable.tsx       |   2 +-
 .../src/views/CRUD/welcome/ChartTable.tsx          |   4 +-
 .../src/views/CRUD/welcome/DashboardTable.tsx      |   2 +-
 .../src/views/CRUD/welcome/SavedQueries.tsx        |   2 +-
 superset-frontend/src/views/routes.test.tsx        |   4 +-
 superset-frontend/src/views/routes.tsx             | 114 ++++++-----
 superset-websocket/package-lock.json               | 186 +++++++++++++++---
 superset-websocket/package.json                    |   6 +-
 superset/common/query_actions.py                   |  26 ++-
 superset/common/query_context_processor.py         |   2 +
 superset/common/utils/query_cache_manager.py       |  19 +-
 superset/config.py                                 |  17 +-
 superset/connectors/sqla/models.py                 |  57 +++++-
 superset/dao/base.py                               |   4 +-
 superset/dashboards/dao.py                         |   6 +-
 superset/dashboards/schemas.py                     |   1 -
 superset/databases/commands/create.py              |  11 +-
 superset/db_engine_specs/base.py                   |  15 ++
 superset/db_engine_specs/mysql.py                  |   1 +
 superset/db_engine_specs/trino.py                  |   1 +
 .../configs/charts/Video_Game_Sales_Filter.yaml    |   2 +-
 .../dashboards/COVID_Vaccine_Dashboard.yaml        |   6 +-
 .../dashboards/FCC_New_Coder_Survey_2018.yaml      |   4 +-
 .../configs/dashboards/Sales_Dashboard.yaml        |   6 +-
 .../configs/dashboards/Video_Game_Sales.yaml       |  10 +-
 superset/exceptions.py                             |   4 +
 superset/initialization/__init__.py                |  18 +-
 ...4-46_c0a3ea245b61_remove_show_native_filters.py |  66 +++++++
 ...ac08bb5b83_invert_horizontal_bar_chart_order.py | 126 ++++++++++++
 superset/models/core.py                            |   2 +
 superset/models/helpers.py                         |   7 +-
 superset/sqllab/commands/estimate.py               |  10 +-
 superset/utils/core.py                             |   4 +-
 superset/utils/webdriver.py                        |  73 ++++---
 superset/views/base.py                             |  13 +-
 superset/views/core.py                             |  49 ++---
 superset/viz.py                                    |  33 ++--
 tests/integration_tests/charts/api_tests.py        |  18 +-
 tests/integration_tests/charts/data/api_tests.py   |  34 ++++
 tests/unit_tests/db_engine_specs/test_mysql.py     |  20 ++
 tests/unit_tests/fixtures/assets_configs.py        |   2 -
 175 files changed, 2382 insertions(+), 1572 deletions(-)
 rename superset-frontend/{src/dashboard/components/CrossFilterScopingModal/utils/utils.test.ts => packages/superset-ui-chart-controls/src/operators/utils/extractExtraMetrics.ts} (61%)
 create mode 100644 superset-frontend/packages/superset-ui-chart-controls/test/operators/utils/extractExtraMetrics.test.ts
 copy superset-frontend/{src/dashboard/components/CrossFilterScopingModal/types.ts => packages/superset-ui-core/src/time-format/utils/normalizeTimestamp.ts} (75%)
 rename superset-frontend/{src/dashboard/components/CrossFilterScopingModal/types.ts => packages/superset-ui-core/src/utils/getSelectedText.ts} (86%)
 copy superset-frontend/{src/views/routes.test.tsx => packages/superset-ui-core/test/components/SafeMarkdown.test.ts} (54%)
 create mode 100644 superset-frontend/packages/superset-ui-core/test/time-format/utils/normalizeTimestamp.test.ts
 copy superset-frontend/{src/dashboard/components/CrossFilterScopingModal/utils/index.ts => packages/superset-ui-core/test/utils/getSelectedText.test.ts} (60%)
 delete mode 100644 superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
 delete mode 100644 superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/index.tsx
 delete mode 100644 superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingModal.tsx
 create mode 100644 superset-frontend/src/dashboard/util/crossFilters.test.ts
 rename superset-frontend/src/{dashboard/components/CrossFilterScopingModal/utils/index.ts => explore/components/controls/FilterControl/types.ts} (76%)
 create mode 100644 superset-frontend/src/explore/components/controls/FilterControl/utils/translateToSQL.ts
 rename superset-frontend/src/{views/CRUD/alert/AlertList.test.jsx => pages/AlertReportList/AlertReportList.test.jsx} (98%)
 rename superset-frontend/src/{views/CRUD/alert/AlertList.tsx => pages/AlertReportList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/allentities/AllEntities.tsx => pages/AllEntities/index.tsx} (97%)
 rename superset-frontend/src/{views/CRUD/annotationlayers/AnnotationLayersList.test.jsx => pages/AnnotationLayerList/AnnotationLayerList.test.jsx} (98%)
 rename superset-frontend/src/{views/CRUD/annotationlayers/AnnotationLayersList.tsx => pages/AnnotationLayerList/index.tsx} (98%)
 rename superset-frontend/src/{views/CRUD/annotation => pages/AnnotationList}/AnnotationList.test.jsx (98%)
 rename superset-frontend/src/{views/CRUD/annotation/AnnotationList.tsx => pages/AnnotationList/index.tsx} (98%)
 rename superset-frontend/src/{explore/ExplorePage.tsx => pages/Chart/index.tsx} (89%)
 rename superset-frontend/src/{views/CRUD/csstemplates/CssTemplatesList.test.jsx => pages/CssTemplateList/CssTemplateList.test.jsx} (98%)
 rename superset-frontend/src/{views/CRUD/csstemplates/CssTemplatesList.tsx => pages/CssTemplateList/index.tsx} (98%)
 rename superset-frontend/src/{dashboard/containers/DashboardRoute.tsx => pages/Dashboard/index.tsx} (93%)
 rename superset-frontend/src/{views/CRUD/dashboard => pages/DashboardList}/DashboardList.test.jsx (99%)
 rename superset-frontend/src/{views/CRUD/dashboard/DashboardList.tsx => pages/DashboardList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/data/database => pages/DatabaseList}/DatabaseList.test.jsx (99%)
 rename superset-frontend/src/{views/CRUD/data/database/DatabaseList.tsx => pages/DatabaseList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx => pages/DatasetCreation/DatasetCreation.test.tsx} (96%)
 rename superset-frontend/src/{views/CRUD/data/dataset/AddDataset => pages/DatasetCreation}/index.tsx (86%)
 rename superset-frontend/src/{views/CRUD/data/dataset => pages/DatasetList}/DatasetList.test.tsx (99%)
 rename superset-frontend/src/{views/CRUD/data/dataset/DatasetList.tsx => pages/DatasetList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/alert/ExecutionLog.test.jsx => pages/ExecutionLogList/ExecutionLogList.test.jsx} (98%)
 rename superset-frontend/src/{views/CRUD/alert/ExecutionLog.tsx => pages/ExecutionLogList/index.tsx} (98%)
 rename superset-frontend/src/{views/CRUD/welcome/Welcome.test.tsx => pages/Home/Home.test.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/welcome/Welcome.tsx => pages/Home/index.tsx} (97%)
 rename superset-frontend/src/{views/CRUD/data/query/QueryList.test.tsx => pages/QueryHistoryList/QueryHistoryList.test.tsx} (98%)
 rename superset-frontend/src/{views/CRUD/data/query/QueryList.tsx => pages/QueryHistoryList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/data/savedquery => pages/SavedQueryList}/SavedQueryList.test.jsx (99%)
 rename superset-frontend/src/{views/CRUD/data/savedquery/SavedQueryList.tsx => pages/SavedQueryList/index.tsx} (99%)
 rename superset-frontend/src/{views/CRUD/tags/TagList.tsx => pages/Tags/index.tsx} (99%)
 rename superset-frontend/src/{pages/ChartList => views/CRUD/chart}/ChartCard.tsx (100%)
 create mode 100644 superset/migrations/versions/2023-02-28_14-46_c0a3ea245b61_remove_show_native_filters.py
 create mode 100644 superset/migrations/versions/2023-03-05_10-06_d0ac08bb5b83_invert_horizontal_bar_chart_order.py