You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by jk...@apache.org on 2022/06/14 17:04:05 UTC
[unomi] branch master updated: UNOMI-596: add missing property accessor for making condition working on flattenedProperties (#439)
This is an automated email from the ASF dual-hosted git repository.
jkevan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/unomi.git
The following commit(s) were added to refs/heads/master by this push:
new 01bf2ea9a UNOMI-596: add missing property accessor for making condition working on flattenedProperties (#439)
01bf2ea9a is described below
commit 01bf2ea9a3e22c7d2a6677bd5c334a6026665d8e
Author: kevan Jahanshahi <ke...@jahia.com>
AuthorDate: Tue Jun 14 19:04:00 2022 +0200
UNOMI-596: add missing property accessor for making condition working on flattenedProperties (#439)
---
.../plugins/baseplugin/conditions/accessors/EventAccessor.java | 3 +++
.../baseplugin/conditions/PropertyConditionEvaluatorTest.java | 7 +++++++
2 files changed, 10 insertions(+)
diff --git a/plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/accessors/EventAccessor.java b/plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/accessors/EventAccessor.java
index ba10bd98f..e8c53d0e4 100644
--- a/plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/accessors/EventAccessor.java
+++ b/plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/accessors/EventAccessor.java
@@ -30,6 +30,9 @@ public class EventAccessor extends HardcodedPropertyAccessor<Event> {
if ("properties".equals(propertyName)) {
return registry.getProperty(object.getProperties(), leftoverExpression);
}
+ if ("flattenedProperties".equals(propertyName)) {
+ return registry.getProperty(object.getFlattenedProperties(), leftoverExpression);
+ }
if ("eventType".equals(propertyName)) {
return object.getEventType();
}
diff --git a/plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluatorTest.java b/plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluatorTest.java
index a236d4f72..84eeae38a 100644
--- a/plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluatorTest.java
+++ b/plugins/baseplugin/src/test/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluatorTest.java
@@ -103,6 +103,13 @@ public class PropertyConditionEvaluatorTest {
}
+ @Test
+ public void testFlattenedProperties() {
+ Event mockEvent = generateMockEvent(mockProfile, mockSession);
+ mockEvent.getFlattenedProperties().put("test", "test");
+ assertEquals("FlattenedProperties should be readable form accessor", "test", propertyConditionEvaluator.getHardcodedPropertyValue(mockEvent, "flattenedProperties.test"));
+ }
+
@Test
public void testOGNLEvaluator() throws Exception {
Event mockEvent = generateMockEvent(mockProfile, mockSession);