You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "David Jencks (JIRA)" <ji...@codehaus.org> on 2009/05/28 00:28:42 UTC
[jira] Created: (MSHADE-51) shade plugin relocate does not play
well with maven-bundle-plugin
shade plugin relocate does not play well with maven-bundle-plugin
-----------------------------------------------------------------
Key: MSHADE-51
URL: http://jira.codehaus.org/browse/MSHADE-51
Project: Maven 2.x Shade Plugin
Issue Type: Bug
Affects Versions: 1.2.1
Reporter: David Jencks
maven-bundle-plugin (from felix) v. 2.0.0
If your build runs shade to relocate some classes from a preexisting jar and the maven-bundle-plugin to geinerate osgi metadata the bundle plugin refuses to generate any Export-Package, Import-Package or Private-Package headers. I assume it doesn't find any classes.
I don't know whose fault this is.
To see this in action check out https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-asm-shaded rev 778992 and uncomment the bundle plugin and comment the transformers section of the shade plugin config.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHADE-51) shade plugin relocate does not play well
with maven-bundle-plugin
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MSHADE-51.
-----------------------------------
Resolution: Not A Bug
Assignee: Benjamin Bentmann
Log output from the xbean-asm-shaded project:
{noformat}
...
[INFO] [bundle:bundle {execution: default-bundle}]
[WARNING] Warning building bundle org.apache.xbean:xbean-asm-shaded:bundle:3.6-SNAPSHOT :
Instructions in Export-Package that are never used: org\.apache\.xbean\.asm
[WARNING] Warning building bundle org.apache.xbean:xbean-asm-shaded:bundle:3.6-SNAPSHOT :
Superfluous export-package instructions: [org.apache.xbean.asm]
[INFO] [shade:shade {execution: default}]
[INFO] Including asm:asm:jar:3.1 in the shaded jar.
[INFO] Including asm:asm-commons:jar:3.1 in the shaded jar.
[INFO] Including asm:asm-tree:jar:3.1 in the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
...
{noformat}
i.e. the Bundle Plugin runs before the Shade Plugin has a chance to participate in the build.
Approach 1) outlined by Stuart in FELIX-1184 seems to be the easiest way if the manifest should be generated (mostly) by the Bundle Plugin. This way, the configuration of the {{ManifestResourceTransformer}} for Shade could be trimmed down to just the package entries to fix the manifest.
> shade plugin relocate does not play well with maven-bundle-plugin
> -----------------------------------------------------------------
>
> Key: MSHADE-51
> URL: http://jira.codehaus.org/browse/MSHADE-51
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.2.1
> Reporter: David Jencks
> Assignee: Benjamin Bentmann
>
> maven-bundle-plugin (from felix) v. 2.0.0
> If your build runs shade to relocate some classes from a preexisting jar and the maven-bundle-plugin to geinerate osgi metadata the bundle plugin refuses to generate any Export-Package, Import-Package or Private-Package headers. I assume it doesn't find any classes.
> I don't know whose fault this is.
> To see this in action check out https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-asm-shaded rev 778992 and uncomment the bundle plugin and comment the transformers section of the shade plugin config.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-51) shade plugin relocate does not play
well with maven-bundle-plugin
Posted by "David Jencks (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=178309#action_178309 ]
David Jencks commented on MSHADE-51:
------------------------------------
Also reported as https://issues.apache.org/jira/browse/FELIX-1184
> shade plugin relocate does not play well with maven-bundle-plugin
> -----------------------------------------------------------------
>
> Key: MSHADE-51
> URL: http://jira.codehaus.org/browse/MSHADE-51
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.2.1
> Reporter: David Jencks
>
> maven-bundle-plugin (from felix) v. 2.0.0
> If your build runs shade to relocate some classes from a preexisting jar and the maven-bundle-plugin to geinerate osgi metadata the bundle plugin refuses to generate any Export-Package, Import-Package or Private-Package headers. I assume it doesn't find any classes.
> I don't know whose fault this is.
> To see this in action check out https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-asm-shaded rev 778992 and uncomment the bundle plugin and comment the transformers section of the shade plugin config.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira