You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 03:49:39 UTC
[jira] [Created] (TS-1040) PATCH: teach TSHostLookup to use const
PATCH: teach TSHostLookup to use const
--------------------------------------
Key: TS-1040
URL: https://issues.apache.org/jira/browse/TS-1040
Project: Traffic Server
Issue Type: Improvement
Components: DNS
Reporter: James Peach
Priority: Minor
This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
The new prototype is:
tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1040:
----------------------------
Attachment: 0002-TSHostLookup-should-take-const-hostname-argument.patch
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Priority: Minor
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166334#comment-13166334 ]
James Peach commented on TS-1040:
---------------------------------
Yep I meant to click the donate button but forgot. I didn't see a way to toggle it after the fact. Do you need me to attach it again?
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Priority: Minor
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1040:
------------------------------
Fix Version/s: 3.1.2
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166046#comment-13166046 ]
Igor Galić commented on TS-1040:
--------------------------------
+1 from me on that one, but I'll leave it to zwoop to decide.
Sidenote: This patch was not donated to the ASF. - Was that on purpose, or just an accident?
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Priority: Minor
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "James Peach (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-1040:
-------------------------------
Assignee: Leif Hedstrom
Leif, can you please review and commit if it looks ok?
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1040) PATCH: teach TSHostLookup to use const
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169257#comment-13169257 ]
Igor Galić commented on TS-1040:
--------------------------------
I myself haven't figured out how to do that yet, even when I re-uploaded it ended up being the same.
Zoe somehow managed to get it right in: TS-1026
But, I will take your word for it in the comments. (Yes, this should really be a toggle option, I've seen enough people accidentally hit that button in other Jiras)
> PATCH: teach TSHostLookup to use const
> --------------------------------------
>
> Key: TS-1040
> URL: https://issues.apache.org/jira/browse/TS-1040
> Project: Traffic Server
> Issue Type: Improvement
> Components: DNS
> Reporter: James Peach
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0002-TSHostLookup-should-take-const-hostname-argument.patch
>
>
> This patch improves the TSHostLookup() API by specifying it's hostname argument as const. This reduces the number of casts required of plugin authors.
> The new prototype is:
> tsapi TSAction TSHostLookup(TSCont contp, const char* hostname, size_t namelen)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira