You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ashish Paliwal <pa...@gmail.com> on 2013/12/05 02:57:51 UTC

Review Request 16031: Patch for FLUME-2209

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16031/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2209
    https://issues.apache.org/jira/browse/FLUME-2209


Repository: flume-git


Description
-------

Fix for AsyncHBaseSink will never recover if the column family does not exists for the first start.

In case of an Exception, the AsyncHBase Client is shutdown, so that the state is proper when LifecycleSupervisor calls the start() again


Diffs
-----

  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0545554 

Diff: https://reviews.apache.org/r/16031/diff/


Testing
-------

Not added for this specific case. Test Case already exist for Missing table case.


Thanks,

Ashish Paliwal


Re: Review Request 16031: Patch for FLUME-2209

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16031/#review30072
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On Dec. 5, 2013, 1:57 a.m., Ashish Paliwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16031/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 1:57 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2209
>     https://issues.apache.org/jira/browse/FLUME-2209
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Fix for AsyncHBaseSink will never recover if the column family does not exists for the first start.
> 
> In case of an Exception, the AsyncHBase Client is shutdown, so that the state is proper when LifecycleSupervisor calls the start() again
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0545554 
> 
> Diff: https://reviews.apache.org/r/16031/diff/
> 
> 
> Testing
> -------
> 
> Not added for this specific case. Test Case already exist for Missing table case.
> 
> 
> Thanks,
> 
> Ashish Paliwal
> 
>