You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/03/28 05:39:34 UTC

[GitHub] zeppelin pull request #2197: ZEPPELIN-2324. Add property zeppelin.spark.unSu...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2197

    ZEPPELIN-2324. Add property zeppelin.spark.unSupportedVersionCheck for trying new spark version

    ### What is this PR for?
    For now, every time when I want to try new spark version, I have to change file SparkVersion and rebuild it. It is not so convenient, so I'd like to add property zeppelin.spark.unSupportedVersionCheck for spark interpreter. So that I can try new spark version by setting this property as false, of course it is only for zeppelin developer.
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2324
    
    ### How should this be tested?
    Verify it in spark master
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2324

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2197
    
----
commit 94b12a723237143c549df26c7eae999619319352
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-03-28T05:38:08Z

    ZEPPELIN-2324. Add property zeppelin.spark.unSupportedVersionCheck for trying new spark version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2197: ZEPPELIN-2324. Add property zeppelin.spark.unSupported...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2197
  
    @Leemoonsoo @jongyoul  @felixcheung Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2197: ZEPPELIN-2324. Add property zeppelin.spark.unSupported...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2197
  
    > perhaps it should be changed in sparkInterpreter.getSparkVersion().isSupportedVersion() instead
    
    I thought about it, but feel it is not proper to create a new member field in class SparkVersion as this is a interpreter level property, even it is not proper to me to create a static field in SparkVersion. So in the new PR, I create a new method `isUnSupportedSparkVersion` in `SparkInterpreter` to wrap all the logic. 
    
    > Can you add testcase for this conf?
    I didn't find an easy way for this test. So just manually verified it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2197: ZEPPELIN-2324. Add property zeppelin.spark.enab...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2197: ZEPPELIN-2324. Add property zeppelin.spark.enableSuppo...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2197
  
    Will merge it if no more discussion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---