You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/23 04:14:48 UTC
[GitHub] spark pull request #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20357
[SPARK-23186][SQL] Loading JDBC Drivers should be synchronized
## What changes were proposed in this pull request?
Since some JDBC Drivers have class initialization code to call `DriverManager`, we need to synchronize them to avoid potential executor-side deadlock situations like [STORM-2527](https://issues.apache.org/jira/browse/STORM-2527).
## How was this patch tested?
This only extends the coverage of synchronized block from a part to the whole function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-23186
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20357
----
commit f8c3eac6ddfdb94e1e5153da64dcfb706e191ba8
Author: Dongjoon Hyun <do...@...>
Date: 2018-01-23T04:11:01Z
[SPARK-23186][SQL] Loading JDBC Drivers should be synchronized
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/20357
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/121/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20357
**[Test build #86509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86509/testReport)** for PR 20357 at commit [`f8c3eac`](https://github.com/apache/spark/commit/f8c3eac6ddfdb94e1e5153da64dcfb706e191ba8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Initialize DriverManager first before...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20357
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Initialize DriverManager first before...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20357
**[Test build #86509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86509/testReport)** for PR 20357 at commit [`f8c3eac`](https://github.com/apache/spark/commit/f8c3eac6ddfdb94e1e5153da64dcfb706e191ba8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Initialize DriverManager first before...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86509/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20357: [SPARK-23186][SQL] Loading JDBC Drivers should be synchr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20357
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org