You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/03 21:29:41 UTC

[GitHub] aaronmarkham commented on a change in pull request #13364: [MXNET-1225] Always use config.mk in make install instructions

aaronmarkham commented on a change in pull request #13364: [MXNET-1225] Always use config.mk in make install instructions
URL: https://github.com/apache/incubator-mxnet/pull/13364#discussion_r238443417
 
 

 ##########
 File path: docs/install/ubuntu_setup.md
 ##########
 @@ -165,23 +165,34 @@ If building on CPU and using OpenBLAS:
 ```bash
     git clone --recursive https://github.com/apache/incubator-mxnet.git
     cd incubator-mxnet
-    make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas
+    echo "USE_OPENCV = 1" >> ./config.mk
+    echo "USE_BLAS = openblas" >> ./config.mk
+    make -j $(nproc)
 
 Review comment:
   Can you make this cmake instead? That way we're consistent throughout?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services