[jira] [Comment Edited] (SOLR-7888) Make Lucene's AnalyzingInfixSuggester.lookup() method that takes a BooleanQuery filter parameter available in Solr

["Arcadius Ahouansou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737621#comment-14737621 ] 

Arcadius Ahouansou edited comment on SOLR-7888 at 9/9/15 10:21 PM:
-------------------------------------------------------------------

Hello [~dsmiley] 
Thank you very much for your comment.

- I could change the parameter to {{suggest.fq}} if [~janhoy] and others are OK with that. For now, filtering is happening only on the {{context}} field, that is why {{cfq}} was chosen. But maybe in the future, we may have filtering on any arbitrary field in which case {{suggest.fq}} may make more sense? Are you OK [~janhoy] for me to change to fq?

- About SOLR-7963 , yes it could be included here. From first glance, it looks like a 1-liner, but it's not. Please look at my comment above. Or maybe am I missing something? Any contribution would be well appreciated. Note that there is an ignored failing test {{testLocalTermsQuery()}} for SOLR-7963 in the current patch
I found it easier and more manageable to have it as an additional feature in a separate ticket. I wanted to start working on that as soon as this one is committed so that they could go into the very same release.
I would be more than happy if  [~dsmiley]  wants to help with SOLR-7963
Thanks.


was (Author: arcadius):
Hello [~dsmiley] 
Thank you very much for your comment.

- I could change the parameter to {{suggest.fq}} if [~janhoy] and others are OK with that. For now, filtering is happening only on the {{context}} field, that is why {{cfq}} was chosen. But maybe in the future, we may have filtering on any arbitrary field in which case {{suggest.fq}} may make more sense?

- About SOLR-7963 , yes it could be included here. From first glance, it looks like a 1-liner, but it's not. Please look at my comment above. Or maybe am I missing something? I found it easier and more manageable to have it as an additional feature in a separate ticket. Any contribution would be well appreciated. Note that there is an ignored failing test {{testLocalTermsQuery()}} for SOLR-7963 in the current patch 
 

> Make Lucene's AnalyzingInfixSuggester.lookup() method that takes a BooleanQuery filter parameter available in Solr
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7888
>                 URL: https://issues.apache.org/jira/browse/SOLR-7888
>             Project: Solr
>          Issue Type: New Feature
>          Components: Suggester
>    Affects Versions: 5.2.1
>            Reporter: Arcadius Ahouansou
>            Assignee: Jan Høydahl
>             Fix For: 5.4
>
>         Attachments: SOLR-7888.patch, SOLR-7888.patch, SOLR-7888.patch, SOLR-7888.patch, SOLR-7888.patch, SOLR-7888.patch
>
>
>  LUCENE-6464 has introduced a very flexible lookup method that takes as parameter a BooleanQuery that is used for filtering results.
> This ticket is to expose that method to Solr.
> This would allow user to do:
> {code}
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:tennis
> /suggest?suggest=true&suggest.build=true&suggest.q=term&suggest.contextFilterQuery=contexts:golf AND contexts:football
> {code}
> etc
> Given that the context filtering in currently only implemented by the {code}AnalyzingInfixSuggester{code} and by the {code}BlendedInfixSuggester{code}, this initial implementation will support only these 2 lookup implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org