You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/29 17:57:52 UTC
[GitHub] [spark] ueshin commented on a change in pull request #33570: [WIP][SPARK-36338][PYTHON][SQL] Move distributed-sequence implementation to Scala side
ueshin commented on a change in pull request #33570:
URL: https://github.com/apache/spark/pull/33570#discussion_r679342981
##########
File path: python/pyspark/pandas/internal.py
##########
@@ -658,7 +654,7 @@ def __init__(
data_fields = [
field.copy(
name=name_like_string(struct_field.name),
- nullable=(force_nullable or field.nullable),
+ nullable=field.nullable,
Review comment:
We can remove this? The new `nullable` will be reused from the original `field`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org