You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "mlibbey (via GitHub)" <gi...@apache.org> on 2025/06/12 23:27:36 UTC
[PR] Add some more hrw4u help [trafficserver]
mlibbey opened a new pull request, #12286:
URL: https://github.com/apache/trafficserver/pull/12286
Added a missing python requirement, and a few more steps to get hrw4u to build for the first time.
Also included a few more doc hints on usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more hrw4u help [trafficserver]
Posted by "mlibbey (via GitHub)" <gi...@apache.org>.
mlibbey merged PR #12286:
URL: https://github.com/apache/trafficserver/pull/12286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more hrw4u help [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #12286:
URL: https://github.com/apache/trafficserver/pull/12286#discussion_r2144096099
##########
tools/hrw4u/bootstrap.sh:
##########
@@ -20,12 +20,22 @@ set -e
VENV_NAME="hrw4u"
+if ! which antlr; then
Review Comment:
Does this work? Don't you have to put that into backticks or $() at least ?
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -220,6 +225,13 @@ set-debug set-debug() Enables ATS txn debug
skip-remap skip-remap() Skip remap processing (open proxy)
================= ============================ ================================
+String concatenations
+---------------------
+
+You can concatenate values using strings, condition values and variable expansions on the same line in
+operators using. For instance, `outbound.req.CustomHeader “Hello from {inbound.ip}:{inbound.port}”`. As
+a result, the set-redirect's `[QSA]` flag would be implemented as `set-redirect(302, "https://...{inbound.url.query}")``
Review Comment:
Maybe make sure the ? is here? I'm not sure if ATS's query value includes the ? or not... I want to say not but I can test tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more hrw4u help [trafficserver]
Posted by "mlibbey (via GitHub)" <gi...@apache.org>.
mlibbey commented on code in PR #12286:
URL: https://github.com/apache/trafficserver/pull/12286#discussion_r2145904367
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -220,6 +225,13 @@ set-debug set-debug() Enables ATS txn debug
skip-remap skip-remap() Skip remap processing (open proxy)
================= ============================ ================================
+String concatenations
+---------------------
+
+You can concatenate values using strings, condition values and variable expansions on the same line in
+operators using. For instance, `outbound.req.CustomHeader “Hello from {inbound.ip}:{inbound.port}”`. As
+a result, the set-redirect's `[QSA]` flag would be implemented as `set-redirect(302, "https://...{inbound.url.query}")``
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more hrw4u help [trafficserver]
Posted by "mlibbey (via GitHub)" <gi...@apache.org>.
mlibbey commented on code in PR #12286:
URL: https://github.com/apache/trafficserver/pull/12286#discussion_r2145896679
##########
tools/hrw4u/bootstrap.sh:
##########
@@ -20,12 +20,22 @@ set -e
VENV_NAME="hrw4u"
+if ! which antlr; then
Review Comment:
I got the
if ! command; from
https://www.shellcheck.net/ -- the PR passes shellcheck without issues. When I replace `which antlr` with `which sldkjcdslkfjsdlfkj` I get the echos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org