You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2021/02/17 22:59:00 UTC

[jira] [Commented] (SOLR-13034) RealTimeGetComponent#toSolrDoc should be able to resolve LazyFields

    [ https://issues.apache.org/jira/browse/SOLR-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286188#comment-17286188 ] 

David Smiley commented on SOLR-13034:
-------------------------------------

[~moshebla] are you sure the issue was with {{toSolrDoc}} and not {{toSolrInputDocument}}?  On one hand it seems you really did mean what you said because you refer to the one accepting a Lucene {{Document}}.  However, {{toSolrDoc}} protects against the possibility of LazyField values via the call to materialize(...), and was doing so before you even filed this issue (I checked via git history carefully).  It did this starting in SOLR-10286.  Maybe you were using an older Solr release?

{{toSolrInputDocument}} does not have this protection, and is vulnerable to what you describe.  If I were to replace where you said one with the other, it would match a bug I've been able to reproduce that was reported by a user.  Consequently, I'm tempted to edit this issue accordingly, instead of filing a new issue.  WDYT?

> RealTimeGetComponent#toSolrDoc should be able to resolve LazyFields
> -------------------------------------------------------------------
>
>                 Key: SOLR-13034
>                 URL: https://issues.apache.org/jira/browse/SOLR-13034
>             Project: Solr
>          Issue Type: Bug
>            Reporter: mosh
>            Assignee: mosh
>            Priority: Major
>              Labels: RealTimeGet
>
> As I was working on SOLR-12638, I noticed RealTimgeGetComponent#toSolrDoc does not resolve lazy fields. 
>  This behavior is cause by the use of transformers which use SolrDocumentFetcher, which caused exceptions to be thrown when said input documents were written to the transaction log(TransactionLog:100).
>  IMO, These fields ought to be resolved by the RealTimgeGetComponent#toSolrDoc method, which takes a Document as an input(which may contain LazyFields) and returns a SolrInputDocument representation of said SolrDocument.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org