You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/27 20:32:22 UTC
[kudu-CR] python: pin to cython 0.26.1
Hello Jean-Daniel Cryans, Wes McKinney,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8155
to review the following change.
Change subject: python: pin to cython 0.26.1
......................................................................
python: pin to cython 0.26.1
Some of our el6-based builds are running into an installation issue [1] that
appears to have surfaced in Cython 0.27. We don't actually need any features
from recent Cython releases, so let's pin to the last one known to be good.
1. https://github.com/cython/cython/issues/1879
Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
---
M python/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/8155/1
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
[kudu-CR] python: pin to cython 0.26.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
python: pin to cython 0.26.1
Some of our el6-based builds are running into an installation issue [1] that
appears to have surfaced in Cython 0.27. We don't actually need any features
from recent Cython releases, so let's pin to the last one known to be good.
1. https://github.com/cython/cython/issues/1879
Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Reviewed-on: http://gerrit.cloudera.org:8080/8155
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M python/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
[kudu-CR] python: pin to cython 0.26.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Should we backport this to past branches so that we can build older python clients still?
Probably a good idea, yes. I can set them up; what branches would you recommend?
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 16:26:42 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin to cython 0.26.1
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
Patch Set 2:
Perhaps 1.3.x, 1.4.x, and 1.5.x, assuming they all cherry-pick cleanly? we don't really have a formal policy yet of how many previous release branches we actively backport to, but I think two or three is reasonable especially when the backport is trivial.
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 17:12:13 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin to cython 0.26.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2017 20:32:57 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin to cython 0.26.1
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
Patch Set 2:
Should we backport this to past branches so that we can build older python clients still?
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 15:33:01 +0000
Gerrit-HasComments: No
[kudu-CR] python: pin to cython 0.26.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 )
Change subject: python: pin to cython 0.26.1
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Perhaps 1.3.x, 1.4.x, and 1.5.x, assuming they all cherry-pick cleanly? we don't really have a formal policy yet of how many previous release branches we actively backport to, but I think two or three is reasonable especially when the backport is trivial.
OK, done for all three.
--
To view, visit http://gerrit.cloudera.org:8080/8155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4c078ff1308f267f73275f7cacb35161a2d3
Gerrit-Change-Number: 8155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Wes McKinney <we...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 17:32:01 +0000
Gerrit-HasComments: No