You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AlexanderShoshin <gi...@git.apache.org> on 2017/04/28 16:02:46 UTC
[GitHub] zeppelin pull request #2300: [ZEPPELIN-2467] Restoring second travis job fun...
GitHub user AlexanderShoshin opened a pull request:
https://github.com/apache/zeppelin/pull/2300
[ZEPPELIN-2467] Restoring second travis job functionality
### What is this PR for?
Second travis job didn't work correctly. It suppose to test all core unit tests plus integration test (except for spark related test) but it was doing nothing.
It was because of the exclamation mark in **-Dtest** property:
```
-Dtest='!ZeppelinSparkClusterTest,!org.apache.zeppelin.spark.*'
```
which is not supported by maven-surefire-plugin of version 2.17 (which is used in Zeppelin). Exclamation mark is supported started from 2.19 but still does not work properly.
I've added plugin **exclude** configuratin instead of **-Dtest** property.
After travis job was restored I had found that not all core tests worked properly. I have excluded them from the travis job for now and created jira issues:
https://issues.apache.org/jira/browse/ZEPPELIN-2469
https://issues.apache.org/jira/browse/ZEPPELIN-2470
https://issues.apache.org/jira/browse/ZEPPELIN-2471
https://issues.apache.org/jira/browse/ZEPPELIN-2473
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
[ZEPPELIN-2467](https://issues.apache.org/jira/browse/ZEPPELIN-2467)
### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexanderShoshin/zeppelin ZEPPELIN-2467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2300
----
commit 0448c4ae7950374034c864c7ba6d4855f5ab25e8
Author: Alexander Shoshin <al...@epam.com>
Date: 2017-04-28T13:18:15Z
added ability to exclude some unit tests using command line
commit dfa332f0387232ee8bd06a9e9cb1fe3fec87c06f
Author: Alexander Shoshin <al...@epam.com>
Date: 2017-04-28T13:22:08Z
changed -Dtest flag to -Dtests.to.exclude and excluded unstable tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2300
Travis build green. https://travis-ci.org/AlexanderShoshin/zeppelin/builds/228261473
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2300
Thanks for your opinion. Then I'll revert it. Please reopen this PR and rebase it from current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2300
even though CI is green in this PR, it seems that wasn't rebased recently. As a result CI is failing only in the second travis JOB. @AlexanderShoshin Could you check that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2300
@AlexanderShoshin After merging this PR, we continued to got failed in CI. Can you handle it urgently? If it took some times, it would be better to revert this commit and merge it after fixing it. How do you think of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2300
I think we should revert this commit then. I won't be able to fix it fast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2300: [ZEPPELIN-2467] Restoring second travis job fun...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2300
According to @Leemoonsoo suggestion I have added a comment for the travis job configuration about excluded tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---