You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/09 05:34:14 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #4959: arm/cortex-m: enhance the crash dump
anchao opened a new pull request #4959:
URL: https://github.com/apache/incubator-nuttx/pull/4959
## Summary
arm/cortex-m: enhance the crash dump
1. add irq stack information to list
2. add cpu loading into list
before:
```
Idle Task: PID=0 PRI=0 Stack Used=512 of 3048
hpwork: PID=1 PRI=224 Stack Used=304 of 2016
lpwork: PID=2 PRI=100 Stack Used=304 of 2016
rptun: PID=4 PRI=224 Stack Used=856 of 2008
```
after:
```
[ EMERG] [ap] up_showtasks: PID PRI USED STACK FILLED CPU COMMAND
[ EMERG] [ap] up_showtasks: ---- ---- 928 2048 45.3% ---- irq
[ EMERG] [ap] up_dump_task: 0 0 512 3048 16.7% 99.4% Idle Task
[ EMERG] [ap] up_dump_task: 1 224 304 2016 15.0% 0.0% hpwork
[ EMERG] [ap] up_dump_task: 2 100 304 2016 15.0% 0.0% lpwork
[ EMERG] [ap] up_dump_task: 4 224 856 2008 42.6% 0.0% rptun
```
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
N/A
## Testing
```
[ EMERG] [ap] up_showtasks: PID PRI USED STACK FILLED CPU COMMAND
[ EMERG] [ap] up_showtasks: ---- ---- 928 2048 45.3% ---- irq
[ EMERG] [ap] up_dump_task: 0 0 512 3048 16.7% 99.4% Idle Task
[ EMERG] [ap] up_dump_task: 1 224 304 2016 15.0% 0.0% hpwork
[ EMERG] [ap] up_dump_task: 2 100 304 2016 15.0% 0.0% lpwork
[ EMERG] [ap] up_dump_task: 4 224 856 2008 42.6% 0.0% rptun
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4959: arm/cortex-m: enhance the crash dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4959:
URL: https://github.com/apache/incubator-nuttx/pull/4959#discussion_r765486622
##########
File path: arch/arm/src/armv7-m/arm_assert.c
##########
@@ -137,54 +137,162 @@ static inline void up_registerdump(FAR volatile uint32_t *regs)
* Name: up_taskdump
****************************************************************************/
-#if defined(CONFIG_STACK_COLORATION) || defined(CONFIG_SCHED_BACKTRACE)
-static void up_taskdump(FAR struct tcb_s *tcb, FAR void *arg)
+static void up_dump_task(FAR struct tcb_s *tcb, FAR void *arg)
Review comment:
let's update other arm variant and arch too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4959: arm/cortex-m: enhance the crash dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4959:
URL: https://github.com/apache/incubator-nuttx/pull/4959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4959: arm/cortex-m: enhance the crash dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4959:
URL: https://github.com/apache/incubator-nuttx/pull/4959#discussion_r767394009
##########
File path: arch/arm/src/armv7-m/arm_assert.c
##########
@@ -137,54 +137,162 @@ static inline void up_registerdump(FAR volatile uint32_t *regs)
* Name: up_taskdump
****************************************************************************/
-#if defined(CONFIG_STACK_COLORATION) || defined(CONFIG_SCHED_BACKTRACE)
-static void up_taskdump(FAR struct tcb_s *tcb, FAR void *arg)
+static void up_dump_task(FAR struct tcb_s *tcb, FAR void *arg)
Review comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4959: arm/cortex-m: enhance the crash dump
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #4959:
URL: https://github.com/apache/incubator-nuttx/pull/4959#discussion_r767384943
##########
File path: arch/arm/src/armv7-m/arm_assert.c
##########
@@ -137,54 +137,162 @@ static inline void up_registerdump(FAR volatile uint32_t *regs)
* Name: up_taskdump
****************************************************************************/
-#if defined(CONFIG_STACK_COLORATION) || defined(CONFIG_SCHED_BACKTRACE)
-static void up_taskdump(FAR struct tcb_s *tcb, FAR void *arg)
+static void up_dump_task(FAR struct tcb_s *tcb, FAR void *arg)
Review comment:
on next phase, coming soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org