You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lo...@apache.org on 2022/11/07 19:09:17 UTC

[beam] branch lostluck-patch-4 created (now d6a86e8ca2c)

This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a change to branch lostluck-patch-4
in repository https://gitbox.apache.org/repos/asf/beam.git


      at d6a86e8ca2c Switch && for || to fix bug in #23889 resolution

This branch includes the following new commits:

     new d6a86e8ca2c Switch && for || to fix bug in #23889 resolution

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[beam] 01/01: Switch && for || to fix bug in #23889 resolution

Posted by lo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lostluck pushed a commit to branch lostluck-patch-4
in repository https://gitbox.apache.org/repos/asf/beam.git

commit d6a86e8ca2c0c65ae804afc64b8d8e4db3514059
Author: Robert Burke <lo...@users.noreply.github.com>
AuthorDate: Mon Nov 7 11:09:08 2022 -0800

    Switch && for || to fix bug in #23889 resolution
---
 sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go b/sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go
index c5bf708fa76..e0da8f05556 100644
--- a/sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go
+++ b/sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go
@@ -122,7 +122,7 @@ func (r *Registry) reconcileRegistrations() (deferedErr error) {
 		// We could have either a pointer or non pointer here,
 		// so we strip pointerness and then check both.
 		vT := reflectx.SkipPtr(ut)
-		if check(vT) && check(reflect.PtrTo(vT)) {
+		if check(vT) || check(reflect.PtrTo(vT)) {
 			continue
 		}
 		if err := r.registerType(ut, map[reflect.Type]struct{}{}); err != nil {