You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 13:42:21 UTC

[GitHub] [apisix] BFergerson commented on a change in pull request #3139: feat: support var in upstream_uri on proxy-rewrite plugin

BFergerson commented on a change in pull request #3139:
URL: https://github.com/apache/apisix/pull/3139#discussion_r549708890



##########
File path: t/plugin/proxy-rewrite.t
##########
@@ -1249,3 +1249,41 @@ version: nginx_var_does_not_exist
 x-real-ip: 127.0.0.1
 --- no_error_log
 [error]
+
+
+
+=== TEST 42: set route(rewrite uri based on ctx.var)

Review comment:
       Unfortunately, I think this is the end of my understanding of how to contribute to APISIX. I never heard of Lua before this project so I'm relying on the documentation and contributors of this project to help me understand what to do.
   
   Can you point to other tests (or documentation) which does everything I need to do in my test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org