You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/20 22:05:23 UTC

[GitHub] [incubator-superset] ceohockey60 opened a new pull request #10368: Add supported database logos

ceohockey60 opened a new pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368


   
   ### SUMMARY
   Adding logos of supported database solutions to make README more visual and easier to use.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r462512644



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">

Review comment:
       ```suggestion
   <p align="center">
   ```
   
   This is totally optional, but do you think aligning images to the center would make them look better?
   
   ### Before
   
   ![image](https://user-images.githubusercontent.com/335541/88840337-289c0c80-d191-11ea-83e6-d065afb52933.png)
   
   ### After
   
   ![image](https://user-images.githubusercontent.com/335541/88840301-1c17b400-d191-11ea-8459-b8751d6f0206.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-663338084


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=h1) Report
   > Merging [#10368](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d92cb66f60c8093f0595d7fe2cafb0f9cbad9e55&el=desc) will **decrease** coverage by `5.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10368/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10368      +/-   ##
   ==========================================
   - Coverage   70.63%   65.40%   -5.24%     
   ==========================================
     Files         601      605       +4     
     Lines       32338    32410      +72     
     Branches     3275     3295      +20     
   ==========================================
   - Hits        22843    21197    -1646     
   - Misses       9390    11028    +1638     
   - Partials      105      185      +80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.26% <ø> (-0.35%)` | :arrow_down: |
   | #python | `69.72% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=footer). Last update [d92cb66...fa6918f](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r458535468



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">
+  <img src="https://i.ibb.co/qYyYdsr/redshift.png" alt="redshift" border="0" width="106" height="41" />

Review comment:
       Never heard of `https://i.ibb.co`, wouldn't rely on it.
   
   Your images can be part of this PR (if you can PR you can add images). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-664645381






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud merged pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r457744956



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">
+  <img src="https://i.ibb.co/qYyYdsr/redshift.png" alt="redshift" border="0" width="106" height="41" />

Review comment:
       are these urls ever going to break? Can we add the images to the repo under the apache license?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ceohockey60 commented on a change in pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ceohockey60 commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r458454751



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">
+  <img src="https://i.ibb.co/qYyYdsr/redshift.png" alt="redshift" border="0" width="106" height="41" />

Review comment:
       It's a free imaging hosting site that appears good, so I used it to get this PR going, since I can't upload files to this repo.
   If you can upload files to this repo and prefer that way, I can send you the images for you to upload, then I'll fix this PR with the relative links. Just let me know what you prefer! :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-664680592


   I can see these images potentially being useful for the future doc site or when the Superset app adds a more graphic "add a datasource" page like Redash: https://redash.io/help/user-guide/getting-started#1-Add-A-Data-Source
   
   Currently `docs/_static/images` points to `superset-frontend` anyway so I don't think it's a big issue to add brand images in this existing folder.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-664680592


   I can see these images potentially being useful for the future doc site or when the Superset app adds a more graphic "add a datasource" page like Redash: https://redash.io/help/user-guide/getting-started#1-Add-A-Data-Source
   
   Currently `docs/_static/images` points to `superset-frontend` anyway so I didn't think it was a big issue to add brand images in this existing folder.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ceohockey60 commented on a change in pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ceohockey60 commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r464557689



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">

Review comment:
       Yes! 100%




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ceohockey60 commented on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ceohockey60 commented on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-663339710


   Upload logos to repo and updated links. PTAL @etr2460 Thank you. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-663338084


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=h1) Report
   > Merging [#10368](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d92cb66f60c8093f0595d7fe2cafb0f9cbad9e55&el=desc) will **decrease** coverage by `5.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10368/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10368      +/-   ##
   ==========================================
   - Coverage   70.63%   65.40%   -5.23%     
   ==========================================
     Files         601      605       +4     
     Lines       32338    32419      +81     
     Branches     3275     3295      +20     
   ==========================================
   - Hits        22843    21205    -1638     
   - Misses       9390    11029    +1639     
   - Partials      105      185      +80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.26% <ø> (-0.35%)` | :arrow_down: |
   | #python | `69.73% <ø> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/10368/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=footer). Last update [d92cb66...fa6918f](https://codecov.io/gh/apache/incubator-superset/pull/10368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-664114061


   I'd recommend putting them under `superset-frontend/images/supported-databases` and [using relative paths](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-readmes#relative-links-and-image-paths-in-readme-files):
   
   ```html
   <img src="supported-frontend/images/supported-databases/redshift.png" alt="redshift" border="0" width="106" height="41"/>
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10368: docs: Add supported database logos

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#issuecomment-663338084






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org