You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/20 00:11:31 UTC
[GitHub] [skywalking-cli] mrproliu opened a new pull request, #167: Adapt the new record query API for sub-command `metrics sampled-record`
mrproliu opened a new pull request, #167:
URL: https://github.com/apache/skywalking-cli/pull/167
This PR is adapt the new record query API: https://github.com/apache/skywalking-query-protocol/pull/100
After this PR has been merged, I will submit other PR in the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167#issuecomment-1284735854
I think metrics sampled-record should be an alias, and we need a new record command to map for the new protocol?
https://skywalking.apache.org/docs/main/next/en/protocols/query-protocol/#record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167#issuecomment-1284813146
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167#issuecomment-1284803385
Should be add 9.3.0 requirement for next CLI release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-commenter commented on pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167#issuecomment-1284788984
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#167](https://codecov.io/gh/apache/skywalking-cli/pull/167?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2ab19a) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/710114fae948875948dde84663b975fbfcca0098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (710114f) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 26.20% 26.20%
=======================================
Files 22 22
Lines 458 458
=======================================
Hits 120 120
Misses 328 328
Partials 10 10
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167#issuecomment-1284739559
Sure, I could create a new command: `records list` to query records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng merged pull request #167: Adapt the new record query API for sub-command `metrics sampled-record`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #167:
URL: https://github.com/apache/skywalking-cli/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org