You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2024/02/14 20:02:28 UTC

Re: [PR] feat(storybook): Co-habitating/Upgrading Storybooks to 7 [superset]

codecov[bot] commented on PR #26907:
URL: https://github.com/apache/superset/pull/26907#issuecomment-1944504558

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `24 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`af577d6`)](https://app.codecov.io/gh/apache/superset/commit/af577d64b17a9730e28e9021376318326fe31437?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.16% compared to head [(`c462bff`)](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.16%.
   > Report is 1 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...end/src/visualizations/TimeTable/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy50cw==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ugin-chart-echarts/src/Waterfall/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvV2F0ZXJmYWxsL3RyYW5zZm9ybVByb3BzLnRz) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...-frontend/src/components/UiConfigContext/index.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVWlDb25maWdDb250ZXh0L2luZGV4LnRzeA==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rols/MetricControl/AdhocMetricEditPopoverTitle.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXJUaXRsZS50c3g=) | 86.95% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...hart-pivot-table/src/react-pivottable/utilities.js](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvdXRpbGl0aWVzLmpz) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../cell-renderers/ActionCell/ActionCell.overview.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvY2VsbC1yZW5kZXJlcnMvQWN0aW9uQ2VsbC9BY3Rpb25DZWxsLm92ZXJ2aWV3LnRzeA==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...res/alerts/components/AlertReportCronScheduler.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FsZXJ0cy9jb21wb25lbnRzL0FsZXJ0UmVwb3J0Q3JvblNjaGVkdWxlci50c3g=) | 87.50% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...perset-ui-chart-controls/src/components/Select.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvU2VsZWN0LnRzeA==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [2 more](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26907      +/-   ##
   ==========================================
   - Coverage   67.16%   67.16%   -0.01%     
   ==========================================
     Files        1900     1901       +1     
     Lines       74447    74452       +5     
     Branches     8297     8301       +4     
   ==========================================
     Hits        50005    50005              
   - Misses      22387    22392       +5     
     Partials     2055     2055              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/26907/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/26907/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.84% <78.94%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org