You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/06 00:09:31 UTC

[GitHub] [spark] dilipbiswal edited a comment on issue #23982: [SQL][MINOR] Reconcile the join types between data frame and sql interface

dilipbiswal edited a comment on issue #23982: [SQL][MINOR] Reconcile the join types between data frame and sql interface
URL: https://github.com/apache/spark/pull/23982#issuecomment-469910613
 
 
   @dongjoon-hyun Thanks.. I totally understand :-). So here are the options : 
   1) Do nothing
   2) Make LEFT mandatory. Its in theory a breaking change. I thought we can simplify stuffs in a 
       major release. We could put a couple of lines in documentation asking users to add the LEFT 
       keyword on a parsing failure. In reality i expect very very few users to be directly using this 
      join type as very few databases expose this join type to users. Thats just my guess ..
   3) Make LEFT optional for semi join for pairty with the ANTI join counter-part and expose "semi" and "anti" as join types from dataframe.
   4) Perhaps there is another option ?? :-)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org